Re: [PATCH 2/7 v3] mmc: use .multi_io_quirk on omap_hsmmc

2014-09-08 Thread Kuninori Morimoto
Hi Ulf > > omap_hsmmc@0 0xAA irq = (MULTI read workaround is needed) > > omap_hsmmc@1 0xBB irq = (MULTI read workaround is not needed) > > > > Maybe current omap doesn't have 2 hsmmc on 1 SoC (I don't know) > > but, we don't know the future ? > > Of course I can follow your styl

Re: [PATCH 2/7 v3] mmc: use .multi_io_quirk on omap_hsmmc

2014-09-08 Thread Ulf Hansson
On 9 September 2014 08:07, Kuninori Morimoto wrote: > > Hi Ulf > >> > This means we need to copy this ops for each driver ? >> > Otherwise, it breaks behavior if many drivers were probed. >> >> The are only one driver for omap_hsmmc, this is not tmio, which >> certainly is a different story. >> >>

Re: [PATCH 2/7 v3] mmc: use .multi_io_quirk on omap_hsmmc

2014-09-08 Thread Kuninori Morimoto
Hi Ulf > > This means we need to copy this ops for each driver ? > > Otherwise, it breaks behavior if many drivers were probed. > > The are only one driver for omap_hsmmc, this is not tmio, which > certainly is a different story. > > What you need to do, is to make omap_hsmmc_ops non const - an

Re: [PATCH 2/7 v3] mmc: use .multi_io_quirk on omap_hsmmc

2014-09-08 Thread Ulf Hansson
On 9 September 2014 02:09, Kuninori Morimoto wrote: > > Hi Ulf > >> > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c >> > index ece1634..7b41f57 100644 >> > --- a/drivers/mmc/host/omap_hsmmc.c >> > +++ b/drivers/mmc/host/omap_hsmmc.c >> > @@ -219,6 +219,7 @@ struct omap

Re: [PATCH 2/7 v3] mmc: use .multi_io_quirk on omap_hsmmc

2014-09-08 Thread Kuninori Morimoto
Hi Ulf > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > > index ece1634..7b41f57 100644 > > --- a/drivers/mmc/host/omap_hsmmc.c > > +++ b/drivers/mmc/host/omap_hsmmc.c > > @@ -219,6 +219,7 @@ struct omap_hsmmc_host { > > #define AUTO_CMD23 (1 << 0)

Re: [PATCH 2/7 v3] mmc: use .multi_io_quirk on omap_hsmmc

2014-09-08 Thread Ulf Hansson
On 3 September 2014 04:09, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Now, omap_hsmmc can use .multi_io_quirk callback > instead of MMC_CAP2_NO_MULTI_READ flags. > let's use it. > > Signed-off-by: Kuninori Morimoto > --- > v2 -> v3 > > - blk_size_workaround -> multi_io_quirk > > dr

[PATCH 2/7 v3] mmc: use .multi_io_quirk on omap_hsmmc

2014-09-02 Thread Kuninori Morimoto
From: Kuninori Morimoto Now, omap_hsmmc can use .multi_io_quirk callback instead of MMC_CAP2_NO_MULTI_READ flags. let's use it. Signed-off-by: Kuninori Morimoto --- v2 -> v3 - blk_size_workaround -> multi_io_quirk drivers/mmc/host/omap_hsmmc.c | 17 - 1 file changed, 16 in