Re: [PATCH 5/5] SDIO: put active devices into 1-bit mode during suspend

2010-02-10 Thread David Vrabel
Chris Ball wrote: > Hi David, > >> I couldn't find anything in the SDIO specification (you know the >> section number?). Part A2 has a requirement that the controller >> be placed into 1-bit mode but this doesn't mean that the card has >> to be. > > I think it's part E1 section 8

Re: [PATCH 5/5] SDIO: put active devices into 1-bit mode during suspend

2010-02-10 Thread Chris Ball
Hi David, > I couldn't find anything in the SDIO specification (you know the > section number?). Part A2 has a requirement that the controller > be placed into 1-bit mode but this doesn't mean that the card has > to be. I think it's part E1 section 8, and does specify that it's neces

Re: [PATCH 5/5] SDIO: put active devices into 1-bit mode during suspend

2010-02-10 Thread David Vrabel
Chris Ball wrote: > Hi David, > >> Why? Is this for a specific card that doesn't support >> asynchronous card interrupts while in 4-bit mode? If so, I'd >> suggest a card quirk for this and only switch modes for these >> cards. > > (As a check that we're on the same page -- sdio

Re: [PATCH 5/5] SDIO: put active devices into 1-bit mode during suspend

2010-02-10 Thread Chris Ball
Hi David, > Why? Is this for a specific card that doesn't support > asynchronous card interrupts while in 4-bit mode? If so, I'd > suggest a card quirk for this and only switch modes for these > cards. (As a check that we're on the same page -- sdio_disable_wide() is only called if

Re: [PATCH 5/5] SDIO: put active devices into 1-bit mode during suspend

2010-02-10 Thread David Vrabel
Nicolas Pitre wrote: > From: Daniel Drake > > And bring them back to 4-bit mode during resume. Why? Is this for a specific card that doesn't support asynchronous card interrupts while in 4-bit mode? If so, I'd suggest a card quirk for this and only switch modes for these cards. > + ctrl |

[PATCH 5/5] SDIO: put active devices into 1-bit mode during suspend

2010-02-09 Thread Nicolas Pitre
From: Daniel Drake And bring them back to 4-bit mode during resume. Signed-off-by: Daniel Drake Signed-off-by: Nicolas Pitre --- drivers/mmc/core/sdio.c | 43 +++ include/linux/mmc/sdio.h |2 ++ 2 files changed, 45 insertions(+), 0 deletions(-)