Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-23 Thread Russell King - ARM Linux
On Mon, Apr 23, 2012 at 07:30:48AM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux [120423 07:17]: > > On Fri, Apr 20, 2012 at 09:50:00AM -0700, Tony Lindgren wrote: > > > Then something like this is still needed on top of your original mmc > > > driver > > > patch for omap2420: > > > >

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-23 Thread Tony Lindgren
* Russell King - ARM Linux [120423 07:17]: > On Fri, Apr 20, 2012 at 09:50:00AM -0700, Tony Lindgren wrote: > > Then something like this is still needed on top of your original mmc driver > > patch for omap2420: > > > > --- a/drivers/mmc/host/omap.c > > +++ b/drivers/mmc/host/omap.c > > @@ -1617,

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-23 Thread Russell King - ARM Linux
On Fri, Apr 20, 2012 at 09:50:00AM -0700, Tony Lindgren wrote: > Then something like this is still needed on top of your original mmc driver > patch for omap2420: > > --- a/drivers/mmc/host/omap.c > +++ b/drivers/mmc/host/omap.c > @@ -1617,11 +1617,14 @@ static int __init mmc_omap_probe(struct >

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-20 Thread Tony Lindgren
* Russell King - ARM Linux [120420 15:13]: > On Fri, Apr 20, 2012 at 09:43:07AM -0700, Tony Lindgren wrote: > > * Russell King - ARM Linux [120420 08:41]: > > > --- a/drivers/dma/omap-dma.c > > > +++ b/drivers/dma/omap-dma.c > > > @@ -83,11 +84,11 @@ static void omap_dma_start_sg(struct omap_chan

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-20 Thread Russell King - ARM Linux
On Fri, Apr 20, 2012 at 09:43:07AM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux [120420 08:41]: > > --- a/drivers/dma/omap-dma.c > > +++ b/drivers/dma/omap-dma.c > > @@ -83,11 +84,11 @@ static void omap_dma_start_sg(struct omap_chan *c, > > struct omap_desc *d, > > struct omap_sg

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-20 Thread Tony Lindgren
* Russell King - ARM Linux [120420 08:41]: > > So, with this patch plus my original patch to omap's mmc host driver, this > should result in something which works without all the overhead of drivers > supplying the port information. Please confirm, and I'll merge this into > the original omap-dm

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-20 Thread Tony Lindgren
* Russell King - ARM Linux [120420 08:41]: > --- a/drivers/dma/omap-dma.c > +++ b/drivers/dma/omap-dma.c > @@ -83,11 +84,11 @@ static void omap_dma_start_sg(struct omap_chan *c, struct > omap_desc *d, > struct omap_sg *sg = d->sg + idx; > > if (d->dir == DMA_DEV_TO_MEM) > -

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-20 Thread Russell King - ARM Linux
On Fri, Apr 20, 2012 at 08:26:25AM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux [120420 08:15]: > > On Thu, Apr 19, 2012 at 11:07:42AM -0700, Tony Lindgren wrote: > > > There's some information in the omap5912 trm on pages 717 and 718: > > > > > > http://www.ti.com/litv/pdf/spru742 >

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-20 Thread Tony Lindgren
* Russell King - ARM Linux [120420 08:15]: > On Thu, Apr 19, 2012 at 11:07:42AM -0700, Tony Lindgren wrote: > > * Russell King - ARM Linux [120419 10:46]: > > > On Wed, Apr 18, 2012 at 06:39:14PM -0700, Tony Lindgren wrote: > > > > Cool, you almost got it. Got it working for n800 and 770 with the

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-20 Thread Russell King - ARM Linux
On Thu, Apr 19, 2012 at 11:07:42AM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux [120419 10:46]: > > On Wed, Apr 18, 2012 at 06:39:14PM -0700, Tony Lindgren wrote: > > > Cool, you almost got it. Got it working for n800 and 770 with the > > > following > > > patch. Only extremely light

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-19 Thread Tony Lindgren
* Russell King - ARM Linux [120419 10:46]: > On Wed, Apr 18, 2012 at 06:39:14PM -0700, Tony Lindgren wrote: > > Cool, you almost got it. Got it working for n800 and 770 with the following > > patch. Only extremely light testing done now so careful with this patch > > too.. > > > > Had to hack in

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-19 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 06:39:14PM -0700, Tony Lindgren wrote: > Cool, you almost got it. Got it working for n800 and 770 with the following > patch. Only extremely light testing done now so careful with this patch too.. > > Had to hack in support for the src_port and dst_port that's needed for >

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Tony Lindgren
* Russell King - ARM Linux [120418 14:40]: > On Wed, Apr 18, 2012 at 10:16:06PM +0100, Russell King - ARM Linux wrote: > > I don't think it has to in this case, though I am thinking that we > > may have to adjust the frame size for other peripherals. > > > > In the case of the OMAP1 MMC driver, l

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 10:16:06PM +0100, Russell King - ARM Linux wrote: > I don't think it has to in this case, though I am thinking that we > may have to adjust the frame size for other peripherals. > > In the case of the OMAP1 MMC driver, let me pull out that chunk of code > again: > >

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Tony Lindgren
* Russell King - ARM Linux [120418 14:19]: > On Wed, Apr 18, 2012 at 02:01:44PM -0700, Tony Lindgren wrote: > > * Russell King - ARM Linux [120418 13:28]: > > > I'd like to have the same thing happen on OMAP1 as well (it's actually > > > quite simple to do) and it means that this DMA engine imple

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 02:01:44PM -0700, Tony Lindgren wrote: > * Russell King - ARM Linux [120418 13:28]: > > I'd like to have the same thing happen on OMAP1 as well (it's actually > > quite simple to do) and it means that this DMA engine implementation > > detail is (correctly) hidden from the

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Tony Lindgren
* Russell King - ARM Linux [120418 13:28]: > On Wed, Apr 18, 2012 at 01:02:15PM -0700, Tony Lindgren wrote: > > The scatterlist entries are separate DMA requests on omap1, there's no > > chaining support in the DMA hardware on omap1. So yes, it's for every > > scatterlist entry on omap1. > > Ther

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 01:02:15PM -0700, Tony Lindgren wrote: > The scatterlist entries are separate DMA requests on omap1, there's no > chaining support in the DMA hardware on omap1. So yes, it's for every > scatterlist entry on omap1. There's no direct scatterlist support on OMAP2 either (omap_

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Tony Lindgren
* Russell King - ARM Linux [120418 12:46]: > On Wed, Apr 18, 2012 at 09:05:56PM +0530, T Krishnamoorthy, Balaji wrote: > > On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux > > wrote: > > > On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: > > >> Hi, > > >> > > >>

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Tony Lindgren
* Russell King - ARM Linux [120418 12:14]: > On Wed, Apr 18, 2012 at 11:19:18AM -0700, Tony Lindgren wrote: > > * T Krishnamoorthy, Balaji [120418 08:39]: > > > On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux > > > wrote: > > > > On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoort

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 09:05:56PM +0530, T Krishnamoorthy, Balaji wrote: > On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux > wrote: > > On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: > >> Hi, > >> > >> drivers/mmc/host/omap.c is also using dma_mask should that

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 11:19:18AM -0700, Tony Lindgren wrote: > * T Krishnamoorthy, Balaji [120418 08:39]: > > On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux > > wrote: > > > On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: > > >> Hi, > > >> > > >> drivers/mmc

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Tony Lindgren
* T Krishnamoorthy, Balaji [120418 08:39]: > On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux > wrote: > > On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: > >> Hi, > >> > >> drivers/mmc/host/omap.c is also using dma_mask should that also be removed > > > > Does

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread T Krishnamoorthy, Balaji
On Wed, Apr 18, 2012 at 8:59 PM, Russell King - ARM Linux wrote: > On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: >> Hi, >> >> drivers/mmc/host/omap.c is also using dma_mask should that also be removed > > Does this driver make use of this platform data? > > If so, it ne

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King - ARM Linux
On Wed, Apr 18, 2012 at 08:53:32PM +0530, T Krishnamoorthy, Balaji wrote: > Hi, > > drivers/mmc/host/omap.c is also using dma_mask should that also be removed Does this driver make use of this platform data? If so, it needs converting to DMA engine _before_ this patch (which is one reason why it

Re: [PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread T Krishnamoorthy, Balaji
On Wed, Apr 18, 2012 at 3:42 PM, Russell King wrote: > DMAengine uses the DMA engine device structure when mapping/unmapping > memory for DMA, so the MMC devices do not need their DMA masks > initialized (this reflects hardware: the MMC device is not the device > doing DMA.) > > Signed-off-by: Rus

[PATCH 8/8] ARM: omap_hsmmc: remove platform data dma_mask and initialization

2012-04-18 Thread Russell King
DMAengine uses the DMA engine device structure when mapping/unmapping memory for DMA, so the MMC devices do not need their DMA masks initialized (this reflects hardware: the MMC device is not the device doing DMA.) Signed-off-by: Russell King --- arch/arm/mach-omap1/board-h2-mmc.c|1 - a