Re: [PATCH RFC 31/31] mmc: sdhci-tegra: get rid of special PRESENT_STATE register handling

2014-02-19 Thread Russell King - ARM Linux
On Wed, Feb 19, 2014 at 11:22:53PM +, Russell King - ARM Linux wrote: > The script was a little too over-zealous. It was just supposed to do > the following transformation: > > --- => =-DO NOT APPLY-= > +++ => =+DO NOT APPLY+= > > which would've made it reversible with a trivial sed expressi

Re: [PATCH RFC 31/31] mmc: sdhci-tegra: get rid of special PRESENT_STATE register handling

2014-02-19 Thread Russell King - ARM Linux
On Wed, Feb 19, 2014 at 01:04:19PM -0700, Stephen Warren wrote: > On 02/18/2014 08:11 AM, Russell King wrote: > > sdhci-tegra provides a get_ro method, which overrides the checking > > of the write protect bit in the PRESENT_STATE register in sdhci.c: > > > > if (host->flags & SDHCI_DEVICE

Re: [PATCH RFC 31/31] mmc: sdhci-tegra: get rid of special PRESENT_STATE register handling

2014-02-19 Thread Stephen Warren
On 02/18/2014 08:11 AM, Russell King wrote: > sdhci-tegra provides a get_ro method, which overrides the checking > of the write protect bit in the PRESENT_STATE register in sdhci.c: > > if (host->flags & SDHCI_DEVICE_DEAD) > is_readonly = 0; > else if (host->ops->ge

[PATCH RFC 31/31] mmc: sdhci-tegra: get rid of special PRESENT_STATE register handling

2014-02-18 Thread Russell King
sdhci-tegra provides a get_ro method, which overrides the checking of the write protect bit in the PRESENT_STATE register in sdhci.c: if (host->flags & SDHCI_DEVICE_DEAD) is_readonly = 0; else if (host->ops->get_ro) is_readonly = host->ops->get_ro(ho