Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-24 Thread zhangfei gao
2010/10/24 Marek Vasut : > Dne Ne 24. října 2010 05:26:38 zhangfei gao napsal(a): >> On Sun, Oct 24, 2010 at 1:50 AM, Marek Vasut wrote: >> > Dne So 23. října 2010 18:47:10 zhangfei gao napsal(a): >> >> On Sat, Oct 23, 2010 at 10:24 PM, Marek Vasut > wrote: >> >> >> +/

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-23 Thread Marek Vasut
Dne Ne 24. října 2010 05:26:38 zhangfei gao napsal(a): > On Sun, Oct 24, 2010 at 1:50 AM, Marek Vasut wrote: > > Dne So 23. října 2010 18:47:10 zhangfei gao napsal(a): > >> On Sat, Oct 23, 2010 at 10:24 PM, Marek Vasut wrote: > >> >> +/

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-23 Thread zhangfei gao
On Sun, Oct 24, 2010 at 1:50 AM, Marek Vasut wrote: > Dne So 23. října 2010 18:47:10 zhangfei gao napsal(a): >> On Sat, Oct 23, 2010 at 10:24 PM, Marek Vasut wrote: >> >> +/** >> >> *** \ + * >> >>         * + * Device probin

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-23 Thread Marek Vasut
Dne So 23. října 2010 18:47:10 zhangfei gao napsal(a): > On Sat, Oct 23, 2010 at 10:24 PM, Marek Vasut wrote: > >> +/** > >> *** \ + * > >> * + * Device probing/removal > >> * + * > >> *

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-23 Thread zhangfei gao
On Sat, Oct 23, 2010 at 10:24 PM, Marek Vasut wrote: >> +/* >> \ + * >>         * + * Device probing/removal >>              * + * >>                   * >> +\**

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-23 Thread Marek Vasut
Dne Pá 22. října 2010 16:09:03 zhangfei gao napsal(a): > On Fri, Oct 22, 2010 at 7:04 AM, Chris Ball wrote: > > Hi, > > > > On Fri, Oct 22, 2010 at 10:58:14AM +0100, Chris Ball wrote: > > [...] > > > >> +#ifdef CONFIG_PM > >> +static int sdhci_pxa_suspend(struct platform_device *dev) > >> +{ > >

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-22 Thread zhangfei gao
On Fri, Oct 22, 2010 at 7:04 AM, Chris Ball wrote: > Hi, > > On Fri, Oct 22, 2010 at 10:58:14AM +0100, Chris Ball wrote: > [...] >> +#ifdef CONFIG_PM >> +static int sdhci_pxa_suspend(struct platform_device *dev) >> +{ >> +     struct sdhci_host *host = >> platform_get_drvdata(to_platform_device(d

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-22 Thread Chris Ball
Hi, On Fri, Oct 22, 2010 at 10:58:14AM +0100, Chris Ball wrote: [...] > +#ifdef CONFIG_PM > +static int sdhci_pxa_suspend(struct platform_device *dev) > +{ > + struct sdhci_host *host = platform_get_drvdata(to_platform_device(dev)); > + > + return sdhci_suspend_host(host, state); > +} > +

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-22 Thread Chris Ball
Hi Russell, On Fri, Oct 22, 2010 at 04:44:07PM +0800, Haojian Zhuang wrote: > I'm fine on this. Please merge it via the MMC tree. I'm planning on merging this patch via the MMC tree, please let me know if you object. Thanks. From: Zhangfei Gao Date: Mon, 20 Sep 2010 10:51:28 -0400 Subject: [P

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-22 Thread Haojian Zhuang
On Thu, Oct 21, 2010 at 10:52 PM, Chris Ball wrote: > Hi, > > On Thu, Oct 21, 2010 at 03:13:02PM +0100, Chris Ball wrote: >> On Mon, Oct 18, 2010 at 08:32:46AM -0400, zhangfei gao wrote: >> > Update with comments from Matt and Eric. >> > Test with sd and emmc. >> > >> > >From e5dd554ed4d3488a83d9a

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-21 Thread Chris Ball
Hi Marek, On Fri, Oct 22, 2010 at 02:20:10AM +0200, Marek Vasut wrote: > > > I'll take the drivers/mmc/ hunks, but you should send the plat-pxa/ > > > patch through the ARM tree. > > > > Oh. If we do that then the driver won't compile until everything's > > together, because it #includes . Haoj

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-21 Thread Marek Vasut
Dne Čt 21. října 2010 16:52:49 Chris Ball napsal(a): > Hi, > > On Thu, Oct 21, 2010 at 03:13:02PM +0100, Chris Ball wrote: > > On Mon, Oct 18, 2010 at 08:32:46AM -0400, zhangfei gao wrote: > > > Update with comments from Matt and Eric. > > > Test with sd and emmc. > > > > > > >From e5dd554ed4d348

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-21 Thread Chris Ball
Hi, On Thu, Oct 21, 2010 at 03:13:02PM +0100, Chris Ball wrote: > On Mon, Oct 18, 2010 at 08:32:46AM -0400, zhangfei gao wrote: > > Update with comments from Matt and Eric. > > Test with sd and emmc. > > > > >From e5dd554ed4d3488a83d9a4888d68d1d85482f747 Mon Sep 17 00:00:00 2001 > > From: Zhangfe

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-21 Thread zhangfei gao
On Thu, Oct 21, 2010 at 10:13 PM, Chris Ball wrote: > Hi Zhangfei, > > On Mon, Oct 18, 2010 at 08:32:46AM -0400, zhangfei gao wrote: >> Update with comments from Matt and Eric. >> Test with sd and emmc. >> >> >From e5dd554ed4d3488a83d9a4888d68d1d85482f747 Mon Sep 17 00:00:00 2001 >> From: Zhangfei

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-21 Thread Chris Ball
Hi Zhangfei, On Mon, Oct 18, 2010 at 08:32:46AM -0400, zhangfei gao wrote: > Update with comments from Matt and Eric. > Test with sd and emmc. > > >From e5dd554ed4d3488a83d9a4888d68d1d85482f747 Mon Sep 17 00:00:00 2001 > From: Zhangfei Gao > Date: Mon, 20 Sep 2010 10:51:28 -0400 > Subject: [PATC

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-19 Thread zhangfei gao
On Mon, Oct 18, 2010 at 10:03 PM, Wolfram Sang wrote: >> Currently platform driver can not support well of the requirement for >> several device sharing one driver,  each one has different quirk, >> different max_speed, and each device need some specific vectors. >> We prefer using independent dri

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-18 Thread Wolfram Sang
> Currently platform driver can not support well of the requirement for > several device sharing one driver, each one has different quirk, > different max_speed, and each device need some specific vectors. > We prefer using independent driver first. What about a custom init-call reading out the p

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-18 Thread zhangfei gao
On Mon, Oct 18, 2010 at 10:58 PM, Wolfram Sang wrote: > On Mon, Oct 18, 2010 at 08:32:46AM -0400, zhangfei gao wrote: >> Update with comments from Matt and Eric. >> Test with sd and emmc. > > Sorry if I am blind, but why again can't you use the (updated) platform > driver? Currently platform dri

Re: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-18 Thread Wolfram Sang
On Mon, Oct 18, 2010 at 08:32:46AM -0400, zhangfei gao wrote: > Update with comments from Matt and Eric. > Test with sd and emmc. Sorry if I am blind, but why again can't you use the (updated) platform driver? -- Pengutronix e.K. | Wolfram Sang| Industri

[PATCH V3 1/1]MMC: add support of sdhci-pxa driver

2010-10-18 Thread zhangfei gao
Update with comments from Matt and Eric. Test with sd and emmc. >From e5dd554ed4d3488a83d9a4888d68d1d85482f747 Mon Sep 17 00:00:00 2001 From: Zhangfei Gao Date: Mon, 20 Sep 2010 10:51:28 -0400 Subject: [PATCH] mmc: add support of sdhci-pxa driver Support Marvell PXA168/PXA910/MMP2 SD Hos