Re: [PATCH V4] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-23 Thread Chris Ball
Hi Girish, On Fri, Sep 23 2011, Girish K S wrote: >> I suggested replacing your BUG(); here with a return, but you just have >> a break here. Is having the function continue in this case intentional? > > sorry for that. > will update with a return -EBADMSG Thanks; let's go with -EINVAL, though.

Re: [PATCH V4] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-23 Thread Girish K S
Hi Chris, On 23 September 2011 20:09, Chris Ball wrote: > Hi Girish, > > On Fri, Sep 23 2011, Girish K S wrote: >> +     default: >> +             pr_warning("%s: Voltage range not supported " >> +                        "for power class.\n", mmc_hostname(host)); >> +             break; >> +    

Re: [PATCH V4] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-23 Thread Chris Ball
Hi Girish, On Fri, Sep 23 2011, Girish K S wrote: > + default: > + pr_warning("%s: Voltage range not supported " > +"for power class.\n", mmc_hostname(host)); > + break; > + } I suggested replacing your BUG(); here with a return, but you jus

[PATCH V4] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-23 Thread Girish K S
This patch adds the power class selection feature available for mmc versions 4.0 and above. During the enumeration stage before switching to the lower data bus, check if the power class is supported for the current bus width. If the power class is available then switch to the power class and use th