Re: [PATCH V4 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-03-05 Thread Linus Walleij
On Wed, Feb 11, 2015 at 5:34 AM, Ulf Hansson wrote: > On 10 February 2015 at 10:12, Alexandre Courbot wrote: >> This code would be a great candidate to use this GPIO array API, but >> since it is not in -next yet (should happen soon though) you might >> want to consider doing it later. This is

Re: [PATCH V4 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-02-10 Thread Ulf Hansson
On 10 February 2015 at 10:12, Alexandre Courbot wrote: > On Mon, Jan 19, 2015 at 6:13 PM, Ulf Hansson wrote: >> The need for reset GPIOs has several times been pointed out from >> erlier posted patchsets. Especially some WLAN chips which are >> attached to an SDIO interface may use a GPIO reset.

Re: [PATCH V4 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-02-10 Thread Alexandre Courbot
On Mon, Jan 19, 2015 at 6:13 PM, Ulf Hansson wrote: > The need for reset GPIOs has several times been pointed out from > erlier posted patchsets. Especially some WLAN chips which are > attached to an SDIO interface may use a GPIO reset. > > The reset GPIO is asserted at initialization and prior we

Re: [PATCH V4 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-01-28 Thread Javier Martinez Canillas
Hello Ulf, On Mon, Jan 19, 2015 at 10:13 AM, Ulf Hansson wrote: > The need for reset GPIOs has several times been pointed out from > erlier posted patchsets. Especially some WLAN chips which are > attached to an SDIO interface may use a GPIO reset. > > The reset GPIO is asserted at initialization

Re: [PATCH V4 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-01-23 Thread Javier Martinez Canillas
Hello Ulf, On Fri, Jan 23, 2015 at 6:01 PM, Ulf Hansson wrote: >> >> Any reason to not use the devm_gpiod_get_index() managed version instead? > > This struct device don't have a bound driver to it. Thus this device > won't be freed automagically from the ->remove() or failed ->probe() > path. >

Re: [PATCH V4 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-01-23 Thread Ulf Hansson
On 23 January 2015 at 16:56, Javier Martinez Canillas wrote: > Hello Ulf, > > On Mon, Jan 19, 2015 at 10:13 AM, Ulf Hansson wrote: >> >> int mmc_pwrseq_simple_alloc(struct mmc_host *host, struct device *dev) >> { >> struct mmc_pwrseq_simple *pwrseq; >> + int ret = 0; >> >>

Re: [PATCH V4 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-01-23 Thread Javier Martinez Canillas
Hello Ulf, On Mon, Jan 19, 2015 at 10:13 AM, Ulf Hansson wrote: > > int mmc_pwrseq_simple_alloc(struct mmc_host *host, struct device *dev) > { > struct mmc_pwrseq_simple *pwrseq; > + int ret = 0; > > pwrseq = kzalloc(sizeof(struct mmc_pwrseq_simple), GFP_KERNEL); >

[PATCH V4 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-01-19 Thread Ulf Hansson
The need for reset GPIOs has several times been pointed out from erlier posted patchsets. Especially some WLAN chips which are attached to an SDIO interface may use a GPIO reset. The reset GPIO is asserted at initialization and prior we start the power up procedure. The GPIO will be de-asserted ri