Re: [PATCH v1 1/1] mmc: core: skip card initialization if power class selection fails

Hi. Chris. You're right~ we can optmize code properly by moving printk to mmc_select_powerclass. Thanks for your reply. 2012/4/10 Chris Ball : > Hi, > > On Mon, Apr 09 2012, Namjae Jeon wrote: >> Hi Subhash. >> There are duplicate printks in three places. Is there no way to avoid >> duplicate pri

RE: [PATCH v1 1/1] mmc: core: skip card initialization if power class selection fails

> -Original Message- > From: Chris Ball [mailto:c...@laptop.org] > Sent: Tuesday, April 10, 2012 7:46 PM > To: Namjae Jeon > Cc: Subhash Jadavani; linux-mmc@vger.kernel.org; saugata@linaro.org > Subject: Re: [PATCH v1 1/1] mmc: core: skip card initializat

Re: [PATCH v1 1/1] mmc: core: skip card initialization if power class selection fails

Hi, On Mon, Apr 09 2012, Namjae Jeon wrote: > Hi Subhash. > There are duplicate printks in three places. Is there no way to avoid > duplicate printks ? The printk can go just before the final "return err" in mmc_select_powerclass(). Thanks, - Chris. -- Chris Ball One

Re: [PATCH v1 1/1] mmc: core: skip card initialization if power class selection fails

Hi Subhash. There are duplicate printks in three places. Is there no way to avoid duplicate printks ? Thanks. 2012/4/9 Subhash Jadavani : > With current implementation of power class selection, > mmc_select_powerclass() should never fail. So treat any error > returned by this function as serious

[PATCH v1 1/1] mmc: core: skip card initialization if power class selection fails

With current implementation of power class selection, mmc_select_powerclass() should never fail. So treat any error returned by this function as serious enough to skip the card initialization. Signed-off-by: Subhash Jadavani --- drivers/mmc/core/mmc.c | 34 -- 1