Re: [PATCH v2] mmc: sdhci: update check code for cd-broken or nonremovable card

2013-03-05 Thread Kevin Liu
2013/3/1 Kevin Liu : > 2013/3/1 Philip Rakity : >> >> On Mar 1, 2013, at 9:40 AM, Kevin Liu wrote: >> >>> in function sdhci_request: >>> 1. If quirk SDHCI_QUIRK_BROKEN_CARD_DETECTION is selected, there is no >>> card detection available and polling must be used. Gpio detect must >>> _not_ be suppo

Re: [PATCH v2] mmc: sdhci: update check code for cd-broken or nonremovable card

2013-03-01 Thread Kevin Liu
2013/3/1 Philip Rakity : > > On Mar 1, 2013, at 9:40 AM, Kevin Liu wrote: > >> in function sdhci_request: >> 1. If quirk SDHCI_QUIRK_BROKEN_CARD_DETECTION is selected, there is no >> card detection available and polling must be used. Gpio detect must >> _not_ be supported under this case. >> Chang

Re: [PATCH v2] mmc: sdhci: update check code for cd-broken or nonremovable card

2013-03-01 Thread Philip Rakity
On Mar 1, 2013, at 9:40 AM, Kevin Liu wrote: > in function sdhci_request: > 1. If quirk SDHCI_QUIRK_BROKEN_CARD_DETECTION is selected, there is no > card detection available and polling must be used. Gpio detect must > _not_ be supported under this case. > Change the sequence to check SDHCI_QUIR

[PATCH v2] mmc: sdhci: update check code for cd-broken or nonremovable card

2013-03-01 Thread Kevin Liu
in function sdhci_request: 1. If quirk SDHCI_QUIRK_BROKEN_CARD_DETECTION is selected, there is no card detection available and polling must be used. Gpio detect must _not_ be supported under this case. Change the sequence to check SDHCI_QUIRK_BROKEN_CARD_DETECTION first, which make code more clear.