Re: [PATCH v2 1/1] mmc: core: skip card initialization if power class selection fails

2012-04-11 Thread Namjae Jeon
2012/4/12 Girish K S : > On 11 April 2012 19:24, Namjae Jeon wrote: >> Hi. Subhash. Hi. >> Have you considered return -EINVAL in switch ? > That is case which should never enter. Would you explain more why entering never in case? >> And looks complex more.. how about getting bus_width and ddr valu

Re: [PATCH v2 1/1] mmc: core: skip card initialization if power class selection fails

2012-04-11 Thread Girish K S
On 11 April 2012 19:24, Namjae Jeon wrote: > Hi. Subhash. > Have you considered return -EINVAL in switch ? That is case which should never enter. > And looks complex more.. how about getting bus_width and ddr value > from argument ? bus_width is already a argument of mmc_select_powerclass. > > Tha

Re: [PATCH v2 1/1] mmc: core: skip card initialization if power class selection fails

2012-04-11 Thread Namjae Jeon
Hi. Subhash. Have you considered return -EINVAL in switch ? And looks complex more.. how about getting bus_width and ddr value from argument ? Thanks. 2012/4/11 Subhash Jadavani : > With current implementation of power class selection, > mmc_select_powerclass() should never fail. So treat any erro

Re: [PATCH v2 1/1] mmc: core: skip card initialization if power class selection fails

2012-04-11 Thread Girish K S
On 11 April 2012 17:05, Subhash Jadavani wrote: > With current implementation of power class selection, > mmc_select_powerclass() should never fail. So treat any error > returned by this function as serious enough to skip the card > initialization. > > Signed-off-by: Subhash Jadavani > --- >  dri

[PATCH v2 1/1] mmc: core: skip card initialization if power class selection fails

2012-04-11 Thread Subhash Jadavani
With current implementation of power class selection, mmc_select_powerclass() should never fail. So treat any error returned by this function as serious enough to skip the card initialization. Signed-off-by: Subhash Jadavani --- drivers/mmc/core/mmc.c | 26 +++--- 1 files c