RE: [PATCH v2 1/1]mmc: implemented eMMC4.4 enhanced area feature

2011-01-19 Thread Dong, Chuanxiao
Hi Chris, > > On Thu, Jan 20, 2011 at 02:08:04PM +0800, Dong, Chuanxiao wrote: > > > I think these should probably be printed in decimal instead of hex. > > (Will assume you agree with this, let me know if not.) Agree with this. Sorry for missing it. > > > > Hm, this way the sysfs files will sh

Re: [PATCH v2 1/1]mmc: implemented eMMC4.4 enhanced area feature

2011-01-19 Thread Chris Ball
Hi Chuanxiao, On Thu, Jan 20, 2011 at 02:08:04PM +0800, Dong, Chuanxiao wrote: > > I think these should probably be printed in decimal instead of hex. (Will assume you agree with this, let me know if not.) > > Hm, this way the sysfs files will show up regardless of whether we have > > an eMMC de

RE: [PATCH v2 1/1]mmc: implemented eMMC4.4 enhanced area feature

2011-01-19 Thread Dong, Chuanxiao
Hi Chris, Thanks for comments. I will fix the typo and line warp errors in the next submissions. :) > > MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name); > > MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid); > > MMC_DEV_ATTR(serial, "0x%08x\n", card->cid.serial); > > +MMC_DEV_ATTR(enhanced_area

Re: [PATCH v2 1/1]mmc: implemented eMMC4.4 enhanced area feature

2011-01-19 Thread Chris Ball
Hi Chuanxiao, On Thu, Jan 13, 2011 at 08:57:27PM +0800, Chuanxiao Dong wrote: > Enhanced area feature is a new feature defined in eMMC4.4 standard. This > kind of area can help to improve the performance. > > MMC driver will read out the enhanced area offset and size and add them > to be device a

[PATCH v2 1/1]mmc: implemented eMMC4.4 enhanced area feature

2011-01-13 Thread Chuanxiao Dong
Enhanced area feature is a new feature defined in eMMC4.4 standard. This kind of area can help to improve the performance. MMC driver will read out the enhanced area offset and size and add them to be device attributes. The feature enabling should be done in manufactory. To use this feature, bit E