Re: [PATCH v2 2/3] sdhci-pci : Enable runtime PM support

2011-02-25 Thread R. J. Wysocki
On Friday, February 25, 2011, Matthew Garrett wrote: > On Fri, Feb 25, 2011 at 07:33:12AM +, Tardy, Pierre wrote: > > > My understanding is the pci driver is not supposed to do any > > set_power_state/pci_save_state/wake_enable. > > Everything is supposed to be generically handle by pci frame

Re: [PATCH v2 2/3] sdhci-pci : Enable runtime PM support

2011-02-25 Thread Matthew Garrett
On Fri, Feb 25, 2011 at 07:33:12AM +, Tardy, Pierre wrote: > My understanding is the pci driver is not supposed to do any > set_power_state/pci_save_state/wake_enable. > Everything is supposed to be generically handle by pci frameworks's > runtime_pm impl. > Need confirmation from Rafael. T

RE: [PATCH v2 2/3] sdhci-pci : Enable runtime PM support

2011-02-24 Thread Tardy, Pierre
Rafael, Any comments here? > It's getting enabled by drivers/pci/pci-driver.c:local_pci_probe(), > before the sdhci-pci probe function runs. local_pci_probe() does: > > /* Unbound PCI devices are always set to disabled and suspended. > * During probe, the device is set to enabl

Re: [PATCH v2 2/3] sdhci-pci : Enable runtime PM support

2011-02-21 Thread Chris Ball
Hi Pierre, On Sun, Feb 13, 2011 at 11:42:01AM +0100, Pierre Tardy wrote: > > [   10.892280] sdhci-pci :17:00.0: Unbalanced pm_runtime_enable! > > I never have seen this before. I'm not testing those patches on > mmc-next, as our platform is not totally upstream yet, and do not boot > on 2.6.3

Re: [PATCH v2 2/3] sdhci-pci : Enable runtime PM support

2011-02-13 Thread Pierre Tardy
> On Sun, Feb 06, 2011 at 07:02:49PM +0100, Pierre Tardy wrote: >> From: Yunpeng Gao >> >> Follow the kernel runtime PM framework, enable runtime PM support of the >> sdhci host controller with pci interface. >> >> Note that this patch implements runtime_pm but now actually detects >> activity. >>

Re: [PATCH v2 2/3] sdhci-pci : Enable runtime PM support

2011-02-09 Thread Chris Ball
Hi Pierre, On Sun, Feb 06, 2011 at 07:02:49PM +0100, Pierre Tardy wrote: > From: Yunpeng Gao > > Follow the kernel runtime PM framework, enable runtime PM support of the > sdhci host controller with pci interface. > > Note that this patch implements runtime_pm but now actually detects > activit

Re: [PATCH v2 2/3] sdhci-pci : Enable runtime PM support

2011-02-06 Thread Chris Ball
Hi, On Sun, Feb 06, 2011 at 07:02:49PM +0100, Pierre Tardy wrote: > From: Yunpeng Gao > > Follow the kernel runtime PM framework, enable runtime PM support of the > sdhci host controller with pci interface. > > Note that this patch implements runtime_pm but now actually detects > activity. > It

[PATCH v2 2/3] sdhci-pci : Enable runtime PM support

2011-02-06 Thread Pierre Tardy
From: Yunpeng Gao Follow the kernel runtime PM framework, enable runtime PM support of the sdhci host controller with pci interface. Note that this patch implements runtime_pm but now actually detects activity. It relies on higher level (childrens) to do actual waking up Activity detection is pu