Re: [PATCH v2 2/4] mmc: core: group default initial state

2014-11-06 Thread Johan Rudholm
Hi Ulf, 2014-11-06 10:38 GMT+01:00 Ulf Hansson : > [...] > >>> >>> Earlier we used always used MMC_BUSMODE_PUSHPULL, now it will depend on >>> "spi". >> >> The JEDEC spec says that in device identification mode the bus should >> be open-drain and not push-pull. So this way should be compliant to

Re: [PATCH v2 2/4] mmc: core: group default initial state

2014-11-06 Thread Ulf Hansson
[...] >> >> Earlier we used always used MMC_BUSMODE_PUSHPULL, now it will depend on >> "spi". > > The JEDEC spec says that in device identification mode the bus should > be open-drain and not push-pull. So this way should be compliant to > the spec, right? Unfortunately, I will require help in te

Re: [PATCH v2 2/4] mmc: core: group default initial state

2014-11-05 Thread Johan Rudholm
Hi Ulf, 2014-11-05 11:13 GMT+01:00 Ulf Hansson : > On 4 November 2014 16:07, Johan Rudholm wrote: >> mmc_do_hw_reset, mmc_power_up and mmc_power_off all set the same >> group of initial values, simplify by sticking them together. > > That's not entirely true. This patch will actually change the >

Re: [PATCH v2 2/4] mmc: core: group default initial state

2014-11-05 Thread Ulf Hansson
On 4 November 2014 16:07, Johan Rudholm wrote: > mmc_do_hw_reset, mmc_power_up and mmc_power_off all set the same > group of initial values, simplify by sticking them together. That's not entirely true. This patch will actually change the behaviour for the "ios.bus_mode", which isn't exactly what

[PATCH v2 2/4] mmc: core: group default initial state

2014-11-04 Thread Johan Rudholm
mmc_do_hw_reset, mmc_power_up and mmc_power_off all set the same group of initial values, simplify by sticking them together. Signed-off-by: Johan Rudholm --- drivers/mmc/core/core.c | 49 +++ drivers/mmc/core/core.h |1 + 2 files changed, 25 ins