Re: [PATCH v2 2/4] mmc: mmci: move block size validation under relevant code

2014-08-19 Thread Srinivas Kandagatla
On 19/08/14 12:55, Ulf Hansson wrote: writel(host->size, base + MMCIDATALENGTH); > >- blksz_bits = ffs(data->blksz) - 1; >- BUG_ON(1 << blksz_bits != data->blksz); I don't like this BUG_ON at all, I would prefer if we remove it. The original patch "mmc: mmci: Support any b

Re: [PATCH v2 2/4] mmc: mmci: move block size validation under relevant code

2014-08-19 Thread Ulf Hansson
On 19 August 2014 13:14, Srinivas Kandagatla wrote: > This code moves a BUG_ON condition to relevant if block, this check is > not necessary for IPs which can set any arbitrary block size in a given > range. > This patch is necessary for SDIO which sets block sizes that are exactly > not power of

[PATCH v2 2/4] mmc: mmci: move block size validation under relevant code

2014-08-19 Thread Srinivas Kandagatla
This code moves a BUG_ON condition to relevant if block, this check is not necessary for IPs which can set any arbitrary block size in a given range. This patch is necessary for SDIO which sets block sizes that are exactly not power of 2. Original issue detected while testing WLAN ath6kl on Qualco