Re: [PATCH v3] mmc: core: Fix the HPI execution sequence

2012-06-21 Thread S, Venkatraman
hash Jadavani >> Cc: c...@laptop.org; linux-mmc@vger.kernel.org; linkinj...@gmail.com; >> jh80.ch...@samsung.com; alex.lemb...@sandisk.com; Kostya >> Subject: Re: [PATCH v3] mmc: core: Fix the HPI execution sequence >> >> On Wed, Jun 20, 2012 at 11:29 PM, Subhash Jadavan

RE: [PATCH v3] mmc: core: Fix the HPI execution sequence

2012-06-21 Thread Subhash Jadavani
ail.com; > jh80.ch...@samsung.com; alex.lemb...@sandisk.com; Kostya > Subject: Re: [PATCH v3] mmc: core: Fix the HPI execution sequence > > On Wed, Jun 20, 2012 at 11:29 PM, Subhash Jadavani > wrote: > > Hi Venkatraman, > > > >> -Original Message- > >> F

Re: [PATCH v3] mmc: core: Fix the HPI execution sequence

2012-06-21 Thread S, Venkatraman
M >> To: c...@laptop.org >> Cc: linux-mmc@vger.kernel.org; linkinj...@gmail.com; >> jh80.ch...@samsung.com; alex.lemb...@sandisk.com; Venkatraman S; Kostya >> Subject: [PATCH v3] mmc: core: Fix the HPI execution sequence >> >> mmc_execute_hpi should send

RE: [PATCH v3] mmc: core: Fix the HPI execution sequence

2012-06-20 Thread Subhash Jadavani
ail.com; > jh80.ch...@samsung.com; alex.lemb...@sandisk.com; Venkatraman S; Kostya > Subject: [PATCH v3] mmc: core: Fix the HPI execution sequence > > mmc_execute_hpi should send the HPI command only once, and only if the > card is in PRG state. > > According to eMMC spec, the comman

Re: [PATCH v3] mmc: core: Fix the HPI execution sequence

2012-06-20 Thread S, Venkatraman
On Wed, Jun 20, 2012 at 10:31 PM, Chris Ball wrote: > Hi, trivial style comments, > > On Wed, Jun 20 2012, Venkatraman S wrote: >>       switch (R1_CURRENT_STATE(status)) { >> > > No newline here. > >>       case R1_STATE_IDLE: >>       case R1_STATE_READY: >>       case R1_STATE_STBY: /* intentio

Re: [PATCH v3] mmc: core: Fix the HPI execution sequence

2012-06-20 Thread Chris Ball
Hi, trivial style comments, On Wed, Jun 20 2012, Venkatraman S wrote: > switch (R1_CURRENT_STATE(status)) { > No newline here. > case R1_STATE_IDLE: > case R1_STATE_READY: > case R1_STATE_STBY: /* intentional fall through */ > /* In idle states, HPI is not n

[PATCH v3] mmc: core: Fix the HPI execution sequence

2012-06-20 Thread Venkatraman S
mmc_execute_hpi should send the HPI command only once, and only if the card is in PRG state. According to eMMC spec, the command's completion time is not dependent on OUT_OF_INTERRUPT_TIME. Only the transition out of PRG STATE is guarded by OUT_OF_INTERRUPT_TIME - which is defined to begin at the