Re: [PATCH v4 2/8] wireless: wl1271: support return value for the set power func

2010-08-11 Thread Ohad Ben-Cohen
On Wed, Aug 11, 2010 at 9:35 PM, DebBarma, Tarun Kanti wrote: >> -     wl->if_ops->power(wl, true); >> -     set_bit(WL1271_FLAG_GPIO_POWER, &wl->flags); >> +     int ret = wl->if_ops->power(wl, true); > Just a minor comment, need a blank line here? Can't hurt, thanks. >> +     if (ret == 0) >

RE: [PATCH v4 2/8] wireless: wl1271: support return value for the set power func

2010-08-11 Thread DebBarma, Tarun Kanti
rnel.org > Cc: Ido Yariv; Mark Brown; linux-arm-ker...@lists.infradead.org; > Chikkature Rajashekar, Madhusudhan; Luciano Coelho; a...@linux- > foundation.org; San Mehat; Roger Quadros; Tony Lindgren; Nicolas Pitre; > Pandita, Vikram; Kalle Valo; Ohad Ben-Cohen > Subject: [PATCH

[PATCH v4 2/8] wireless: wl1271: support return value for the set power func

2010-08-11 Thread Ohad Ben-Cohen
Make it possible for the set power method to indicate a success/failure return value. This is needed to support more complex power on/off operations such as bringing up (and down) sdio functions. Signed-off-by: Ohad Ben-Cohen --- drivers/net/wireless/wl12xx/wl1271.h |2 +- drivers/net/w