Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver

2014-03-28 Thread Roger
On 03/28/2014 04:31 PM, Oliver Neukum wrote: On Fri, 2014-03-28 at 11:33 +0800, Roger wrote: On 03/26/2014 10:36 PM, Oliver Neukum wrote: On Tue, 2014-03-25 at 18:44 +0800, rogera...@realtek.com wrote: From: Roger Tseng + if (ret) + goto out_init_fail; + + /* ini

Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver

2014-03-28 Thread Oliver Neukum
On Fri, 2014-03-28 at 11:33 +0800, Roger wrote: > On 03/26/2014 10:36 PM, Oliver Neukum wrote: > > On Tue, 2014-03-25 at 18:44 +0800, rogera...@realtek.com wrote: > >> From: Roger Tseng > >> + if (ret) > >> + goto out_init_fail; > >> + > >> + /* initialize USB SG transfer timer */ > >>

Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver

2014-03-28 Thread Lee Jones
[...] > >>+static int rtsx_usb_suspend(struct usb_interface *intf, pm_message_t > >>message) > >>+{ > >>+ struct rtsx_ucr *ucr = > >>+ (struct rtsx_ucr *)usb_get_intfdata(intf); > >>+ > >>+ dev_dbg(&intf->dev, "%s called with pm message 0x%04u\n", > >>+ __func__, m

Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver

2014-03-27 Thread Roger
On 03/26/2014 10:36 PM, Oliver Neukum wrote: On Tue, 2014-03-25 at 18:44 +0800, rogera...@realtek.com wrote: From: Roger Tseng +static int rtsx_usb_probe(struct usb_interface *intf, +const struct usb_device_id *id) +{ + struct usb_device *usb_dev = interface_t

Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver

2014-03-26 Thread Oliver Neukum
On Tue, 2014-03-25 at 18:44 +0800, rogera...@realtek.com wrote: > From: Roger Tseng > +static int rtsx_usb_bulk_transfer_sglist(struct rtsx_ucr *ucr, > + unsigned int pipe, struct scatterlist *sg, int num_sg, > + unsigned int length, unsigned int *act_len, int timeout) > +

[PATCH v5 1/3] mfd: Add realtek USB card reader driver

2014-03-25 Thread rogerable
From: Roger Tseng Realtek USB card reader provides a channel to transfer command or data to flash memory cards. This driver exports host instances for mmc and memstick subsystems and handles basic works. Signed-off-by: Roger Tseng --- drivers/mfd/Kconfig | 10 + drivers/mfd/Makefile