RE: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-07-16 Thread Avi Shchislowski
Johansson; Puthikorn Voravootivat Subject: Re: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0 Also: - you don't need to allocate a buffer buf in mmc_ffu_download, you can directly call mmc_ffu_write with fw->data; you are memcopying the data again in mmc_ffu_area_init(). - mmc_ffu_prepare_

Re: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-07-09 Thread Grant Grundler
PIng. :) Just a friendly reminder. I am aware of additional issues that Gwendal pointed out. But I still think it's better to take this patch now, knowing there are issues (which is better than NOT knowing there are issues), and then review additional patches for the outstand issues. thanks, gra

RE: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-07-03 Thread Alex Lemberg
..@laptop.org; Ulf > Hansson; linux-mmc@vger.kernel.org; Alex Lemberg; Olof Johansson; > Puthikorn Voravootivat > Subject: Re: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0 > > [resent in text mode] > Avi, > + I am testing the patch on a system where the firmware image is on

Re: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-07-02 Thread Gwendal Grignou
>> Thanks >> Avi >> >> -Original Message- >> From: Hsin-Hsiang Tseng [mailto:hsinhsiangts...@gmail.com] >> Sent: Tuesday, July 01, 2014 9:29 AM >> To: Chris Ball >> Cc: Grant Grundler; c...@laptop.org; Ulf Hansson; linux-mmc@vger.kernel.o

Re: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-07-02 Thread Gwendal Grignou
> Sent: Tuesday, July 01, 2014 9:29 AM > To: Chris Ball > Cc: Grant Grundler; c...@laptop.org; Ulf Hansson; linux-mmc@vger.kernel.org; > Alex Lemberg; Avi Shchislowski; Olof Johansson > Subject: Re: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0 > > Hi, Chris, > I think

Re: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-07-01 Thread Ulf Hansson
On 1 July 2014 17:47, Grant Grundler wrote: > On Mon, Jun 30, 2014 at 5:34 PM, Chris Ball wrote: >> Hi Grant, sorry about the delay. >> >> On Tue, Jul 01 2014, Grant Grundler wrote: >>> ping? Another week is past. >>> >>> I know you guys are busy with other stuff. But please at least publish >>>

Re: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-07-01 Thread Grant Grundler
On Mon, Jun 30, 2014 at 5:34 PM, Chris Ball wrote: > Hi Grant, sorry about the delay. > > On Tue, Jul 01 2014, Grant Grundler wrote: >> ping? Another week is past. >> >> I know you guys are busy with other stuff. But please at least publish >> what you think the next steps for this patch are. >> >

RE: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-07-01 Thread Avi Shchislowski
AM To: Chris Ball Cc: Grant Grundler; c...@laptop.org; Ulf Hansson; linux-mmc@vger.kernel.org; Alex Lemberg; Avi Shchislowski; Olof Johansson Subject: Re: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0 Hi, Chris, I think there are two reasons why doing FFU in kernel-space makes more sense

Re: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-06-30 Thread Hsin-Hsiang Tseng
Hi, Chris, I think there are two reasons why doing FFU in kernel-space makes more sense. First, some eMMC (according to extCSD[492] FFU_FEATURES) will need to restart eMMC after FFU. Second, if host want to vouch "atmoic" in FFU process, we need to call mmc_claim_host API, and this API is the ker

Re: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-06-30 Thread Chris Ball
Hi Grant, sorry about the delay. On Tue, Jul 01 2014, Grant Grundler wrote: > ping? Another week is past. > > I know you guys are busy with other stuff. But please at least publish > what you think the next steps for this patch are. > > This is a critical patch for supporting eMMC products and add

Re: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-06-30 Thread Grant Grundler
ping? Another week is past. I know you guys are busy with other stuff. But please at least publish what you think the next steps for this patch are. This is a critical patch for supporting eMMC products and adding additional support for other vendors. I'd like to continue working with "upstream"

RE: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-06-29 Thread Avi Shchislowski
: Saturday, June 28, 2014 4:46 PM To: Grant Grundler Cc: c...@laptop.org; linux-mmc@vger.kernel.org; Alex Lemberg; Avi Shchislowski; Ulf Hansson Subject: Re: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0 2014-06-28 2:33 GMT+08:00 Grant Grundler : > On Mon, Jun 23, 2014 at 6:17 PM, Hsin-Hsiang Ts

Re: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-06-28 Thread Hsin-Hsiang Tseng
2014-06-28 2:33 GMT+08:00 Grant Grundler : > On Mon, Jun 23, 2014 at 6:17 PM, Hsin-Hsiang Tseng > wrote: >> Hi, Grant, I am interested in this topic too. >> >> I have some issues want to discuss here. Should we check the firmware bin >> file before we execute FFU? (for example, execute checksum to

Re: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-06-27 Thread Grant Grundler
On Mon, Jun 23, 2014 at 6:17 PM, Hsin-Hsiang Tseng wrote: > Hi, Grant, I am interested in this topic too. > > I have some issues want to discuss here. Should we check the firmware bin > file before we execute FFU? (for example, execute checksum to verify > firmware bin file) Should eMMC controlle

Fwd: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-06-23 Thread Hsin-Hsiang Tseng
Hi, Grant, I am interested in this topic too. I have some issues want to discuss here. Should we check the firmware bin file before we execute FFU? (for example, execute checksum to verify firmware bin file) Should eMMC controller vendors cover this issue? Another issue is about interrupt, beca

Re: [RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-06-23 Thread Grant Grundler
Chris, Ulf, Any reason the eMMC 5.0 FFU patch can't be integrated into linux-mmc tree? While I can't directly test this patch due to limitations of which HW ChromeOS supports, I believe it's a big step in the right direction. It would also make life easier for other vendors to add FFU support onc

[RFC PATCH 1/1 v7]mmc: Support-FFU-for-eMMC-v5.0

2014-05-19 Thread Avi Shchislowski
The Field Firmware Update (FFU) feature is new for eMMC 5.0 spec (Jedec: JESD84-B50.pdf) http://www.jedec.org/standards-documents/technology-focus-areas/flash-memory-ssds-ufs-emmc/e-mmc An ioctl has been added to provide the new firmware image's file name to the mmc driver and udev is then