Re: [linux-sunxi] Re: [RFC] mmc: core: Set clock before switching to highspeed mode.

2015-09-09 Thread Hans de Goede
Hi, On 08-09-15 17:38, Yousong Zhou wrote: I just tried a method from allwinner's u-boot sources: retry the mode switch in case of an error [1]. It was accompanied with a comment quoted below: //retry for Toshiba emmc;for the first time Toshiba emmc change to HS //it will return response crc e

Re: [linux-sunxi] Re: [RFC] mmc: core: Set clock before switching to highspeed mode.

2015-09-08 Thread Yousong Zhou
On 7 September 2015 at 15:02, Hans de Goede wrote: > Hi, > > > On 06-09-15 16:47, Yousong Zhou wrote: >> >> On Sep 6, 2015 10:14 PM, "Shawn Lin" wrote: >>> >>> >>> 在 2015/9/6 20:09, Yousong Zhou 写道: Hi, On 6 September 2015 at 08:12, Shawn Lin wrote: > >

Re: [linux-sunxi] Re: [RFC] mmc: core: Set clock before switching to highspeed mode.

2015-09-07 Thread Yousong Zhou
Hi On 7 September 2015 at 15:02, Hans de Goede wrote: > Hi, > > > On 06-09-15 16:47, Yousong Zhou wrote: >> >> On Sep 6, 2015 10:14 PM, "Shawn Lin" wrote: >>> >>> >>> 在 2015/9/6 20:09, Yousong Zhou 写道: Hi, On 6 September 2015 at 08:12, Shawn Lin wrote: > >

Re: [linux-sunxi] Re: [RFC] mmc: core: Set clock before switching to highspeed mode.

2015-09-07 Thread Hans de Goede
Hi, On 06-09-15 16:47, Yousong Zhou wrote: On Sep 6, 2015 10:14 PM, "Shawn Lin" wrote: 在 2015/9/6 20:09, Yousong Zhou 写道: Hi, On 6 September 2015 at 08:12, Shawn Lin wrote: On 2015/9/5 22:58, Hans de Goede wrote: Hi Shawn Lin, On 05-09-15 16:07, Shawn Lin wrote: On 2015/9/5 18:19

Re: [linux-sunxi] Re: [RFC] mmc: core: Set clock before switching to highspeed mode.

2015-09-06 Thread Shawn Lin
On 2015/9/6 22:51, Yousong Zhou wrote: all of this is under control of the mmc core. So if Yongsong does want this card to work for any linux-based mmc stack, I guess something like that should be "better"? if (switch to HS fail) { set_bus_clk goto retry switch to HS } BUT..

Re: [linux-sunxi] Re: [RFC] mmc: core: Set clock before switching to highspeed mode.

2015-09-06 Thread Yousong Zhou
>>> all of this is under control of the mmc core. >>> So if Yongsong does want this card to work for any linux-based mmc stack, >>> I >>> guess something like that should be "better"? >>> >>> if (switch to HS fail) { >>> set_bus_clk >>> goto retry switch to HS >>> } >>> >>> BUT...

Re: [linux-sunxi] Re: [RFC] mmc: core: Set clock before switching to highspeed mode.

2015-09-06 Thread Shawn Lin
在 2015/9/6 20:09, Yousong Zhou 写道: Hi, On 6 September 2015 at 08:12, Shawn Lin wrote: On 2015/9/5 22:58, Hans de Goede wrote: Hi Shawn Lin, On 05-09-15 16:07, Shawn Lin wrote: On 2015/9/5 18:19, Yousong Zhou wrote: A SD card with sunxi-mmc can fail with the following error message (RCD

Re: [linux-sunxi] Re: [RFC] mmc: core: Set clock before switching to highspeed mode.

2015-09-06 Thread Yousong Zhou
Hi, On 6 September 2015 at 08:12, Shawn Lin wrote: > On 2015/9/5 22:58, Hans de Goede wrote: >> >> Hi Shawn Lin, >> >> On 05-09-15 16:07, Shawn Lin wrote: >>> >>> On 2015/9/5 18:19, Yousong Zhou wrote: A SD card with sunxi-mmc can fail with the following error message (RCD for

Re: [linux-sunxi] Re: [RFC] mmc: core: Set clock before switching to highspeed mode.

2015-09-05 Thread Shawn Lin
On 2015/9/5 22:58, Hans de Goede wrote: Hi Shawn Lin, On 05-09-15 16:07, Shawn Lin wrote: On 2015/9/5 18:19, Yousong Zhou wrote: A SD card with sunxi-mmc can fail with the following error message (RCD for response CRC error) when trying to switch to highspeed mode. Setting the bus clock befor

Re: [linux-sunxi] Re: [RFC] mmc: core: Set clock before switching to highspeed mode.

2015-09-05 Thread Hans de Goede
Hi Shawn Lin, On 05-09-15 16:07, Shawn Lin wrote: On 2015/9/5 18:19, Yousong Zhou wrote: A SD card with sunxi-mmc can fail with the following error message (RCD for response CRC error) when trying to switch to highspeed mode. Setting the bus clock before the access mode switch fixed it. No,