Re: [patchv3 2/4] MMC: SDHCI R1B command handling + MMC_CAP_ERASE.

2011-08-10 Thread Chris Ball
Hi Andrei, On Mon, Apr 11 2011, Andrei Warkentin wrote: > ERASE command needs R1B response, so fix R1B-type command > handling for SDHCI controller. For non-DAT commands using a busy > reponse, the cmd->cmd_timeout_ms (in ms) field is used for timeout > calculations. > > Based on patch by Chuanxia

Re: [patchv3 2/4] MMC: SDHCI R1B command handling + MMC_CAP_ERASE.

2011-04-15 Thread Cyril Hrubis
Hi! > > Yes, if all the consumers of mmc_command memset the structure to 0, there > > will be no problem. But just reviewed the code, and found mmc_app_cmd() (in > > sd_ops.c) didn't memset the command structure. So I think if we can make > > sure all the command structures will be initialized befo

Re: [patchv3 2/4] MMC: SDHCI R1B command handling + MMC_CAP_ERASE.

2011-04-12 Thread Andrei Warkentin
On Tue, Apr 12, 2011 at 8:59 PM, Dong, Chuanxiao wrote: > Yes, if all the consumers of mmc_command memset the structure to 0, there > will be no problem. But just reviewed the code, and found mmc_app_cmd() (in > sd_ops.c) didn't memset the command structure. So I think if we can make sure > al

RE: [patchv3 2/4] MMC: SDHCI R1B command handling + MMC_CAP_ERASE.

2011-04-12 Thread Dong, Chuanxiao
> -Original Message- > From: Andrei Warkentin [mailto:andr...@motorola.com] > Sent: Wednesday, April 13, 2011 2:05 AM > To: Dong, Chuanxiao > Cc: linux-mmc@vger.kernel.org; a...@arndb.de; c...@laptop.org > Subject: Re: [patchv3 2/4] MMC: SDHCI R1B command handling

Re: [patchv3 2/4] MMC: SDHCI R1B command handling + MMC_CAP_ERASE.

2011-04-12 Thread Andrei Warkentin
: linux-mmc@vger.kernel.org >> Cc: a...@arndb.de; c...@laptop.org; Andrei Warkentin >> Subject: [patchv3 2/4] MMC: SDHCI R1B command handling + MMC_CAP_ERASE. >> >> ERASE command needs R1B response, so fix R1B-type command >> handling for SDHCI controller. For non-DAT commands

RE: [patchv3 2/4] MMC: SDHCI R1B command handling + MMC_CAP_ERASE.

2011-04-12 Thread Dong, Chuanxiao
Subject: [patchv3 2/4] MMC: SDHCI R1B command handling + MMC_CAP_ERASE. > > ERASE command needs R1B response, so fix R1B-type command > handling for SDHCI controller. For non-DAT commands using a busy > reponse, the cmd->cmd_timeout_ms (in ms) field is used for timeout > calculations

[patchv3 2/4] MMC: SDHCI R1B command handling + MMC_CAP_ERASE.

2011-04-11 Thread Andrei Warkentin
ERASE command needs R1B response, so fix R1B-type command handling for SDHCI controller. For non-DAT commands using a busy reponse, the cmd->cmd_timeout_ms (in ms) field is used for timeout calculations. Based on patch by Chuanxiao Dong Signed-off-by: Andrei Warkentin --- drivers/mmc/host/sdhci