Re: Possible bug in sdio.c?

2011-05-29 Thread Chris Ball
Hi, On Sun, May 29 2011, Prashanth Bhat wrote: > Could you please clarify the formal process for including these > changes into the build? I have made the previous changes in my private > code tree only so far. See Documentation/SubmittingPatches, and send the patch you generate to the same list

Re: Possible bug in sdio.c?

2011-05-29 Thread Prashanth Bhat
On Sunday 29 May 2011 07:42 PM, Michał Mirosław wrote: On Sun, May 29, 2011 at 07:26:00AM +0530, Prashanth Bhat wrote: Hi Michał, In mmc/core/sdio.c, routine mmc_enable_4bit_bus(): I think: if (card->type == MMC_TYPE_SDIO) return sdio_enable_wide(card); should really b

Re: Possible bug in sdio.c?

2011-05-29 Thread Michał Mirosław
On Sun, May 29, 2011 at 07:26:00AM +0530, Prashanth Bhat wrote: > Hi Michał, > In mmc/core/sdio.c, routine mmc_enable_4bit_bus(): > > I think: > > if (card->type == MMC_TYPE_SDIO) > return sdio_enable_wide(card); > > should really be: > > if (card->type == MMC_TYPE_SDIO ||

Possible bug in sdio.c?

2011-05-28 Thread Prashanth Bhat
Hi Michał, In mmc/core/sdio.c, routine mmc_enable_4bit_bus(): I think: if (card->type == MMC_TYPE_SDIO) return sdio_enable_wide(card); should really be: if (card->type == MMC_TYPE_SDIO || card->type == MMC_TYPE_SD_COMBO ) return sdio_enable_wide(card); Ot