Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-10-08 Thread Ulf Hansson
On 5 October 2012 18:50, Chris Ball wrote: > Hi Ulf, > > On Thu, Sep 13 2012, Ulf Hansson wrote: >> From: Ulf Hansson >> >> This patch fixup the broken suspend sequence for eMMC >> with sleep support. Additionally it reworks the eMMC4.5 >> Power Off Notification feature so it fits together with >

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-10-05 Thread Chris Ball
Hi Ulf, On Thu, Sep 13 2012, Ulf Hansson wrote: > From: Ulf Hansson > > This patch fixup the broken suspend sequence for eMMC > with sleep support. Additionally it reworks the eMMC4.5 > Power Off Notification feature so it fits together with > the existing sleep feature. > > The CMD0 based re-ini

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-10-04 Thread Girish K S
On 4 October 2012 20:46, Ulf Hansson wrote: > Hi Chris, > > On 3 October 2012 23:03, Chris Ball wrote: >> Hi Ulf, >> >> On Thu, Sep 13 2012, Ulf Hansson wrote: >>> From: Ulf Hansson >>> >>> This patch fixup the broken suspend sequence for eMMC >>> with sleep support. Additionally it reworks the

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-10-04 Thread Ulf Hansson
Hi Chris, On 3 October 2012 23:03, Chris Ball wrote: > Hi Ulf, > > On Thu, Sep 13 2012, Ulf Hansson wrote: >> From: Ulf Hansson >> >> This patch fixup the broken suspend sequence for eMMC >> with sleep support. Additionally it reworks the eMMC4.5 >> Power Off Notification feature so it fits toge

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-10-03 Thread Chris Ball
Hi Ulf, On Thu, Sep 13 2012, Ulf Hansson wrote: > From: Ulf Hansson > > This patch fixup the broken suspend sequence for eMMC > with sleep support. Additionally it reworks the eMMC4.5 > Power Off Notification feature so it fits together with > the existing sleep feature. > > The CMD0 based re-ini

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-30 Thread Girish K S
On 30 September 2012 16:07, Girish K S wrote: > On 30 September 2012 15:48, Tanya Brokhman wrote: >> Hi Ulf, >> >>> >>> Hi Tanya, >>> >>> Thanks a lot for helping out!!! >> >> NP. >>> >>> Testing suspend to ram, and then resuming back again is the key use case >> to >>> test. >> >> >> Is there a

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-30 Thread Girish K S
On 30 September 2012 15:48, Tanya Brokhman wrote: > Hi Ulf, > >> >> Hi Tanya, >> >> Thanks a lot for helping out!!! > > NP. >> >> Testing suspend to ram, and then resuming back again is the key use case > to >> test. > > > Is there a special scenario to trigger suspend or just leaving the system >

RE: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-29 Thread Tanya Brokhman
Hi Ulf, > > Hi Tanya, > > Thanks a lot for helping out!!! NP. > > Testing suspend to ram, and then resuming back again is the key use case to > test. Is there a special scenario to trigger suspend or just leaving the system idle? I did that. Added prints in the code to verify that the PON w

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-27 Thread Ulf Hansson
al Message- >> From: Ulf Hansson [mailto:ulf.hans...@linaro.org] >> Sent: Thursday, September 20, 2012 6:40 PM >> To: Tanya Brokhman >> Cc: Arnd Bergmann; Linus Walleij; Girish K S; linux-mmc@vger.kernel.org; >> Chris Ball; Per Forlin; Johan Rudholm; Lee Jones;

RE: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-27 Thread Tanya Brokhman
t; Subject: Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off > notify > > Hi Tanya, > > On 20 September 2012 09:58, Tanya Brokhman > wrote: > >> > > >> > Let's page Arnd, I was under the impression that he has a eMMC 4.5 > >> &g

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-26 Thread Linus Walleij
On Tue, Sep 25, 2012 at 11:19 AM, Ulf Hansson wrote: > I am not sure how long we should wait for eMMC 4.5 to be tested. Until > testing is resolved the eMMC 4.3 and onwards are having a broken > suspend sequence using SLEEP, which I think is really bad. To me this sounds like a case for even add

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-25 Thread Ulf Hansson
On 20 September 2012 03:35, Chris Ball wrote: > Hi, > > On Wed, Sep 19 2012, Ulf Hansson wrote: >> Just pinging you to see if you have an opinion in merging this without >> full testing on eMMC4.5 device? >> >> I am kind of eager to fixup the broken suspend for eMMC with sleep, >> which this does.

RE: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-20 Thread Tanya Brokhman
Hi Ulf > > Nope, this is the only one needed. > Thanks a lot for helping out! > Np. I understand this is a bit urgent. Will do my best to speed it up... Thanks, Tanya Brokhman --- QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Lin

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-20 Thread Ulf Hansson
Hi Tanya, On 20 September 2012 09:58, Tanya Brokhman wrote: >> > >> > Let's page Arnd, I was under the impression that he has a eMMC 4.5 >> > board so maybe he can test it? >> >> I have a few eMMC samples but am only using them with my (slow) thinkpad >> SD card reader. I also don't know which eM

RE: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-20 Thread Tanya Brokhman
> > > > Let's page Arnd, I was under the impression that he has a eMMC 4.5 > > board so maybe he can test it? > > I have a few eMMC samples but am only using them with my (slow) thinkpad > SD card reader. I also don't know which eMMC-4.5 features they implement, > as some may be early prototypes.

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-19 Thread Chris Ball
Hi, On Wed, Sep 19 2012, Ulf Hansson wrote: > Just pinging you to see if you have an opinion in merging this without > full testing on eMMC4.5 device? > > I am kind of eager to fixup the broken suspend for eMMC with sleep, > which this does. :-) Well, we don't need "full testing", but I don't thi

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-19 Thread Ulf Hansson
Hi Chris, Just pinging you to see if you have an opinion in merging this without full testing on eMMC4.5 device? I am kind of eager to fixup the broken suspend for eMMC with sleep, which this does. :-) Kind regards Ulf Hansson On 17 September 2012 06:50, Girish K S wrote: > On 14 September 201

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-16 Thread Girish K S
On 14 September 2012 20:34, Arnd Bergmann wrote: > On Friday 14 September 2012, Linus Walleij wrote: >> On Fri, Sep 14, 2012 at 10:25 AM, Girish K S >> wrote: >> > On 14 September 2012 12:37, Ulf Hansson wrote: >> >> Hi Girish, >> >> >> >> I should also have stated that this patch has not been t

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-14 Thread Arnd Bergmann
On Friday 14 September 2012, Linus Walleij wrote: > On Fri, Sep 14, 2012 at 10:25 AM, Girish K S > wrote: > > On 14 September 2012 12:37, Ulf Hansson wrote: > >> Hi Girish, > >> > >> I should also have stated that this patch has not been tested with an > >> eMMC 4.5 device, thus the power off not

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-14 Thread Linus Walleij
On Fri, Sep 14, 2012 at 10:25 AM, Girish K S wrote: > On 14 September 2012 12:37, Ulf Hansson wrote: >> Hi Girish, >> >> I should also have stated that this patch has not been tested with an >> eMMC 4.5 device, thus the power off notification is not fully tested. >> Unfortunate I don't have such

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-14 Thread Girish K S
On 14 September 2012 14:49, Ulf Hansson wrote: > On 14 September 2012 10:25, Girish K S > wrote: >> On 14 September 2012 12:37, Ulf Hansson wrote: >>> Hi Girish, >>> >>> I should also have stated that this patch has not been tested with an >>> eMMC 4.5 device, thus the power off notification is

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-14 Thread Ulf Hansson
On 14 September 2012 10:25, Girish K S wrote: > On 14 September 2012 12:37, Ulf Hansson wrote: >> Hi Girish, >> >> I should also have stated that this patch has not been tested with an >> eMMC 4.5 device, thus the power off notification is not fully tested. >> Unfortunate I don't have such a devi

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-14 Thread Girish K S
On 14 September 2012 12:37, Ulf Hansson wrote: > Hi Girish, > > I should also have stated that this patch has not been tested with an > eMMC 4.5 device, thus the power off notification is not fully tested. > Unfortunate I don't have such a device available right now. What I did > test was that pat

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-14 Thread Ulf Hansson
Hi Girish, I should also have stated that this patch has not been tested with an eMMC 4.5 device, thus the power off notification is not fully tested. Unfortunate I don't have such a device available right now. What I did test was that patch must not break anything and tested that the suspend/resu

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-13 Thread Girish K S
On 14 September 2012 10:38, Girish K S wrote: > HI Ulf, > You had Acked the rework patch mailed by Saugata. But this patch > doesnt look same like the one sent by saugata. Sorry Ulf I saw your and Saugata mail after replying to this. Pls ignore this > > On 13 September 2012 14:50, Ulf Hansson wro

Re: [PATCH] mmc: Fixup broken suspend and eMMC4.5 power off notify

2012-09-13 Thread Girish K S
HI Ulf, You had Acked the rework patch mailed by Saugata. But this patch doesnt look same like the one sent by saugata. On 13 September 2012 14:50, Ulf Hansson wrote: > From: Ulf Hansson > > This patch fixup the broken suspend sequence for eMMC > with sleep support. Additionally it reworks the e