Re: [PATCH] mmc: sdhci-s3c: add quirk about BROKEN_ADMA_ZEROLEN_DESC

2011-07-28 Thread Chris Ball
Hi Jaehoon, On Tue, Jul 12 2011, Jaehoon Chung wrote: > This patch is added the quirk for Samsung SoCs. > > Samsung SoCs need to set QUIRK_BROKEN_ADMA_ZEROLEN_DESC. > (If ADMA operation is more than 65535, maybe set by zero.) > > Signed-off-by: Jaehoon Chung > Signed-off-by: Kyungmin Park > ---

Re: [PATCH] mmc: sdhci-s3c: add quirk about BROKEN_ADMA_ZEROLEN_DESC

2011-07-12 Thread Philip Rakity
One use for this is as follows: Without the QUIRK imagine there is one SG descriptor passed in and it is properly aligned etc. The prepare_data function (and friends) will change this to 2 ADMA descriptors. The first descriptor will point to the data / length passed in via the SG descriptor

RE: [PATCH] mmc: sdhci-s3c: add quirk about BROKEN_ADMA_ZEROLEN_DESC

2011-07-12 Thread Seungwon Jeon
Hi, I don't know meaning of QUIRK_BROKEN_ADMA_ZEROLEN_DESC exactly. Is there any problem in ADMA descriptors? Could you explain for this? The following table is for ADMA length field from Host controller spec. The maximum data length descriptor line is less than 64KiB. Samsung also conforms this.