Re: [PATCH] mmc: sh_mmcif: mmc->f_max heuristic

2012-06-21 Thread Simon Horman
On Thu, Jun 21, 2012 at 07:11:42AM -0700, Brandt, Chris wrote: > > At least for the sh7757 and sh7372. > Also for the sh7724 (ie, only the sh7757 can run at full bus speed by setting > CLKDIV=0xF which no other part canyet) Thanks. > But, with this new patch applied: > > > if (!ret) { >

RE: [PATCH] mmc: sh_mmcif: mmc->f_max heuristic

2012-06-21 Thread Brandt, Chris
- From: Simon Horman [mailto:ho...@verge.net.au] Sent: Wednesday, June 20, 2012 8:48 PM To: Brandt, Chris Cc: Guennadi Liakhovetski; linux-mmc@vger.kernel.org; linux...@vger.kernel.org; Chris Ball; Magnus Damm Subject: Re: [PATCH] mmc: sh_mmcif: mmc->f_max heuristic On Wed, Jun 20, 2012 at 07:56:44AM

Re: [PATCH] mmc: sh_mmcif: mmc->f_max heuristic

2012-06-20 Thread Simon Horman
On Wed, Jun 20, 2012 at 07:56:44AM -0700, Brandt, Chris wrote: > > I would be very happy if someone with access to > > the documentation could shed some further light on this. > > According to the SH7757 manual, setting the CLKDIV[3:0] in the CE_CLK_CTRL > register 0xF selects Pck as the bus cloc

RE: [PATCH] mmc: sh_mmcif: mmc->f_max heuristic

2012-06-20 Thread Brandt, Chris
el.org; linux...@vger.kernel.org; Chris Ball; Magnus Damm Subject: Re: [PATCH] mmc: sh_mmcif: mmc->f_max heuristic On Wed, Jun 20, 2012 at 08:49:38AM +0200, Guennadi Liakhovetski wrote: > Hi Simon > > Thanks for addressing this issue. > > On Wed, 20 Jun 2012, Simon

Re: [PATCH] mmc: sh_mmcif: mmc->f_max heuristic

2012-06-20 Thread Simon Horman
On Wed, Jun 20, 2012 at 08:49:38AM +0200, Guennadi Liakhovetski wrote: > Hi Simon > > Thanks for addressing this issue. > > On Wed, 20 Jun 2012, Simon Horman wrote: > > > In 930f152cc9998388031af577843baae572ac8ab6 ("mmc: sh_mmcif: mmc->f_max > > should be half of the bus clock") I changed the s

Re: [PATCH] mmc: sh_mmcif: mmc->f_max heuristic

2012-06-19 Thread Guennadi Liakhovetski
Hi Simon Thanks for addressing this issue. On Wed, 20 Jun 2012, Simon Horman wrote: > In 930f152cc9998388031af577843baae572ac8ab6 ("mmc: sh_mmcif: mmc->f_max > should be half of the bus clock") I changed the setting of mmc->f_max from > the bus clock to half the bus clock based on the manual for