RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

[snip] > > > > Now I really started liking this patch. > > Acked-by: Linus Walleij > > Which shall be interpreted as for the patch with the above code, not > the one which is subject for this post I believe. > > Pierre, I can't locate your patches for some reason, care to repost > them? https://

Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

2011/1/26 Linus Walleij : > 2011/1/25 Tardy, Pierre : >> @@ -1231,6 +1233,27 @@ static void sdhci_set_ios(struct mmc_host *mmc, >> struct mmc_ios *ios) >>                goto out; >> >>        /* >> +        * get/put runtime_pm usage counter at ios->clock transitions >> +        * We need to do

Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

2011/1/25 Tardy, Pierre : > Actually in sdhci, you power off the MMC IP block, you power OFF the > MCLK (at least on our platform) > > I don't know other platform where mmc clock is not controlled more or > less directlty by the sdhc IP. This is the case with host/mmci.c. It is taking a clock in

RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

> -Original Message- > From: Linus Walleij [mailto:linus.ml.wall...@gmail.com] > Sent: Monday, January 24, 2011 11:11 PM > To: Chris Ball > Cc: Tardy, Pierre; linux-mmc@vger.kernel.org; Ohad Ben-Cohen; linux-omap > Mailing List > Subject: Re: [PATCH v1 1/3]mmc: imple

Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

2011/1/20 Chris Ball : > On Wed, Jan 19, 2011 at 09:45:57AM +, Tardy, Pierre wrote: >> Chris, >> (Sorry for top posting) >> Seems we have a intel intern disagreement. >> >> Could we have maintainer opinion on this ? > > Linus W and Ohad, any input here?  Thanks, What I see is orthogonal purpos

Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

On Sun, 23 Jan 2011, Ohad Ben-Cohen wrote: > On Sun, Jan 23, 2011 at 7:20 AM, Nicolas Pitre wrote: > > First case:  you want to stop the clock _to_ the _card_ when not talking > > to it.  That has nothing to do with power saving performed within the > > host controller.  This is for reducing powe

RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

On Sun, 23 Jan 2011, Tardy, Pierre wrote: > > > > First case: you want to stop the clock _to_ the _card_ when not talking > > to it. That has nothing to do with power saving performed within the > > host controller. This is for reducing power consumption by the _card_ > > (and possibly by the

RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

> -Original Message- > From: Ohad Ben-Cohen [mailto:o...@wizery.com] > Sent: Monday, January 24, 2011 4:40 AM > To: Nicolas Pitre > Cc: Chris Ball; Dong, Chuanxiao; Tardy, Pierre; linux-mmc@vger.kernel.org; > Linus > Walleij; Gao, Yunpeng > Subject: Re: [PATCH

Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

On Sun, Jan 23, 2011 at 7:20 AM, Nicolas Pitre wrote: > First case:  you want to stop the clock _to_ the _card_ when not talking > to it.  That has nothing to do with power saving performed within the > host controller.  This is for reducing power consumption by the _card_ > (and possibly by the c

RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

> > First case: you want to stop the clock _to_ the _card_ when not talking > to it. That has nothing to do with power saving performed within the > host controller. This is for reducing power consumption by the _card_ > (and possibly by the clock generator). The runtime PM stuff has no > busi

Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

On Sat, 22 Jan 2011, Ohad Ben-Cohen wrote: > On Thu, Jan 20, 2011 at 7:08 AM, Chris Ball wrote: > > On Wed, Jan 19, 2011 at 09:45:57AM +, Tardy, Pierre wrote: > >> Chris, > >> (Sorry for top posting) > >> Seems we have a intel intern disagreement. > >> > >> Could we have maintainer opinion on

Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

On Thu, Jan 20, 2011 at 7:08 AM, Chris Ball wrote: > On Wed, Jan 19, 2011 at 09:45:57AM +, Tardy, Pierre wrote: >> Chris, >> (Sorry for top posting) >> Seems we have a intel intern disagreement. >> >> Could we have maintainer opinion on this ? > > Linus W and Ohad, any input here?  Thanks, Pe

Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

On Wed, Jan 19, 2011 at 09:45:57AM +, Tardy, Pierre wrote: > Chris, > (Sorry for top posting) > Seems we have a intel intern disagreement. > > Could we have maintainer opinion on this ? Linus W and Ohad, any input here? Thanks, -- Chris Ball One Laptop Per Child -

RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

; Cc: linux-ker...@vger.kernel.org; c...@laptop.org; o...@wizery.com > Subject: RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host > > Hi Pierre, > I think the runtime pm should not have any dependency with clock gating. Even > the MMC driver won't > clock gate SD/

RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

ry.com > Subject: RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host > > > > I'm also worried about this patch not taking in account the 8 clock > > > cycles before > > > shutting down the clock, contrary to the clock gating fw. > > > If yo

RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

> > I'm also worried about this patch not taking in account the 8 clock cycles > > before > > shutting down the clock, contrary to the clock gating fw. > > If you power down hc, you will also gate the clock. So the sdio protocol > > might not be > > strictly followed. > As mmc spec said, 8 clock

RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

> -Original Message- > From: Tardy, Pierre > Sent: Monday, January 17, 2011 6:59 PM > To: Dong, Chuanxiao; linux-mmc@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; c...@laptop.org; o...@wizery.com > Subject: RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

> MMC host has a sysfs interface to let user specify the auto suspended delay. > Each slot of the host controller can have a different delay for runtime > suspended. > out: > + /* power off host controller */ > + pm_runtime_put(&host->class_dev); If you want to use autosuspend feature,