Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-11-08 Thread Chris Ball
Hi Aaron, On Mon, Nov 05 2012, Chris Ball wrote: > On Tue, Jul 03 2012, Aaron Lu wrote: >> */ >> if ((host->flags & SDHCI_NEEDS_RETUNING) && >> !(present_state & (SDHCI_DOING_WRITE | SDHCI_DOING_READ))) { >> +/* eMMC uses cmd21 while

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-11-05 Thread Chris Ball
Hi Aaron, On Tue, Jul 03 2012, Aaron Lu wrote: >*/ > if ((host->flags & SDHCI_NEEDS_RETUNING) && > !(present_state & (SDHCI_DOING_WRITE | SDHCI_DOING_READ))) { > + /* eMMC uses cmd21 while sd and sdio use cmd19 */ > +

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Aaron Lu
Hi Chris, On Tue, Jul 03, 2012 at 08:37:33PM -0400, Chris Ball wrote: > Hi, > > On Tue, Jul 03 2012, Aaron Lu wrote: > > V2: > > Fix for SDIO case: both SD and SDIO cards use cmd19 while eMMC use cmd21. > > > > V1: > > For SD hosts using retuning mode 1, when retuning timer expired, it will > > n

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Chris Ball
Hi, On Tue, Jul 03 2012, Aaron Lu wrote: > V2: > Fix for SDIO case: both SD and SDIO cards use cmd19 while eMMC use cmd21. > > V1: > For SD hosts using retuning mode 1, when retuning timer expired, it will > need to do retuning in sdhci_request before processing the actual > request. But the retun

RE: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Philip Rakity
Reviewed-by philip Rakity prak...@marvell.com From: Aaron Lu [aaron...@amd.com] Sent: Tuesday, July 03, 2012 2:27 AM To: Girish K S; Subhash Jadavani; Philip Rakity; Chris Ball Cc: linux-mmc@vger.kernel.org; Aaron Lu; Aaron Lu; stable; "[3.3+]"@domain.inval

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Aaron Lu
Hi, On Tue, Jul 03, 2012 at 05:32:36PM +0530, Girish K S wrote: > >>> > @@ -1292,8 +1294,12 @@ static void sdhci_request(struct mmc_host *mmc, > >>> > struct mmc_request *mrq) > >>> >                  */ > >>> >                 if ((host->flags & SDHCI_NEEDS_RETUNING) && > >>> >                  

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Girish K S
On 3 July 2012 17:27, Girish K S wrote: > On 3 July 2012 17:01, Aaron Lu wrote: >> Hi, >> >> On Tue, Jul 03, 2012 at 03:28:28PM +0530, Girish K S wrote: >>> On 3 July 2012 14:57, Aaron Lu wrote: >>> > V2: >>> > Fix for SDIO case: both SD and SDIO cards use cmd19 while eMMC use cmd21. >>> > >>> >

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Girish K S
On 3 July 2012 17:27, Girish K S wrote: > On 3 July 2012 17:01, Aaron Lu wrote: >> Hi, >> >> On Tue, Jul 03, 2012 at 03:28:28PM +0530, Girish K S wrote: >>> On 3 July 2012 14:57, Aaron Lu wrote: >>> > V2: >>> > Fix for SDIO case: both SD and SDIO cards use cmd19 while eMMC use cmd21. >>> > >>> >

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Girish K S
On 3 July 2012 17:01, Aaron Lu wrote: > Hi, > > On Tue, Jul 03, 2012 at 03:28:28PM +0530, Girish K S wrote: >> On 3 July 2012 14:57, Aaron Lu wrote: >> > V2: >> > Fix for SDIO case: both SD and SDIO cards use cmd19 while eMMC use cmd21. >> > >> > V1: >> > For SD hosts using retuning mode 1, when

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Aaron Lu
Hi, On Tue, Jul 03, 2012 at 03:28:28PM +0530, Girish K S wrote: > On 3 July 2012 14:57, Aaron Lu wrote: > > V2: > > Fix for SDIO case: both SD and SDIO cards use cmd19 while eMMC use cmd21. > > > > V1: > > For SD hosts using retuning mode 1, when retuning timer expired, it will > > need to do ret

Re: [PATCH v2] mmc: sdhci: fix incorrect command used in tuning

2012-07-03 Thread Girish K S
On 3 July 2012 14:57, Aaron Lu wrote: > V2: > Fix for SDIO case: both SD and SDIO cards use cmd19 while eMMC use cmd21. > > V1: > For SD hosts using retuning mode 1, when retuning timer expired, it will > need to do retuning in sdhci_request before processing the actual > request. But the retuning