RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-24 Thread Nath, Arindam
nath@gmail.com > Subject: Re: [PATCH v2 02/12] mmc: sd: add support for signal voltage > switch procedure > > On Fri, Mar 4, 2011 at 6:32 AM, Arindam Nath > wrote: > > Host Controller v3.00 adds another Capabilities register. Apart > > from other things, this new regis

Re: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-24 Thread zhangfei gao
On Fri, Mar 4, 2011 at 6:32 AM, Arindam Nath wrote: > Host Controller v3.00 adds another Capabilities register. Apart > from other things, this new register indicates whether the Host > Controller supports SDR50, SDR104, and DDR50 UHS-I modes. The spec > doesn't mention about explicit support for

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-16 Thread Nath, Arindam
nath@gmail.com > Subject: Re: [PATCH v2 02/12] mmc: sd: add support for signal voltage > switch procedure > > > Hi Arindam, > > was getting kernel crash on SD card -- fix is below > > Philip > > On Mar 4, 2011, at 3:32 AM, Arindam Nath wrote: > > > Hos

Re: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-16 Thread Philip Rakity
Hi Arindam, was getting kernel crash on SD card -- fix is below Philip On Mar 4, 2011, at 3:32 AM, Arindam Nath wrote: > Host Controller v3.00 adds another Capabilities register. Apart > from other things, this new register indicates whether the Host > Controller supports SDR50, SDR104, and DD

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-16 Thread Nath, Arindam
nath@gmail.com > Subject: Re: [PATCH v2 02/12] mmc: sd: add support for signal voltage > switch procedure > > On Wed, Mar 16, 2011 at 2:30 AM, Nath, Arindam > wrote: > > Hi Zhangfei, > > > > > >> -Original Message- > >> From: zhangfei gao [

Re: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-16 Thread zhangfei gao
top.org; prak...@marvell.com; linux-mmc@vger.kernel.org; Su, >> Henry; Lu, Aaron; anath....@gmail.com >> Subject: Re: [PATCH v2 02/12] mmc: sd: add support for signal voltage >> switch procedure >> >> On Tue, Mar 15, 2011 at 7:58 AM, Subhash Jadavani >>

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-15 Thread Nath, Arindam
nath@gmail.com > Subject: Re: [PATCH v2 02/12] mmc: sd: add support for signal voltage > switch procedure > > On Tue, Mar 15, 2011 at 7:58 AM, Subhash Jadavani > wrote: > > > > > >> -Original Message- > >> From: Nath, Arindam [mailto:arindam.n

Re: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-15 Thread zhangfei gao
om; prak...@marvell.com; linux- >> m...@vger.kernel.org; Su, Henry; Lu, Aaron; anath....@gmail.com >> Subject: RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage >> switch procedure >> >> Hi Subhash, >> >> >> > -Original Message- >>

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-15 Thread Subhash Jadavani
mail.com > Subject: RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage > switch procedure > > Hi Subhash, > > > > -Original Message- > > From: Subhash Jadavani [mailto:subha...@codeaurora.org] > > Sent: Tuesday, March 15, 2011 4:49 PM &

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-15 Thread Nath, Arindam
; Lu, Aaron; anath@gmail.com > Subject: RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage > switch procedure > > > > > -Original Message- > > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > > ow...@vger.kernel.org] On Behalf Of Nath, Arind

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-15 Thread Subhash Jadavani
ll.com; linux- > m...@vger.kernel.org; Su, Henry; Lu, Aaron; anath@gmail.com > Subject: RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage > switch procedure > > Hi Subhash, > > > > -Original Message- > > From: Subhash Jadavani [mailto:subha...@codeau

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-15 Thread Nath, Arindam
; Lu, Aaron; anath@gmail.com > Subject: RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage > switch procedure > > Arindam, > > During voltage switch, voltage level for CLK, DATA and CMD pads/pins > should > be changed from 3.3v to 1.8v. for this SD controller has

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-15 Thread Subhash Jadavani
Arindam, During voltage switch, voltage level for CLK, DATA and CMD pads/pins should be changed from 3.3v to 1.8v. for this SD controller has to modify few bits in their controller registers and also have to set the voltage level of a regulator which is powering those pad/pins. Now with you curre

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-10 Thread Nath, Arindam
nath@gmail.com > Subject: Re: [PATCH v2 02/12] mmc: sd: add support for signal voltage > switch procedure > > On Fri, Mar 4, 2011 at 6:32 AM, Arindam Nath > wrote: > > Host Controller v3.00 adds another Capabilities register. Apart > > from other things,

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-10 Thread Nath, Arindam
; Lu, Aaron; anath@gmail.com > Subject: RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage > switch procedure > > > > > -Original Message- > > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > > ow...@vger.kernel.org] On Behalf Of su

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-09 Thread subhashj
k...@marvell.com; linux- > m...@vger.kernel.org; henry...@amd.com; aaron...@amd.com; > anath....@gmail.com > Subject: RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage > switch procedure > > +1. Looks good to me from sd3.0 spec. prospective. > > > -Original

Re: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-09 Thread zhangfei gao
On Fri, Mar 4, 2011 at 6:32 AM, Arindam Nath wrote: > Host Controller v3.00 adds another Capabilities register. Apart > from other things, this new register indicates whether the Host > Controller supports SDR50, SDR104, and DDR50 UHS-I modes. The spec > doesn't mention about explicit support for

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-09 Thread subhashj
+1. Looks good to me from sd3.0 spec. prospective. > -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Arindam Nath > Sent: Friday, March 04, 2011 5:03 PM > To: c...@laptop.org > Cc: zhangfei@gmail.com; prak...@marvell.

RE: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-04 Thread Nath, Arindam
Henry; Lu, > Aaron; anath@gmail.com > Subject: Re: [PATCH v2 02/12] mmc: sd: add support for signal voltage > switch procedure > > > > + if (host->version >= SDHCI_SPEC_300) > > + caps[1] = sdhci_readl(host, SDHCI_CAPABILITIES_1); > > Now cap

Re: [PATCH v2 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-04 Thread Wolfram Sang
> + if (host->version >= SDHCI_SPEC_300) > + caps[1] = sdhci_readl(host, SDHCI_CAPABILITIES_1); Now caps[1] can be uninitialized (didn't the compiler warn about this?) Maybe caps[1] = host->version... ? sdhci_readl() : 0 (or simply an else branch)? Regards, Wolfram