Re: [PATCH v3] mmc: support BKOPS feature for eMMC

2011-12-05 Thread Jae hoon Chung
Hi Konstantin. Thanks for your comment.. I will consider your opinion and send path-v4...then also let me know more comments :) Best Regards, Jaehoon Chung 2011/12/2 Konstantin Dorfman : > Hello Jaehoon, > After applying your patch and debugging it for some time, > I want to share my results and

Re: [PATCH v3] mmc: support BKOPS feature for eMMC

2011-12-01 Thread Konstantin Dorfman
Hello Jaehoon, After applying your patch and debugging it for some time, I want to share my results and suggests some changes to the patch. See comments below: > +void mmc_start_bkops(struct mmc_card *card) > +{ > + int err; > + unsigned long flags; > + > + BUG_ON(!card); > + if ((

Re: [PATCH v3] mmc: support BKOPS feature for eMMC

2011-11-29 Thread Jaehoon Chung
Hi Adrian. On 11/29/2011 09:20 PM, Adrian Hunter wrote: > On 17/11/11 02:50, Jaehoon Chung wrote: >> Enable eMMC background operations (BKOPS) feature. >> >> If URGENT_BKOPS is set after a response, note that BKOPS >> are required. After all I/O requests are finished, run >> BKOPS if required. Sh

Re: [PATCH v3] mmc: support BKOPS feature for eMMC

2011-11-29 Thread Adrian Hunter
On 17/11/11 02:50, Jaehoon Chung wrote: > Enable eMMC background operations (BKOPS) feature. > > If URGENT_BKOPS is set after a response, note that BKOPS > are required. After all I/O requests are finished, run > BKOPS if required. Should read/write operations be requested > during BKOPS, first is

Re: [PATCH v3] mmc: support BKOPS feature for eMMC

2011-11-28 Thread Konstantin Dorfman
Hi Jaehoon, > > i didn't know how poll for ack from card..did you know? > So i implemented that send the hpi command whatever status. > > If let me know checking for ack from card, i will consider that. Some of MMC controllers (in my case msm_sdcc) can process automatically "busy line" and fire i

Re: [PATCH v3] mmc: support BKOPS feature for eMMC

2011-11-22 Thread Jaehoon Chung
Hi Konstantin On 11/22/2011 09:44 PM, Konstantin Dorfman wrote: > Hello Jaehoon, > > ... >> +/** >> + * mmc_start_bkops - start BKOPS for supported cards >> + * @card: MMC card to start BKOPS >> + * >> + * Start background operations whenever requested. >> + * when the urgent BKOPS bit is se

Re: [PATCH v3] mmc: support BKOPS feature for eMMC

2011-11-22 Thread Konstantin Dorfman
> Hello Jaehoon, > > ... >> +/** >> + * mmc_start_bkops - start BKOPS for supported cards >> + * @card: MMC card to start BKOPS >> + * >> + * Start background operations whenever requested. >> + * when the urgent BKOPS bit is set in a R1 command response >> + * then background operations shoul

Re: [PATCH v3] mmc: support BKOPS feature for eMMC

2011-11-22 Thread Konstantin Dorfman
Hello Jaehoon, ... > +/** > + * mmc_start_bkops - start BKOPS for supported cards > + * @card: MMC card to start BKOPS > + * > + * Start background operations whenever requested. > + * when the urgent BKOPS bit is set in a R1 command response > + * then background operations should be st

Re: [PATCH v3] mmc: support BKOPS feature for eMMC

2011-11-20 Thread Per Forlin
Hi Konstantin, On Sun, Nov 20, 2011 at 5:12 PM, Konstantin Dorfman wrote: > Hello Per, > >> On Thu, Nov 17, 2011 at 4:01 PM, Konstantin Dorfman >> wrote: >>> Hello Jaenhoon, >>> >>> I have a few suggestions regarding the situation when Host starts BKOPS: >>> >>> 1) Host should start BKOPS (based

Re: [PATCH v3] mmc: support BKOPS feature for eMMC

2011-11-20 Thread Konstantin Dorfman
Hello Per, > On Thu, Nov 17, 2011 at 4:01 PM, Konstantin Dorfman > wrote: >> Hello Jaenhoon, >> >> I have a few suggestions regarding the situation when Host starts BKOPS: >> >> 1) Host should start BKOPS (based on BKOPS_STATUS or URGENT_BKOPS event) >> when going to mmc_sleep, which means that t

Re: [PATCH v3] mmc: support BKOPS feature for eMMC

2011-11-17 Thread Per Forlin
On Thu, Nov 17, 2011 at 4:01 PM, Konstantin Dorfman wrote: > Hello Jaenhoon, > > I have a few suggestions regarding the situation when Host starts BKOPS: > > 1) Host should start BKOPS (based on BKOPS_STATUS or URGENT_BKOPS event) > when going to mmc_sleep, which means that the bus is in idle stat

RE: [PATCH v3] mmc: support BKOPS feature for eMMC

2011-11-17 Thread Konstantin Dorfman
Hello Jaenhoon, I have a few suggestions regarding the situation when Host starts BKOPS: 1) Host should start BKOPS (based on BKOPS_STATUS or URGENT_BKOPS event) when going to mmc_sleep, which means that the bus is in idle state (this also covers the case in mmc_queue_thread, because in this case

Re: [PATCH v3] mmc: support BKOPS feature for eMMC

2011-11-17 Thread S, Venkatraman
On Thu, Nov 17, 2011 at 6:20 AM, Jaehoon Chung wrote: > Enable eMMC background operations (BKOPS) feature. > > If URGENT_BKOPS is set after a response, note that BKOPS > are required. After all I/O requests are finished, run > BKOPS if required. Should read/write operations be requested > during B