Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-15 Thread Ulf Hansson
On 06/15/2012 01:34 PM, Saugata Das wrote: On 15 June 2012 16:56, Ulf Hansson wrote: Hi Saugata, snip. The problem in sending CMD0 without power OFF notify is possibility of some data loss in MMC-4.5 devices. I don't see the problem here. You will be sending power OFF notify when you c

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-15 Thread Saugata Das
On 15 June 2012 16:56, Ulf Hansson wrote: > Hi Saugata, > > snip. > > >> >> The problem in sending CMD0 without power OFF notify is possibility of >> some data loss in MMC-4.5 devices. > > > > I don't see the problem here. You will be sending power OFF notify when >

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-15 Thread Ulf Hansson
Hi Saugata, snip. The problem in sending CMD0 without power OFF notify is possibility of some data loss in MMC-4.5 devices. I don't see the problem here. You will be sending power OFF notify when you can. The only difference is when you "wake" the device from sleep mode. Instead of using CM

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-15 Thread Saugata Das
On 15 June 2012 15:22, Per Forlin wrote: > On Fri, Jun 15, 2012 at 10:34 AM, Saugata Das wrote: >> On 15 June 2012 12:52, Ulf Hansson wrote: >>> On 06/15/2012 05:49 AM, Saugata Das wrote: On 15 June 2012 00:36, Per Forlin  wrote: > > Hi Saugata, > > I can have a go and

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-15 Thread Per Forlin
On Fri, Jun 15, 2012 at 10:34 AM, Saugata Das wrote: > On 15 June 2012 12:52, Ulf Hansson wrote: >> On 06/15/2012 05:49 AM, Saugata Das wrote: >>> >>> On 15 June 2012 00:36, Per Forlin  wrote: Hi Saugata, I can have a go and test it. But first I would like to bring up 3 c

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-15 Thread Saugata Das
On 15 June 2012 12:52, Ulf Hansson wrote: > On 06/15/2012 05:49 AM, Saugata Das wrote: >> >> On 15 June 2012 00:36, Per Forlin  wrote: >>> >>> Hi Saugata, >>> >>> I can have a go and test it. But first I would like to bring up 3 >>> concerns that I have with this patch. >>> >>> 1. This patch shoul

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-15 Thread Per Forlin
Hi Ulf, On Fri, Jun 15, 2012 at 9:22 AM, Ulf Hansson wrote: > On 06/15/2012 05:49 AM, Saugata Das wrote: >> >> On 15 June 2012 00:36, Per Forlin  wrote: >>> >>> Hi Saugata, >>> >>> I can have a go and test it. But first I would like to bring up 3 >>> concerns that I have with this patch. >>> >>>

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-15 Thread Ulf Hansson
On 06/15/2012 05:49 AM, Saugata Das wrote: On 15 June 2012 00:36, Per Forlin wrote: Hi Saugata, I can have a go and test it. But first I would like to bring up 3 concerns that I have with this patch. 1. This patch should be sent to cc-stable in order to repair the bug introduced in 3.4 I sh

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-14 Thread Saugata Das
On 15 June 2012 00:36, Per Forlin wrote: > Hi Saugata, > > I can have a go and test it. But first I would like to bring up 3 > concerns that I have with this patch. > > 1. This patch should be sent to cc-stable in order to repair the bug > introduced in 3.4 I shall sent it out today. > 2. Is the

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-14 Thread Per Forlin
Hi Saugata, I can have a go and test it. But first I would like to bring up 3 concerns that I have with this patch. 1. This patch should be sent to cc-stable in order to repair the bug introduced in 3.4 2. Is the bus_ops for poweroff_notify really necessary since only mmc use it? There are alrea

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-14 Thread Saugata Das
On 14 June 2012 20:20, Ulf Hansson wrote: > Hi Girish, > > On 14 June 2012 15:21, Girish K S wrote: >> On 14 June 2012 18:43, Per Forlin wrote: >>> Hi Girish and Suagata, >>> >>> I have run some regression tests with this patch on our board (ux500 >>> family) running suspend and resume of the eM

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-14 Thread Ulf Hansson
Hi Girish, On 14 June 2012 15:21, Girish K S wrote: > On 14 June 2012 18:43, Per Forlin wrote: >> Hi Girish and Suagata, >> >> I have run some regression tests with this patch on our board (ux500 >> family) running suspend and resume of the eMMC 4.41 device. >> >> The two patches I have looked a

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-14 Thread Girish K S
On 14 June 2012 18:43, Per Forlin wrote: > Hi Girish and Suagata, > > I have run some regression tests with this patch on our board (ux500 > family) running suspend and resume of the eMMC 4.41 device. > > The two patches I have looked at are: > 1. "mmc: core: Fix PowerOff Notify suspend/resume" (m

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-06-14 Thread Per Forlin
Hi Girish and Suagata, I have run some regression tests with this patch on our board (ux500 family) running suspend and resume of the eMMC 4.41 device. The two patches I have looked at are: 1. "mmc: core: Fix PowerOff Notify suspend/resume" (merged) 2. " MMC-4.5 Power OFF Notify Rework" With onl

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-05-28 Thread Girish K S
On 28 May 2012 16:33, Subhash Jadavani wrote: > Hi Girish, Saugata, > > There is an issue with this patch during resume. Please find comments inline > below: This is a patch for poweroff_notification. If CAP2 is enabled with CAP2_POWEROFF_NOTIFY, you never enter the sleep path. > >> -Original

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-05-28 Thread Saugata Das
On 28 May 2012 16:33, Subhash Jadavani wrote: > Hi Girish, Saugata, > > There is an issue with this patch during resume. Please find comments inline > below: > >> -Original Message- >> From: Girish K S [mailto:girish.shivananja...@linaro.org] >> Sent: Tuesday, May 22, 2012 5:15 PM >> To: l

RE: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-05-28 Thread Subhash Jadavani
Hi Girish, Saugata, There is an issue with this patch during resume. Please find comments inline below: > -Original Message- > From: Girish K S [mailto:girish.shivananja...@linaro.org] > Sent: Tuesday, May 22, 2012 5:15 PM > To: linux-mmc@vger.kernel.org > Cc: c...@laptop.org; patc...@lin

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-05-23 Thread Ulf Hansson
Hi Girish and Saugata, This patch looks great to me! Acked-by: Ulf Hansson Kind regards Ulf Hansson On 05/22/2012 01:45 PM, Girish K S wrote: From: Saugata Das This is a rework of the existing POWER OFF NOTIFY patch. The current problem with the patch comes from the ambiguity on the usage o

Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

2012-05-23 Thread Subhash Jadavani
Looks good to me. Reviewed-by: Subhash Jadavani On 5/22/2012 5:15 PM, Girish K S wrote: From: Saugata Das This is a rework of the existing POWER OFF NOTIFY patch. The current problem with the patch comes from the ambiguity on the usage of POWER OFF NOTIFY together with SLEEP and misunderstand