RE: [RFC PATCH 1/1 ]mmc: Support-FFU-for-eMMC-v5.0

2014-04-03 Thread Alex Lemberg
.com > Subject: Re: [RFC PATCH 1/1 ]mmc: Support-FFU-for-eMMC-v5.0 > > Some of Samsung eMMC does not show the argument for ffu in ext_csd. > In case of this, eMMC shows 0x0 from ext_csd, Host has to modify the > argument. > > Add "#define CID_MANFID_SAMSUNG

RE: [RFC PATCH 1/1 ]mmc: Support-FFU-for-eMMC-v5.0

2014-04-03 Thread Alex Lemberg
r > Cc: Jaehoon Chung; Seunguk Shin; linux-mmc@vger.kernel.org; Avi > Shchislowski; Chris Ball; CPGS; Puthikorn Voravootivat; Gwendal Grignou > Subject: Re: [RFC PATCH 1/1 ]mmc: Support-FFU-for-eMMC-v5.0 > > argh...reposting my response as text only since linux-mmc doesn't like

RE: [RFC PATCH 1/1 ]mmc: Support-FFU-for-eMMC-v5.0

2014-04-01 Thread Seunguk Shin
Dear. Jaehoon I mentioned 3 items. One is for only Samsung emmc (argument for ffu) The others are for general emmc I'll make a separated patch for first item. But, the others should be applied to this patch. Thank you. Best Regards, Seunguk Shin > > Dear, Grant. > > On 04/02/2014 05:30 AM, Gr

Re: [RFC PATCH 1/1 ]mmc: Support-FFU-for-eMMC-v5.0

2014-04-01 Thread Jaehoon Chung
Dear, Grant. On 04/02/2014 05:30 AM, Grant Grundler wrote: > argh...reposting my response as text only since linux-mmc doesn't like > html mail. :( > > On Tue, Apr 1, 2014 at 1:26 PM, Grant Grundler wrote: >> >> >> >> On Mon, Mar 31, 2014 at 9:17 PM, Jaehoon Chung >> wrote: >>> >>> Hi, Seunguk.

Re: [RFC PATCH 1/1 ]mmc: Support-FFU-for-eMMC-v5.0

2014-04-01 Thread Grant Grundler
argh...reposting my response as text only since linux-mmc doesn't like html mail. :( On Tue, Apr 1, 2014 at 1:26 PM, Grant Grundler wrote: > > > > On Mon, Mar 31, 2014 at 9:17 PM, Jaehoon Chung > wrote: >> >> Hi, Seunguk. >> >> On 03/31/2014 07:51 PM, Seunguk Shin wrote: >> > Some of Samsung eMM

Re: [RFC PATCH 1/1 ]mmc: Support-FFU-for-eMMC-v5.0

2014-03-31 Thread Jaehoon Chung
Hi, Seunguk. On 03/31/2014 07:51 PM, Seunguk Shin wrote: > Some of Samsung eMMC does not show the argument for ffu in ext_csd. > In case of this, eMMC shows 0x0 from ext_csd, Host has to modify the > argument. > > Add "#define CID_MANFID_SAMSUNG 0x15" If you need to add the Samsung

Re: [RFC PATCH 1/1 ]mmc: Support-FFU-for-eMMC-v5.0

2014-03-31 Thread Seunguk Shin
Some of Samsung eMMC does not show the argument for ffu in ext_csd. In case of this, eMMC shows 0x0 from ext_csd, Host has to modify the argument. Add "#define CID_MANFID_SAMSUNG 0x15" > +int mmc_ffu_download(struct mmc_card *card, struct mmc_command *cmd, > + u8 *data, int buf_byte

Re: [RFC PATCH 1/1 ]mmc: Support-FFU-for-eMMC-v5.0

2014-02-27 Thread Grant Grundler
Sorry. Gmail isn't vi and accidentally sent this prematurely. /o\ Continuing the review comments... On Thu, Feb 27, 2014 at 6:12 PM, Grant Grundler wrote: ... >> + >> +/* >> + * Map memory into a scatterlist. >> + */ >> +static int mmc_ffu_map_sg(struct mmc_ffu_mem *mem, unsigned long size, >> +

Re: [RFC PATCH 1/1 ]mmc: Support-FFU-for-eMMC-v5.0

2014-02-27 Thread Grant Grundler
Avi, thanks for posting this and apologies for not seeing/reviewing this earlier. Comments inline below. On Sun, Feb 9, 2014 at 1:07 AM, Avi Shchislowski wrote: > Add Support to Field Firmware Update (FFU) for eMMC v5.0 and up devices. > > The code implemented according to JEDEC eMMC spec -