RE: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-09-04 Thread Alex Lemberg
sson > Cc: Alex Lemberg; linux-mmc@vger.kernel.org; c...@laptop.org; Grant > Grundler; Avi Shchislowski; Gwendal Grignou (gwen...@chromium.org) > Subject: Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0 > > Hi, Ulf > > the data we expected to write in my case is about 2

Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-09-03 Thread Hsin-Hsiang Tseng
Hi, Ulf the data we expected to write in my case is about 288KB. BTW, Alex's FFU flow already implemented on my platform which using exynos SoC without problem. Thanks, Hsinhsiang 2014-09-01 19:27 GMT+08:00 Ulf Hansson : > On 1 September 2014 11:26, Alex Lemberg wrote: >> [snip] >> >>> My concl

Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-09-01 Thread Ulf Hansson
On 1 September 2014 11:26, Alex Lemberg wrote: > [snip] > >> My conclusion from that is (correct me if I am wrong, since it may be vendor >> specific), that only minor modifications should be needed to the mmc ioctl. >> We >> need to add special treatment for when "cmd.opcode == >> MMC_FFU_DOWNLO

RE: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-09-01 Thread Alex Lemberg
[snip] > My conclusion from that is (correct me if I am wrong, since it may be vendor > specific), that only minor modifications should be needed to the mmc ioctl. We > need to add special treatment for when "cmd.opcode == > MMC_FFU_DOWNLOAD_OP". In such scenario the following sequence needs to >

RE: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-08-25 Thread Alex Lemberg
t: Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0 > > [snip] > > >> >> By just browsing through the code for preparing and handling the > >> >> mmc data request in the above functions, I find quite some > >> >> duplication of code fr

Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-08-21 Thread Ulf Hansson
[snip] >> >> By just browsing through the code for preparing and handling the mmc >> >> data request in the above functions, I find quite some duplication of >> >> code from the card/*.c files. Could we maybe share some code between >> >> these layers to avoid duplications, and thus errors? >> > >

RE: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-08-21 Thread Alex Lemberg
PM > >> To: Avi Shchislowski; Grant Grundler; Alex Lemberg > >> Cc: linux-mmc@vger.kernel.org; c...@laptop.org > >> Subject: Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0 > >> > >> On 16 July 2014 17:47, Avi Shchislowski > >> > >>

Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-08-18 Thread Ulf Hansson
mmc@vger.kernel.org; c...@laptop.org >> Subject: Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0 >> >> On 16 July 2014 17:47, Avi Shchislowski >> wrote: >> > The Field Firmware Update (FFU) feature is new for eMMC 5.0 spec (Jedec: >> JESD84-B50.pdf) >>

RE: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-08-14 Thread Alex Lemberg
Hi Ulf, > -Original Message- > From: Ulf Hansson [mailto:ulf.hans...@linaro.org] > Sent: Wednesday, August 13, 2014 3:47 PM > To: Avi Shchislowski; Grant Grundler; Alex Lemberg > Cc: linux-mmc@vger.kernel.org; c...@laptop.org > Subject: Re: [RFC PATCH 1/1 v8]mmc: Support

Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-08-13 Thread Ulf Hansson
On 16 July 2014 17:47, Avi Shchislowski wrote: > The Field Firmware Update (FFU) feature is new for eMMC 5.0 spec (Jedec: > JESD84-B50.pdf) > > http://www.jedec.org/standards-documents/technology-focus-areas/flash-memory-ssds-ufs-emmc/e-mmc > > An ioctl has been added to provide the new firmwa

RE: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-08-07 Thread Avi Shchislowski
emberg Subject: Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0 Hi, Avi, I have another question want to consult, In your patch, after download the required firmware file, and back to normal mode. you will /* check that the eMMC has received the payload */ b

Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-08-01 Thread Hsin-Hsiang Tseng
;> Avi. >> >> >> -Original Message- >> From: Gwendal Grignou [mailto:gwen...@google.com] >> Sent: Wednesday, July 30, 2014 3:32 AM >> To: Gwendal Grignou >> Cc: Avi Shchislowski; linux-mmc@vger.kernel.org; c...@laptop.org; Grant >> Grundler; Alex

Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-07-31 Thread Hsin-Hsiang Tseng
> From: Gwendal Grignou [mailto:gwen...@google.com] > Sent: Wednesday, July 30, 2014 3:32 AM > To: Gwendal Grignou > Cc: Avi Shchislowski; linux-mmc@vger.kernel.org; c...@laptop.org; Grant > Grundler; Alex Lemberg > Subject: Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0 > >

RE: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-07-30 Thread Avi Shchislowski
Grignou [mailto:gwen...@google.com] Sent: Wednesday, July 30, 2014 3:32 AM To: Gwendal Grignou Cc: Avi Shchislowski; linux-mmc@vger.kernel.org; c...@laptop.org; Grant Grundler; Alex Lemberg Subject: Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0 I take it back, we can still use the 2 ioctl

Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-07-29 Thread Gwendal Grignou
I take it back, we can still use the 2 ioctl approach: We just need to remove the mmc_send_ext_csd() between the calls to set MMC_FFU_MODE_SET and MMC_FFU_MODE_NORMAL. Your patch v7 did not have this error, I introduced it in the comments I made on v7. Gwendal. On Tue, Jul 29, 2014 at 5:14 PM, Gw

Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-07-29 Thread Gwendal Grignou
Avi, We should revisit the 2 ioctls approach: Accroding to the spec: """When in FFU_MODE and host sends other commands which are not part of the recommended flow, device behavior may be undefined.""" To be safe, no command should be sent to the device which are not strictly necessary for the downl

Re: [RFC PATCH 1/1 v8]mmc: Support-FFU-for-eMMC-v5.0

2014-07-21 Thread Gwendal Grignou
Avi, The patch still does not work for me. After the upgrade, the eMMC is not in a good state timing out every IOs. A power cycle fixes the problem. I am investigating how the reset patch is working. Gwendal. On Wed, Jul 16, 2014 at 8:47 AM, Avi Shchislowski wrote: > > The Field Firmware Updat