Re: igmp: Allow mininum interval specification for igmp timers.

2010-09-23 Thread David Miller
From: Christoph Lameter Date: Wed, 22 Sep 2010 13:59:30 -0500 (CDT) > IGMP timers sometimes fire too rapidly due to randomization of the > intervalsfrom 0 to max_delay in igmp_start_timer(). ... > Signed-off-by: Christoph Lameter This change seems reasonable to me, what do you think David? --

Re: igmp: Staggered igmp report intervals for unsolicited igmp reports

2010-09-23 Thread Christoph Lameter
On Thu, 23 Sep 2010, Jason Gunthorpe wrote: > > IPoIB creates a infiniband multicast group via the IB calls for a IP > > multicast group. Then IGMP comes into play and the kernel sends the IP > > based igmp report. This igmp report must be received by an outside router > > (on an IP network) in or

Re: igmp: Staggered igmp report intervals for unsolicited igmp reports

2010-09-23 Thread Jason Gunthorpe
On Thu, Sep 23, 2010 at 12:37:28PM -0500, Christoph Lameter wrote: > On Thu, 23 Sep 2010, Jason Gunthorpe wrote: > > > On Thu, Sep 23, 2010 at 10:32:17AM -0500, Christoph Lameter wrote: > > > > > > Is the issue you are dropping IGMP packets because the 224.0.0.2 join > > > > hasn't finished? Ideal

Re: igmp: Staggered igmp report intervals for unsolicited igmp reports

2010-09-23 Thread Christoph Lameter
On Thu, 23 Sep 2010, Jason Gunthorpe wrote: > On Thu, Sep 23, 2010 at 10:32:17AM -0500, Christoph Lameter wrote: > > > > Is the issue you are dropping IGMP packets because the 224.0.0.2 join > > > hasn't finished? Ideally you'd wait for the SA to reply before sending > > > a IGMP, but a simpler so

Re: igmp: Staggered igmp report intervals for unsolicited igmp reports

2010-09-23 Thread Jason Gunthorpe
On Thu, Sep 23, 2010 at 10:32:17AM -0500, Christoph Lameter wrote: > > Is the issue you are dropping IGMP packets because the 224.0.0.2 join > > hasn't finished? Ideally you'd wait for the SA to reply before sending > > a IGMP, but a simpler solution might just be to use the broadcast MLID > > for

Re: igmp: Staggered igmp report intervals for unsolicited igmp reports

2010-09-23 Thread Christoph Lameter
On Wed, 22 Sep 2010, David Stevens wrote: > > > > Also increment the frequency so that we get a 10 reports send over a > > few seconds. > > Except you want to conform and not conform at the same time. :-) > IGMPv2 should be: default count 2, interval 10secs > IGMPv3 should be: default coun

Re: [PATCH 2/2] siw: Add support for CRC32C offload instruction using libcrypto crc32c-intel

2010-09-23 Thread Bernard Metzler
linux-rdma-ow...@vger.kernel.org wrote on 09/23/2010 12:36:29 AM: > On Wed, 2010-09-22 at 16:06 -0600, Jason Gunthorpe wrote: > > On Wed, Sep 22, 2010 at 02:38:31PM -0700, Nicholas A. Bellinger wrote: > > > > > So I think the main bit here is the ability to request > > > crc32c-intel.ko first, a

Re: igmp: Staggered igmp report intervals for unsolicited igmp reports

2010-09-23 Thread Christoph Lameter
On Wed, 22 Sep 2010, Jason Gunthorpe wrote: > > The device is ready. Its just the multicast group that has not been > > established yet. > > In IB when the SA replies to a group join the group should be ready, > prior to that the device can't send into the group because it has no > MLID for the gr

Re: [PATCH] opensm/osm_helper.c: use ARR_SIZE macro instead of hardcoded values

2010-09-23 Thread Sasha Khapyorsky
On 11:56 Sun 12 Sep , Yevgeny Kliteynik wrote: > > Signed-off-by: Yevgeny Kliteynik Applied. Thanks. Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-

Re: software iwarp stack update

2010-09-23 Thread Bernard Metzler
linux-rdma-ow...@vger.kernel.org wrote on 09/22/2010 10:42:18 PM: > On 09/22/2010 03:35 PM, Nicholas A. Bellinger wrote: > > On Wed, 2010-09-22 at 10:19 +0200, Bernard Metzler wrote: > > > >> Earlier this year, we announced the availability of an open source, > >> full software implementation of

Re: [PATCH 1/2] siw: Fix ib_register_device() for > v2.6.34 kernels

2010-09-23 Thread Bernard Metzler
Thanks, Nicholas. Just applied your patch. Bernard. linux-rdma-ow...@vger.kernel.org wrote on 09/22/2010 10:30:17 PM: > From: Nicholas Bellinger > > This patch adds a LINUX_VERSION_CODE > v2.6.34 check inside of > siw_main.c:siw_register_device() > around the use of ib_register_device(). In po

Re: idr_get_new_exact ?

2010-09-23 Thread Tejun Heo
Hello, On 09/23/2010 01:42 PM, Paul Mundt wrote: > On Mon, Sep 20, 2010 at 11:26:47PM +0200, Tejun Heo wrote: >> Hello, >> >> On 09/20/2010 10:35 PM, Roland Dreier wrote: >>> Looks fine to me as an improvement over the status quo, but I wonder how >>> many of these places could use the radix_tree

Re: idr_get_new_exact ?

2010-09-23 Thread Paul Mundt
On Mon, Sep 20, 2010 at 11:26:47PM +0200, Tejun Heo wrote: > Hello, > > On 09/20/2010 10:35 PM, Roland Dreier wrote: > > Looks fine to me as an improvement over the status quo, but I wonder how > > many of these places could use the radix_tree stuff instead? If you're > > not using the ability of

Re: [PATCH 02/13] drivers/infiniband: Remove unnecessary casts of private_data

2010-09-23 Thread Jiri Kosina
On Tue, 7 Sep 2010, Ralph Campbell wrote: > Acked-by: Ralph Campbell Applied, thanks. > > Signed-off-by: Joe Perches > > --- > > drivers/infiniband/hw/qib/qib_file_ops.c |4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/infiniband/hw/qib/qib_file_