Re: [PATCH] mlx4: Fix unneeded return error in eth_link_query_port

2010-10-24 Thread Roland Dreier
OK... since my "fix" for the missing return of the error value ended up breaking things, I just decided to fold this second fix into the original patch. The end result is the same code but I didn't think keeping the buggy point in the middle of history helped anything. - R. -- To unsubscribe fro

Re: [PATCH] mlx4: Fix unneeded return error in eth_link_query_port

2010-10-24 Thread Eli Cohen
On Sun, Oct 24, 2010 at 6:22 PM, Roland Dreier wrote: >  > No you did not. It was there already but we never noticed before >  > Yossi's patch. > > But AFAICT Yossi's patch (5eb620c8) went into 2.6.22 about 2.5 years > ago... wasn't that already there way before the IBoE stuff started? > I see...

Re: [PATCH] mlx4: Fix unneeded return error in eth_link_query_port

2010-10-24 Thread Roland Dreier
> No you did not. It was there already but we never noticed before > Yossi's patch. But AFAICT Yossi's patch (5eb620c8) went into 2.6.22 about 2.5 years ago... wasn't that already there way before the IBoE stuff started? - R. -- To unsubscribe from this list: send the line "unsubscribe linux-r

Re: [PATCH] mlx4: Fix unneeded return error in eth_link_query_port

2010-10-24 Thread Eli Cohen
On Sun, Oct 24, 2010 at 08:42:06AM -0700, Roland Dreier wrote: > applied, thanks. > > (I didn't introduce this bug in my monkeying with the patches, did I?) No you did not. It was there already but we never noticed before Yossi's patch. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] mlx4: Fix unneeded return error in eth_link_query_port

2010-10-24 Thread Roland Dreier
applied, thanks. (I didn't introduce this bug in my monkeying with the patches, did I?) -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: perftest

2010-10-24 Thread Ido Shamai
Hello Sean , perftest.git tree can be found in git://git.openfabrics.org/~shamoya/perftest.git (new server) Can also be found as a tarball in http://sofa.openfabrics.org/downloads/perftest/ Regards On 10/21/2010 7:07 PM, Hefty, Sean wrote: Does anyone know what the latest perftest.git tree

[PATCH] mlx4: Fix unneeded return error in eth_link_query_port

2010-10-24 Thread Eli Cohen
eth_link_query_port() returns error if a netdevice was not yet associated with the IBoE port. This is not required since we already initialize the link as down. On the other hand, we need other information that the query provides. Specifically, this can cause a failure to initilize an IBoE device

Re: [PATCHv10 12/12] mlx4: Add vlan support to IBoE

2010-10-24 Thread Eli Cohen
On Fri, Oct 22, 2010 at 02:25:11PM -0700, Roland Dreier wrote: > > @@ -1801,6 +1831,11 @@ int mlx4_ib_post_send(struct ib_qp *ibqp, struct > ib_send_wr *wr, > >ctrl->owner_opcode = mlx4_ib_opcode[wr->opcode] | > >(ind & qp->sq.wqe_cnt ? cpu_to_be32(1 << 31) : 0)