Re: [PATCH] Return EPROTONOSUPPORT when an RDMA device lacks QP0

2011-05-20 Thread Weiny, Ira K.
On May 20, 2011, at 4:23 PM, Hefty, Sean wrote: >>> mad_agent_priv->agent.mr = ib_get_dma_mr(port_priv->qp_info[qpn].qp- >>> pd, >>> IB_ACCESS_LOCAL_WRITE); >>> >>> in which case it may be safer to check for the NULL pointer. Can you >> confirm i

RE: [PATCH] Return EPROTONOSUPPORT when an RDMA device lacks QP0

2011-05-20 Thread Hefty, Sean
> > mad_agent_priv->agent.mr = ib_get_dma_mr(port_priv->qp_info[qpn].qp- > >pd, > > IB_ACCESS_LOCAL_WRITE); > > > > in which case it may be safer to check for the NULL pointer. Can you > confirm if this was the spot? > > Yes it was that spot. I di

Re: [PATCH] Return EPROTONOSUPPORT when an RDMA device lacks QP0

2011-05-20 Thread Weiny, Ira K.
On May 20, 2011, at 12:23 PM, Hefty, Sean wrote: >> We had a script which was looping through the devices returned from ibstat >> and attempted to register a SMI agent on an ethernet device. This caused >> a kernel panic. We have fixed our script. This patch prevents the panic. > > Do you rem

[PATCHv2 3/13] opensm: Dump/load SA GUIDInfoRecords

2011-05-20 Thread Hal Rosenstock
into port alias guid table Signed-off-by: Hal Rosenstock --- Changes since v1: In osm_sa.c:load_guidinfo, change continue to break opensm/osm_sa.c | 146 ++- opensm/osm_sa_guidinfo_record.c |8 ++- 2 files changed, 150 insertions(+), 4 d

Re: [PATCH 3/13] opensm: Dump/load SA GUIDInfoRecords

2011-05-20 Thread Hal Rosenstock
On 5/15/2011 10:52 AM, Alex Netes wrote: > Hi Hal, > > On 09:27 Fri 29 Apr , Hal Rosenstock wrote: >> From b587d02d3ab47e3fe47f98b2c8115c7686e6104e Mon Sep 17 00:00:00 2001 >> From: Hal Rosenstock >> Date: Thu, 28 Apr 2011 22:53:34 +0300 >> Subject: [PATCH] opensm: Dump/load SA GUIDInfoRecord

[PATCHv2 2/13] opensm: Make SA assigned guids persistent across port down/up events

2011-05-20 Thread Hal Rosenstock
Infrastructure in osm_subnet.[h c] with actual changes in opensm/osm_sa_guidinfo_record.c Signed-off-by: Hal Rosenstock --- Changes since v1: In set_guidinfo when osm_assigned_guids_new fails, send SA error and return include/opensm/osm_subnet.h | 110 +

Re: [PATCH 2/13] opensm: Make SA assigned guids persistent across port down/up events

2011-05-20 Thread Hal Rosenstock
Hi again Alex, On 5/15/2011 3:33 AM, Alex Netes wrote: > On 10:43 Sat 14 May , Hal Rosenstock wrote: >> Hi Alex, >> >> On 5/12/2011 11:47 AM, Alex Netes wrote: >>> Hi Hal, >>> >>> On 09:27 Fri 29 Apr , Hal Rosenstock wrote: From 28edb24012fe79ed5556dc612ad0d4b4b0d8c571 Mon Sep 17 00:0

RE: [PATCH] Return EPROTONOSUPPORT when an RDMA device lacks QP0

2011-05-20 Thread Hefty, Sean
> We had a script which was looping through the devices returned from ibstat > and attempted to register a SMI agent on an ethernet device. This caused > a kernel panic. We have fixed our script. This patch prevents the panic. Do you remember where the panic was? I'm going to guess in ib_regis

[PATCH] Return EPROTONOSUPPORT when an RDMA device lacks QP0

2011-05-20 Thread Weiny, Ira K.
We had a script which was looping through the devices returned from ibstat and attempted to register a SMI agent on an ethernet device. This caused a kernel panic. We have fixed our script. This patch prevents the panic. 0001-Return-EPROTONOSUPPORT-when-an-RDMA-device-lacks-QP0.patch Descr

[PATCHv2 1/2] opensm/osm_pkey_mgr.c: Pack switch peer port PKey tables

2011-05-20 Thread Hal Rosenstock
In pkey_mgr_update_peer_port, rather than mirror the end port PKey table, pack the peer switch's port PKey table to eliminate any holes. This is only done for switch external ports and not end ports because it's disruptive to change end port pkey indices whereas that's not the case for switch ext

Re: [PATCH 1/2] opensm/osm_pkey_mgr.c: Pack switch peer port PKey tables

2011-05-20 Thread Hal Rosenstock
Hi Alex, On 5/16/2011 10:56 AM, Alex Netes wrote: > Hi Hal, > > On 19:45 Mon 02 May , Hal Rosenstock wrote: >> Hi Alex, >> >> On 5/2/2011 8:12 AM, Alex Netes wrote: >>> Hi Hal, >>> >>> >>> On 15:39 Mon 11 Apr , Hal Rosenstock wrote: In pkey_mgr_update_peer_port, rather than mirr

[PATCH] RDMA/cxgb4: Use completion objects for event blocking.

2011-05-20 Thread Steve Wise
There exists a race condition when using wait_queue_head_t objects that are declared on the stack. This was being done in a few places where we are sending work requests to the FW and awaiting replies, but we don't have an endpoint structure with an embedded c4iw_wr_wait struct. So the code was al

[PATCH] opensm/osm_pkey_mgr.c: Fix cast

2011-05-20 Thread Hal Rosenstock
introduced by commit 2c5148408d562d86e1dd5d90939a58533ddebbe6 to eliminate compiler warning: osm_pkey_mgr.c: In function 'osm_pkey_mgr_process': osm_pkey_mgr.c:561: warning: assignment from incompatible pointer type Signed-off-by: Hal Rosenstock --- diff --git a/opensm/osm_pkey_mgr.c b/opensm/o