RE: [PATCH v2] IB/CMA: Invalidate connections in port space IPoIB over Ethernet link layer

2011-07-11 Thread Hefty, Sean
> diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c > index b6a33b3..2d60130 100644 > --- a/drivers/infiniband/core/cma.c > +++ b/drivers/infiniband/core/cma.c > @@ -359,6 +359,10 @@ static int cma_acquire_dev(struct rdma_id_private > *id_priv) > enum rdma_link_layer

Re: [PATCH 3/4] infiniband-diags: properly resolve node guids

2011-07-11 Thread Jason Gunthorpe
On Mon, Jul 11, 2011 at 02:06:02PM -0700, Ira Weiny wrote: > > But very few diags seem to be designed around the idea that they will > > operate on a bundle of end ports (eg a node), they tend to be one end > > port only, so asking for a "node" is nonsense. > > Why do you object to tools which re

Re: [PATCH 3/4] infiniband-diags: properly resolve node guids

2011-07-11 Thread Ira Weiny
On Fri, 8 Jul 2011 15:55:10 -0700 Jason Gunthorpe wrote: > On Fri, Jul 08, 2011 at 03:29:53PM -0700, Ira Weiny wrote: > > On Fri, 8 Jul 2011 14:59:01 -0700 > > Hal Rosenstock wrote: > > > > > On 7/8/2011 5:50 PM, Jason Gunthorpe wrote: > > > > On Fri, Jul 08, 2011 at 05:42:38PM -0400, Hal Rosen

Re: [PATCH 3/4] infiniband-diags: properly resolve node guids

2011-07-11 Thread Hal Rosenstock
Ira, On 7/8/2011 6:29 PM, Ira Weiny wrote: > On Fri, 8 Jul 2011 14:59:01 -0700 > Hal Rosenstock wrote: > >> On 7/8/2011 5:50 PM, Jason Gunthorpe wrote: >>> On Fri, Jul 08, 2011 at 05:42:38PM -0400, Hal Rosenstock wrote: >>> Should the request just be a GET rather than GET_TABLE and avoid th

Re: [PATCH] opensm: make loopback console compile on by default.

2011-07-11 Thread Alex Netes
Hi Ira, On 10:23 Mon 11 Jul , Weiny, Ira K. wrote: > > On Jul 10, 2011, at 2:14 AM, Alex Netes wrote: > > > Hi Ira, > > > > On 15:54 Wed 06 Jul , Ira Weiny wrote: > >> > >> The console is very useful for debugging and should be available in > >> opensm.conf > >> as an option. > >> >

[PATCH 3/3] Remove unused variables from code

2011-07-11 Thread Alex Netes
Unused variables may cause unused-but-set warning Signed-off-by: Alex Netes --- opensm/osm_inform.c |2 -- opensm/osm_lid_mgr.c|5 +++-- opensm/osm_mesh.c |2 -- opensm/osm_sa.c |3 +-- opensm/osm_sa_informinfo.c |2 -

[PATCH 2/3] libvendor/osm_vendor_ibumad.c: fix unused-but-set warning

2011-07-11 Thread Alex Netes
is_rmpp might be set but unused when VENDOR_RMPP_SUPPORT is TRUE. Mark this variable as __attribute__((unused)) to remove this warning. Signed-off-by: Alex Netes --- libvendor/osm_vendor_ibumad.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libvendor/osm_vendor_ibuma

[PATCH 1/3] fixed unsused-but-set warning for DEBUG variables

2011-07-11 Thread Alex Netes
Some variables are used only when compiling opensm with DEBUG flag. In general compilation, this might produce unused-but-set warning. Setting thais variables with __attribute__((unused)) removes this warning. Signed-off-by: Alex Netes --- complib/cl_event_wheel.c |2 +- complib/cl

[PATCH 0/3] opensm: fixing unused-but-set warnings in compilation

2011-07-11 Thread Alex Netes
Latest GCC 4.6 include -Wunused-* flags as part of the -Wall flag, causing many warnings during OpenSM compilation. This patch series tries to clean these warnings. Where possible, unused variables were just deleted. In other cases where some variables are used only when specific compilation flags

[PATCH v2] IB/CMA: Invalidate connections in port space IPoIB over Ethernet link layer

2011-07-11 Thread Moni Shoua
From: Moni Shoua This patch fixes a kernel crash in cma_set_qkey(). When link layer is ETHERNET it is wrong to use IPoIB port space since no IPoIB interface is available. Specifically, setting qkey when port space is RDMA_PS_IPOIB, requires mgid calculation and SA query which is illegal over Eth

Re: [PATCH] opensm: make loopback console compile on by default.

2011-07-11 Thread Weiny, Ira K.
On Jul 10, 2011, at 2:14 AM, Alex Netes wrote: > Hi Ira, > > On 15:54 Wed 06 Jul , Ira Weiny wrote: >> >> The console is very useful for debugging and should be available in >> opensm.conf >> as an option. >> >> Generic socket is still an option which is off for security reasons. >> >> S

Re: install.pl "chown" issue (Was: Re: rhel6 ofed v1.5.3)

2011-07-11 Thread Michael Di Domenico
On Mon, Jul 11, 2011 at 9:43 AM, Michael Di Domenico wrote: > On Mon, Jul 11, 2011 at 9:28 AM, Michael Di Domenico > wrote: >> On Tue, Jul 5, 2011 at 6:36 PM, Ira Weiny wrote: >>> On Fri, 1 Jul 2011 10:08:47 -0700 >>> Michael Di Domenico wrote: >>> According to my installation of Ofed 1.5.

RE: [PATCH] drivers/infiniband/hw/qib/qib_iba7322: remove double define

2011-07-11 Thread Mike Marciniszyn
> > Double define removed. > > Signed-off-by: Edwin van Vliet > --- > drivers/infiniband/hw/qib/qib_iba7322.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Thanks for the patch! Acked-by: Mike Marciniszyn This message and any attached documents contain information from QLogic

Re: install.pl "chown" issue (Was: Re: rhel6 ofed v1.5.3)

2011-07-11 Thread Michael Di Domenico
On Mon, Jul 11, 2011 at 9:28 AM, Michael Di Domenico wrote: > On Tue, Jul 5, 2011 at 6:36 PM, Ira Weiny wrote: >> On Fri, 1 Jul 2011 10:08:47 -0700 >> Michael Di Domenico wrote: >> >>> According to my installation of Ofed 1.5.3 on RHEL6, the >>> infiniband-diags package rpm is trying to chown /u

Re: install.pl "chown" issue (Was: Re: rhel6 ofed v1.5.3)

2011-07-11 Thread Michael Di Domenico
On Tue, Jul 5, 2011 at 6:36 PM, Ira Weiny wrote: > On Fri, 1 Jul 2011 10:08:47 -0700 > Michael Di Domenico wrote: > >> According to my installation of Ofed 1.5.3 on RHEL6, the >> infiniband-diags package rpm is trying to chown /usr/local in order to >> deposit a library in lib64. > > infiniband-d

Re: [PATCH 2/4] infiniband-diags: move core saquery functionality to ibdiag_common

2011-07-11 Thread Hal Rosenstock
On 7/8/2011 5:41 PM, Hal Rosenstock wrote: > On 7/5/2011 3:08 PM, Ira Weiny wrote: >> >> While this is sub-optimal it is the easiest way to get saquery support to the >> other diags. > > Just some nits below... > >> Signed-off-by: Ira Weiny >> --- >> include/ibdiag_common.h | 45 +++ >

Re: [PATCH] opensm: Add support for partition enforcement types

2011-07-11 Thread Hal Rosenstock
Hi Alex, On 7/10/2011 7:26 AM, Alex Netes wrote: > Hi Hal, > > On 14:52 Tue 05 Jul , Hal Rosenstock wrote: >> >> Partition enforcement types are in, out, and both. >> Prior to this support, both was being used so that is the default. >> >> Signed-off-by: Hal Rosenstock >> --- > > Now we end

[PATCHv2] libibmad: Add PortExtendedSpeedsCounters support

2011-07-11 Thread Hal Rosenstock
Signed-off-by: Hal Rosenstock --- diff --git a/include/infiniband/mad.h b/include/infiniband/mad.h index 7500e1a..f00bf7a 100644 --- a/include/infiniband/mad.h +++ b/include/infiniband/mad.h @@ -175,6 +175,7 @@ enum GSI_ATTR_ID { IB_GSI_PORT_RCV_ERROR_DETAILS = 0x15, IB_GSI_PORT_X

[PATCH/libmlx4] Use BlueFlame for RDMA_WRITE_WITH_IMM without data requests too

2011-07-11 Thread Dotan Barak
Use BlueFlame for RDMA Write with immediate without any data (no s/g) too. This improves latency. Signed-off-by: Dotan Barak Reviewed-by: Jack Morgenstein --- src/qp.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/qp.c b/src/qp.c index e046da1..10ccbff 100644