Re: [PATCH] ib_srp: Fix use-after-free in srp_reset_req()

2012-09-17 Thread David Dillow
On Mon, 2012-09-17 at 15:50 -0400, Roland Dreier wrote: > On Mon, Sep 17, 2012 at 12:31 PM, David Dillow wrote: > > Roland, are you planning to apply this one and the one Bart has that > > fixes the error handling (srp_aport)? I didn't see them in your pull > > request. > > Sorry, I guess I misse

Re: [PATCH] ib_srp: Fix use-after-free in srp_reset_req()

2012-09-17 Thread Roland Dreier
On Mon, Sep 17, 2012 at 12:31 PM, David Dillow wrote: > Roland, are you planning to apply this one and the one Bart has that > fixes the error handling (srp_aport)? I didn't see them in your pull > request. Sorry, I guess I missed them. I think I'll probably just put it into 3.7 with a stable ta

Re: [PATCH] ib_srp: Fix use-after-free in srp_reset_req()

2012-09-17 Thread David Dillow
On Fri, 2012-08-24 at 10:27 +, Bart Van Assche wrote: > srp_free_req() uses the scsi_cmnd structure contents to unmap > buffers, so we must invoke srp_free_req() before we release > ownership of that structure. > > Signed-off-by: Bart Van Assche > Acked-by: David Dillow > Cc: Roland Dreier

[PATCH] ib_srp: Fix use-after-free in srp_reset_req()

2012-08-24 Thread Bart Van Assche
srp_free_req() uses the scsi_cmnd structure contents to unmap buffers, so we must invoke srp_free_req() before we release ownership of that structure. Signed-off-by: Bart Van Assche Acked-by: David Dillow Cc: Roland Dreier Cc: --- drivers/infiniband/ulp/srp/ib_srp.c |2 +- 1 files changed