Re: [PATCH] ibsim: fix size of slid/dlid fields in sim_request structure

2011-08-10 Thread Jason Gunthorpe
On Wed, Aug 10, 2011 at 11:18:33AM -0600, Rolf Manderscheid wrote: > Hi Alex, > >There are more places where lids defined as integer. Why did you choose to > >change only these two? > > This structure defines what request packets look like on the wire to > the simulator. The motivation for the ch

Re: [PATCH] ibsim: fix size of slid/dlid fields in sim_request structure

2011-08-10 Thread Rolf Manderscheid
Hi Alex, There are more places where lids defined as integer. Why did you choose to change only these two? This structure defines what request packets look like on the wire to the simulator. The motivation for the change is a simulator client for python-rdma, and this issue shows up when cre

Re: [PATCH] ibsim: fix size of slid/dlid fields in sim_request structure

2011-08-09 Thread Alex Netes
Hi Rolf, On 17:29 Fri 05 Aug , Rolf Manderscheid wrote: > > The code treats them as 16-bit fields (by using htons), make > the structure match. This also avoids the 32 bits of padding > before the length field. > There are more places where lids defined as integer. Why did you choose to ch

[PATCH] ibsim: fix size of slid/dlid fields in sim_request structure

2011-08-05 Thread Rolf Manderscheid
The code treats them as 16-bit fields (by using htons), make the structure match. This also avoids the 32 bits of padding before the length field. Signed-off-by: Rolf Manderscheid --- include/ibsim.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/ibsim.h b/