On Tue, Feb 17, 2015 at 02:47:03PM +0200, Matan Barak wrote:
>
>
> On 2/16/2015 7:32 PM, Yuval Shaia wrote:
> >ping
> >
> >On Mon, Jan 26, 2015 at 06:30:23AM -0800, Yuval Shaia wrote:
> >>1. Add descriptions of all features.
> >>2. Add indication whether feature is supported or not.
> >>With this
On 2/16/2015 7:32 PM, Yuval Shaia wrote:
ping
On Mon, Jan 26, 2015 at 06:30:23AM -0800, Yuval Shaia wrote:
1. Add descriptions of all features.
2. Add indication whether feature is supported or not.
With this enhancement all device features will be printed along with flags that
shows if feat
ping
On Mon, Jan 26, 2015 at 06:30:23AM -0800, Yuval Shaia wrote:
> 1. Add descriptions of all features.
> 2. Add indication whether feature is supported or not.
> With this enhancement all device features will be printed along with flags
> that shows if feature is supported by FW, Driver or both
On Mon, Dec 15, 2014 at 06:14:31PM +0200, Or Gerlitz wrote:
> >>
> >> NO, as Matan wrote you "except for Or's comments" - we do want to dump
> > Sure, was not ignoring this one, it was just a warn :)
> >> what is supported by both the device (firmware) and the driver, and
> >> not more. A subset of
1. Add descriptions of all features.
2. Add indication whether feature is supported or not.
With this enhancement all device features will be printed along with flags that
shows if feature is supported by FW, Driver or both.
Signed-off-by: Yuval Shaia
---
drivers/net/ethernet/mellanox/mlx4/fw.c
1. Add descriptions of all features.
2. Add indication whether feature is supported or not.
With this enhancement all device features will be printed along with flags that
shows if feature is supported by FW, Driver or both.
Signed-off-by: Yuval Shaia
---
drivers/net/ethernet/mellanox/mlx4/fw.c
> >> >- mlx4_dbg(dev, "%s\n", fname[i]);
> >> >+ if (fname[i])
> >> >+ mlx4_dbg(dev, "(%c) %s\n", (flags & (1LL <<
> >> >i)) ?
> >> >+'*' : ' ', fname[i]);
> >> > }
> >>
> >> I think that the strings
On Mon, Dec 15, 2014 at 06:14:31PM +0200, Or Gerlitz wrote:
> >> >> >+ [52] =RSS on fragmented IP datagram support",
> >> >>
> >> >> Hi,
> >> >>
> >> >> Except for Or's comments, [55] exists twice. Furthermore, please
> >> >> move [56]-[57] to be after [55] =Port link type sensing sup
On Mon, Dec 15, 2014 at 2:25 PM, Yuval Shaia wrote:
> On Mon, Dec 15, 2014 at 11:35:52AM +0200, Or Gerlitz wrote:
>> On Mon, Dec 15, 2014 at 11:21 AM, Yuval Shaia wrote:
>> > On Wed, Dec 10, 2014 at 12:10:07PM +0200, Matan Barak wrote:
>> >>
>> >>
>> >> On 12/8/2014 1:48 AM, Yuval Shaia wrote:
>>
On Mon, Dec 15, 2014 at 11:35:52AM +0200, Or Gerlitz wrote:
> On Mon, Dec 15, 2014 at 11:21 AM, Yuval Shaia wrote:
> > On Wed, Dec 10, 2014 at 12:10:07PM +0200, Matan Barak wrote:
> >>
> >>
> >> On 12/8/2014 1:48 AM, Yuval Shaia wrote:
> >> >1. Add indication whether feature is supported or not.
>
On Mon, Dec 15, 2014 at 11:21 AM, Yuval Shaia wrote:
> On Wed, Dec 10, 2014 at 12:10:07PM +0200, Matan Barak wrote:
>>
>>
>> On 12/8/2014 1:48 AM, Yuval Shaia wrote:
>> >1. Add indication whether feature is supported or not.
>> >2. Add descriptions of all features.
>> >Without this fix there is no
1. Add indication whether feature is supported or not.
2. Add descriptions of all features.
Without this fix there is no way to tell if feature is not supported or that
description is not exist.
Signed-off-by: Yuval Shaia
---
drivers/net/ethernet/mellanox/mlx4/fw.c | 36 ++
On Wed, Dec 10, 2014 at 12:10:07PM +0200, Matan Barak wrote:
>
>
> On 12/8/2014 1:48 AM, Yuval Shaia wrote:
> >1. Add indication whether feature is supported or not.
> >2. Add descriptions of all features.
> >Without this fix there is no way to tell if feature is not supported or that
> >descrip
On 12/8/2014 1:48 AM, Yuval Shaia wrote:
1. Add indication whether feature is supported or not.
2. Add descriptions of all features.
Without this fix there is no way to tell if feature is not supported or that
description is not exist.
Signed-off-by: Yuval Shaia
---
drivers/net/ethernet/me
On Tue, Dec 09, 2014 at 07:55:07PM +0200, Or Gerlitz wrote:
> On Mon, Dec 8, 2014 at 1:48 AM, Yuval Shaia wrote:
> > 1. Add indication whether feature is supported or not.
> > 2. Add descriptions of all features.
> > Without this fix there is no way to tell if feature is not supported or
> > that
On Mon, Dec 8, 2014 at 1:48 AM, Yuval Shaia wrote:
> 1. Add indication whether feature is supported or not.
> 2. Add descriptions of all features.
> Without this fix there is no way to tell if feature is not supported or that
> description is not exist.
The problem with this patch is that the c
1. Add indication whether feature is supported or not.
2. Add descriptions of all features.
Without this fix there is no way to tell if feature is not supported or that
description is not exist.
Signed-off-by: Yuval Shaia
---
drivers/net/ethernet/mellanox/mlx4/fw.c | 37 ++
17 matches
Mail list logo
