Re: [PATCH 1/3 fixed] infiniband-diags: Make ibportstate support displaying/changing MKey, lease, and protect bits

2012-03-15 Thread Jim Foraker
Aaah. Ira pointed me at a previous thread that provided some context. I thought the concern was with the display of mkey results in a query, not on the command line. I hadn't noticed the getpass() support for smkey. It makes sense that mkey should operate the same way. Jim On Tue, 2

Re: [PATCH 1/3 fixed] infiniband-diags: Make ibportstate support displaying/changing MKey, lease, and protect bits

2012-03-13 Thread Hal Rosenstock
On 3/9/2012 2:17 PM, Jim Foraker wrote: > > On Fri, 2012-03-09 at 05:00 -0800, Hal Rosenstock wrote: >> On 3/6/2012 5:16 PM, Jim Foraker wrote: >>> >>> Displaying/changing are both supported for the >>> MKey itself, plus lease and protect bits >> >> Don't we want to be careful about displaying mk

Re: [PATCH 1/3 fixed] infiniband-diags: Make ibportstate support displaying/changing MKey, lease, and protect bits

2012-03-09 Thread Jim Foraker
On Fri, 2012-03-09 at 05:00 -0800, Hal Rosenstock wrote: > On 3/6/2012 5:16 PM, Jim Foraker wrote: > > > > Displaying/changing are both supported for the > > MKey itself, plus lease and protect bits > > Don't we want to be careful about displaying mkey info ? I think by > default it shouldn't b

Re: [PATCH 1/3 fixed] infiniband-diags: Make ibportstate support displaying/changing MKey, lease, and protect bits

2012-03-09 Thread Hal Rosenstock
On 3/6/2012 5:16 PM, Jim Foraker wrote: > > Displaying/changing are both supported for the > MKey itself, plus lease and protect bits Don't we want to be careful about displaying mkey info ? I think by default it shouldn't be displayed and at least require an additional option to make it visible

[PATCH 1/3 fixed] infiniband-diags: Make ibportstate support displaying/changing MKey, lease, and protect bits

2012-03-06 Thread Jim Foraker
Displaying/changing are both supported for the MKey itself, plus lease and protect bits Signed-off-by: Jim Foraker --- src/ibportstate.c | 64 +++- 1 files changed, 57 insertions(+), 7 deletions(-) diff --git a/src/ibportstate.c b/src/ibportst