Re: [PATCH v1 09/12] xprtrdma: Prepare rpcrdma_ep_post() for RDMA_NOMSG calls

2015-07-10 Thread Jason Gunthorpe
On Fri, Jul 10, 2015 at 10:53:40AM -0400, Chuck Lever wrote: > It is certainly possible to examine the device’s max_sge field > in rpcrdma_ep_create() and fail transport creation if the > device’s max_sge is less than RPC_MAX_IOVS. I just want to draw Sagi's attention to this problem, when consid

Re: [PATCH v1 09/12] xprtrdma: Prepare rpcrdma_ep_post() for RDMA_NOMSG calls

2015-07-10 Thread Chuck Lever
> On Jul 10, 2015, at 4:43 PM, Anna Schumaker wrote: > > Hi Chuck, > > On 07/09/2015 04:43 PM, Chuck Lever wrote: >> Only the RPC/RDMA header is sent when making an RDMA_NOMSG call. >> That header resides in the first element of the iovec array >> passed to rpcrdma_ep_post(). >> >> Instead of

Re: [PATCH v1 09/12] xprtrdma: Prepare rpcrdma_ep_post() for RDMA_NOMSG calls

2015-07-10 Thread Anna Schumaker
Hi Chuck, On 07/09/2015 04:43 PM, Chuck Lever wrote: > Only the RPC/RDMA header is sent when making an RDMA_NOMSG call. > That header resides in the first element of the iovec array > passed to rpcrdma_ep_post(). > > Instead of special casing the iovec element with the pad, just > sync all the el

Re: [PATCH v1 09/12] xprtrdma: Prepare rpcrdma_ep_post() for RDMA_NOMSG calls

2015-07-10 Thread Chuck Lever
On Jul 10, 2015, at 10:11 AM, Devesh Sharma wrote: > On Fri, Jul 10, 2015 at 6:28 PM, Tom Talpey wrote: >> On 7/10/2015 7:29 AM, Devesh Sharma wrote: >>> >>> we need to honor the max limits of device by checking >>> dev_attr.max_sge? a vendor may not support 4 sges. >> >> >> iWARP requires a

Re: [PATCH v1 09/12] xprtrdma: Prepare rpcrdma_ep_post() for RDMA_NOMSG calls

2015-07-10 Thread Devesh Sharma
On Fri, Jul 10, 2015 at 6:28 PM, Tom Talpey wrote: > On 7/10/2015 7:29 AM, Devesh Sharma wrote: >> >> we need to honor the max limits of device by checking >> dev_attr.max_sge? a vendor may not support 4 sges. > > > iWARP requires a minimum of 4 send SGEs (draft-hilland-verbs 8.1.3.2) > >An RI

Re: [PATCH v1 09/12] xprtrdma: Prepare rpcrdma_ep_post() for RDMA_NOMSG calls

2015-07-10 Thread Tom Talpey
On 7/10/2015 7:29 AM, Devesh Sharma wrote: we need to honor the max limits of device by checking dev_attr.max_sge? a vendor may not support 4 sges. iWARP requires a minimum of 4 send SGEs (draft-hilland-verbs 8.1.3.2) An RI MUST support at least four Scatter/Gather Elements per Scatter/G

Re: [PATCH v1 09/12] xprtrdma: Prepare rpcrdma_ep_post() for RDMA_NOMSG calls

2015-07-10 Thread Devesh Sharma
we need to honor the max limits of device by checking dev_attr.max_sge? a vendor may not support 4 sges. On Fri, Jul 10, 2015 at 2:13 AM, Chuck Lever wrote: > Only the RPC/RDMA header is sent when making an RDMA_NOMSG call. > That header resides in the first element of the iovec array > passed to

[PATCH v1 09/12] xprtrdma: Prepare rpcrdma_ep_post() for RDMA_NOMSG calls

2015-07-09 Thread Chuck Lever
Only the RPC/RDMA header is sent when making an RDMA_NOMSG call. That header resides in the first element of the iovec array passed to rpcrdma_ep_post(). Instead of special casing the iovec element with the pad, just sync all the elements in the send iovec. Syncing the zero pad is not strictly nec