Re: [patch net-next 01/16] net: introduce upper device lists

2012-08-15 Thread Nicolas de Pesloüan
Le 13/08/2012 19:31, Jiri Pirko a écrit : Mon, Aug 13, 2012 at 07:04:11PM CEST, bhutchi...@solarflare.com wrote: +struct netdev_upper { + struct net_device *dev; + bool unique; This needs a better name. It doesn't really have anything to do with uniqueness and doesn't ensure exc

Re: [patch net-next 01/16] net: introduce upper device lists

2012-08-14 Thread Jiri Pirko
Tue, Aug 14, 2012 at 03:14:00PM CEST, f...@redhat.com wrote: >On Tue, 14 Aug 2012 14:24:33 +0200 >Jiri Pirko wrote: > >> Mon, Aug 13, 2012 at 07:52:17PM CEST, f...@redhat.com wrote: >> >On Mon, 13 Aug 2012 17:27:00 +0200 >> >Jiri Pirko wrote: >> >> + /* >> >> + * To prevent loops, check if dev i

Re: [patch net-next 01/16] net: introduce upper device lists

2012-08-14 Thread Flavio Leitner
On Tue, 14 Aug 2012 14:24:33 +0200 Jiri Pirko wrote: > Mon, Aug 13, 2012 at 07:52:17PM CEST, f...@redhat.com wrote: > >On Mon, 13 Aug 2012 17:27:00 +0200 > >Jiri Pirko wrote: > >> + /* > >> + * To prevent loops, check if dev is not upper device to upper_dev. > >> + */ > >> + if (__netdev_h

Re: [patch net-next 01/16] net: introduce upper device lists

2012-08-14 Thread Jiri Pirko
Mon, Aug 13, 2012 at 07:52:17PM CEST, f...@redhat.com wrote: >On Mon, 13 Aug 2012 17:27:00 +0200 >Jiri Pirko wrote: > >> This lists are supposed to serve for storing pointers to all upper devices. >> Eventually it will replace dev->master pointer which is used for >> bonding, bridge, team but it c

Re: [patch net-next 01/16] net: introduce upper device lists

2012-08-14 Thread Jiri Pirko
Tue, Aug 14, 2012 at 11:02:33AM CEST, xiyou.wangc...@gmail.com wrote: >On 08/13/2012 11:27 PM, Jiri Pirko wrote: >>This lists are supposed to serve for storing pointers to all upper devices. >>Eventually it will replace dev->master pointer which is used for >>bonding, bridge, team but it cannot be

Re: [patch net-next 01/16] net: introduce upper device lists

2012-08-14 Thread Cong Wang
On 08/13/2012 11:27 PM, Jiri Pirko wrote: This lists are supposed to serve for storing pointers to all upper devices. Eventually it will replace dev->master pointer which is used for bonding, bridge, team but it cannot be used for vlan, macvlan where there might be multiple "masters" present. Ne

Re: [patch net-next 01/16] net: introduce upper device lists

2012-08-13 Thread Flavio Leitner
On Mon, 13 Aug 2012 17:27:00 +0200 Jiri Pirko wrote: > This lists are supposed to serve for storing pointers to all upper devices. > Eventually it will replace dev->master pointer which is used for > bonding, bridge, team but it cannot be used for vlan, macvlan where > there might be multiple "ma

Re: [patch net-next 01/16] net: introduce upper device lists

2012-08-13 Thread Jiri Pirko
Mon, Aug 13, 2012 at 07:04:11PM CEST, bhutchi...@solarflare.com wrote: >On Mon, 2012-08-13 at 17:27 +0200, Jiri Pirko wrote: >> This lists are supposed to serve for storing pointers to all upper devices. >> Eventually it will replace dev->master pointer which is used for >> bonding, bridge, team bu

Re: [patch net-next 01/16] net: introduce upper device lists

2012-08-13 Thread Ben Hutchings
On Mon, 2012-08-13 at 17:27 +0200, Jiri Pirko wrote: > This lists are supposed to serve for storing pointers to all upper devices. > Eventually it will replace dev->master pointer which is used for > bonding, bridge, team but it cannot be used for vlan, macvlan where > there might be multiple "mast

[patch net-next 01/16] net: introduce upper device lists

2012-08-13 Thread Jiri Pirko
This lists are supposed to serve for storing pointers to all upper devices. Eventually it will replace dev->master pointer which is used for bonding, bridge, team but it cannot be used for vlan, macvlan where there might be multiple "masters" present. New upper device list resolves this limitation