Re: [PATCH 08/9] ib/iser: move to use libiscsi passthrough mode

2010-02-04 Thread Mike Christie
On 02/04/2010 05:21 AM, Or Gerlitz wrote: [PATCH V2 08/9] ib/iser: move to use libiscsi passthrough mode The libiscsi passthrough mode invokes the transport xmit calls directly without first going through an internal queue as done in the other mode which uses a queue and a xmitworker thread. N

Re: [PATCH 08/9] ib/iser: move to use libiscsi passthrough mode

2010-02-04 Thread Or Gerlitz
Mike Christie wrote: > What prevents the problem this code was handling from coming up now? Are > you now preallocating enough resources, or are you returning > -ENOMEM/-ENOBUFS from the init_task/xmit_task callouts so the scsi layer > is now requeueing the IO? Basically before/after this change w

Re: [PATCH 08/9] ib/iser: move to use libiscsi passthrough mode

2010-02-03 Thread Mike Christie
On 02/03/2010 09:41 AM, Or Gerlitz wrote: @@ -526,17 +523,8 @@ void iser_snd_completion(struct iser_tx_ kmem_cache_free(ig.desc_cache, tx_desc); } - if (atomic_read(&iser_conn->ib_conn->post_send_buf_count) == - ISER_QP_MAX_REQ_DTOS) - resume