Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-07 Thread Lee Jones
On Wed, 08 May 2019, Marek Vasut wrote: > On 5/8/19 4:48 AM, masonccy...@mxic.com.tw wrote: > > Hi Jones, > > > >> "Lee Jones" > >> 2019/05/07 下午 08:58 > >> > >> To > >> > >> "Marek Vasut" , >

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-07 Thread Lee Jones
gt; > It supports both SPI NOR and HyperFlash (CFI-compliant flash with > different bus interface). Looks like you're registering one OR the other. Why don't you just do this from DT? No reason for this to be an MFD IMHO. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] mfd: bd9571mwv: add volatile register to make DVFS work

2018-11-13 Thread Lee Jones
ending on other registers. > > drivers/mfd/bd9571mwv.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] [trivial] mfd: tmio: Typo s/use use/use/

2018-11-08 Thread Lee Jones
On Wed, 07 Nov 2018, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > include/linux/mfd/tmio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM

Re: [PATCH V2] mfd: dt: Add bindings for DA9063L

2018-06-03 Thread Lee Jones
he chip > ID register. > > Signed-off-by: Marek Vasut > Cc: Geert Uytterhoeven > Cc: Lee Jones > Cc: Rob Herring > Cc: Steve Twiss > Cc: Wolfram Sang > Cc: linux-renesas-soc@vger.kernel.org > --- > V2: Merge the DA9063/DA9063L regulator lists and mark DA9

Re: [PATCH v6] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-05-16 Thread Lee Jones
't do anything clever with the different interrupts, it just calls > the same handler used for single interrupt hardware. > > Signed-off-by: Phil Edworthy > Reviewed-by: Rob Herring > Acked-by: Lee Jones > --- > One point to mention is that I hav

Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction

2018-04-24 Thread Lee Jones
On Tue, 24 Apr 2018, Geert Uytterhoeven wrote: > On Tue, Apr 24, 2018 at 10:41 AM, Simon Horman wrote: > > On Mon, Apr 16, 2018 at 10:12:57AM +0100, Lee Jones wrote: > >> On Wed, 11 Apr 2018, Simon Horman wrote: > >> > On Tue, Apr 10, 2018 at 02:32:40PM +0200, Wo

Re: [PATCH v3 0/4] regulator: bd9571mwv: Add support for DDR backup mode

2018-04-20 Thread Lee Jones
On Fri, 20 Apr 2018, Geert Uytterhoeven wrote: > On Fri, Apr 20, 2018 at 9:49 AM, Lee Jones wrote: > > On Wed, 18 Apr 2018, Geert Uytterhoeven wrote: > >> The ROHM BD9571MWV PMIC on the Renesas Salvator-X(S) and ULCB > >> development boards supports DDR Backup Powe

Re: [PATCH v3 0/4] regulator: bd9571mwv: Add support for DDR backup mode

2018-04-20 Thread Lee Jones
uld this set be applied together, or can the MFD patches be applied on their own, without the Regulator patch? If the former, then we're going to need an Ack from Mark. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v4] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-04-18 Thread Lee Jones
| 42 > +- > drivers/mfd/intel_quark_i2c_gpio.c | 3 +- If Linus, is happy with the GPIO implementation, then the changes in MFD look fine: Acked-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH RESEND] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction

2018-04-16 Thread Lee Jones
; > * early. Leave the decision of the initial backlight state for later. > > */ > > if (pb->enable_gpio && > > - gpiod_get_direction(pb->enable_gpio) != GPIOF_DIR_OUT) > > + gpiod_get_direction(pb->enable_gpio) != 0) > > gpiod_direction_output(pb->enable_gpio, 1); > > > > pb->power_supply = devm_regulator_get(&pdev->dev, "power"); -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 3/3] backlight: pwm_bl: don't use GPIOF_* with gpiod_get_direction

2018-04-16 Thread Lee Jones
until a better, system-wide solution is in place). > > Signed-off-by: Wolfram Sang > --- > Only build tested! > > drivers/video/backlight/pwm_bl.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied with Daniel and Simon's Acks. -- Lee Jones [李琼斯]

Re: [PATCH v2 1/4] dt-bindings: mfd: bd9571mwv: Document DDR Backup Mode properties

2018-03-27 Thread Lee Jones
es for power switch type. > --- > Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 21 > + > 1 file changed, 21 insertions(+) Once Rob's comment has been handled: For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead

Re: [PATCH v3 10/16] mmc: tmio: remove TMIO_MMC_WRPROTECT_DISABLE

2018-01-18 Thread Lee Jones
nux/mfd/tmio.h > @@ -36,7 +36,6 @@ > } while (0) > > /* tmio MMC platform flags */ > -#define TMIO_MMC_WRPROTECT_DISABLE BIT(0) If it is truly not in use after this set: Acked-by: Lee Jones -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH/RFC 1/5] dt-bindings: mfd: bd9571mwv: Document rohm,ddr-backup-power

2017-10-13 Thread Lee Jones
On Fri, 13 Oct 2017, Geert Uytterhoeven wrote: > Hi Lee, > > On Fri, Oct 13, 2017 at 10:55 AM, Lee Jones wrote: > > On Tue, 10 Oct 2017, Geert Uytterhoeven wrote: > >> Document the new optional "rohm,ddr-backup-power" property. > >

Re: [PATCH/RFC 3/5] mfd: bd9571mwv: Allow DDR Backup Power register access

2017-10-13 Thread Lee Jones
On Fri, 13 Oct 2017, Geert Uytterhoeven wrote: > Hi Lee, > > On Fri, Oct 13, 2017 at 10:58 AM, Lee Jones wrote: > > On Tue, 10 Oct 2017, Geert Uytterhoeven wrote: > > > >> Enable read/write access to the BD9571MWV_BKUP_MODE_CNT register, which > >> is

Re: [PATCH/RFC 3/5] mfd: bd9571mwv: Allow DDR Backup Power register access

2017-10-13 Thread Lee Jones
riptive and expanded (rather than shorten) terms. Code looks fine though, so once fixed: For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH/RFC 1/5] dt-bindings: mfd: bd9571mwv: Document rohm,ddr-backup-power

2017-10-13 Thread Lee Jones
-backup-power = <15>; Can you explain what this means? Is it a mask, or does line 15 need to be kept on? What is the range? Is 0 acceptable? Clarification required please. > regulators { > dvfs: dvfs { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH/RFC 2/5] mfd: bd9571mwv: Add DDR Backup Power register bit definitions

2017-10-13 Thread Lee Jones
/mfd/bd9571mwv.h | 5 + > 1 file changed, 5 insertions(+) Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] extcon: Split out extcon header file for consumer and provider device

2017-10-04 Thread Lee Jones
on device instance > : Register/unregister extcon device > : Set the state of each external connector > : Set the property value of each external connector > : Set the property capability of each external connector > > Cc: Felipe Balbi > Cc: Kishon Vijay Abraham I >

Re: [PATCH V3 1/2] mfd: Add ROHM BD9571MWV-M PMIC DT bindings

2017-08-15 Thread Lee Jones
st the VD09 regulator > V3: Replace bd9571@30 with pmic@30 > --- > .../devicetree/bindings/mfd/bd9571mwv.txt | 49 > ++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/bd9571mwv.txt Applied, thanks.

Re: [PATCH V4 2/2] mfd: Add ROHM BD9571MWV-M MFD PMIC driver

2017-07-18 Thread Lee Jones
el.org > Cc: Geert Uytterhoeven > Cc: Lee Jones > --- > V2: - Change BD9571MWV_AVS_VD09_VID0,1,2,3 to BD9571MWV_AVS_VD09_VID(n) > - Change BD9571MWV_AVS_DVFS_VID0,1,2,3 to BD9571MWV_AVS_DVFS_VID(n) > - Make the AVS_VD09 range RW, so it can be used by the regulator &

Re: [PATCH V3 2/2] mfd: Add ROHM BD9571MWV-M MFD PMIC driver

2017-07-03 Thread Lee Jones
On Mon, 03 Jul 2017, Marek Vasut wrote: > On 07/03/2017 03:48 PM, Lee Jones wrote: > > On Mon, 03 Jul 2017, Marek Vasut wrote: > > > >> On 07/03/2017 01:55 PM, Lee Jones wrote: > >>> On Tue, 27 Jun 2017, Marek Vasut wrote: > >>> > >>>

Re: [PATCH V3 2/2] mfd: Add ROHM BD9571MWV-M MFD PMIC driver

2017-07-03 Thread Lee Jones
On Mon, 03 Jul 2017, Marek Vasut wrote: > On 07/03/2017 01:55 PM, Lee Jones wrote: > > On Tue, 27 Jun 2017, Marek Vasut wrote: > > > >> On 05/02/2017 02:18 PM, Marek Vasut wrote: > >>> Add the MFD part of the ROHM BD9571MWV-M PMIC driver and MAINTAINERS >

Re: [PATCH V3 2/2] mfd: Add ROHM BD9571MWV-M MFD PMIC driver

2017-07-03 Thread Lee Jones
; > Signed-off-by: Marek Vasut > > Cc: linux-ker...@vger.kernel.org > > Cc: Geert Uytterhoeven > > Cc: Lee Jones > > Lee, bump, do you plan to apply these patches anytime soon ? Looks like these were missed for some reason. I'll put them back on the pile for re

Re: [PATCH 4/7] mmc: use proper name for the R-Car SoC

2017-05-30 Thread Lee Jones
lude/linux/mfd/tmio.h > > @@ -66,7 +66,7 @@ > > */ > > #define TMIO_MMC_SDIO_IRQ (1 << 2) > > > > -/* Some features are only available or tested on RCar Gen2 or later */ > > +/* Some features are only available or tested on R-Car Gen2 or later */ > > #define TMIO_MMC_MIN_RCAR2 (1 << 3) > > > > /* > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [RESEND][PATCH V2 3/4] gpio: Add ROHM BD9571MWV-M PMIC GPIO driver

2017-04-28 Thread Lee Jones
gt; > I applied this for v4.12 to bring down the number of deps in > v4.13. The guarding symbol makes it not compile until the MFD > patch is there, the MFD_BD9571MWV is unlikely to change, > and Marek will certainly go through with the driver submission. Works for me. -- Lee Jones Lin

Re: [PATCH V2 3/4] gpio: Add ROHM BD9571MWV-M PMIC GPIO driver

2017-04-26 Thread Lee Jones
On Tue, 25 Apr 2017, Marek Vasut wrote: > On 04/25/2017 04:01 PM, Lee Jones wrote: > > On Tue, 25 Apr 2017, Marek Vasut wrote: > > > >> On 04/25/2017 02:21 PM, Lee Jones wrote: > >>> On Tue, 25 Apr 2017, Marek Vasut wrote: > >>> > >>>&

Re: [RESEND][PATCH V2 4/4] regulator: Add ROHM BD9571MWV-M PMIC regulator driver

2017-04-26 Thread Lee Jones
which have already been applied 2. Apply all Acks you have collected to the patches 3. Resend only the ones you wish applied, not forgetting to Cc me > [1] > https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg13599.html -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH V2 3/4] gpio: Add ROHM BD9571MWV-M PMIC GPIO driver

2017-04-25 Thread Lee Jones
On Tue, 25 Apr 2017, Marek Vasut wrote: > On 04/25/2017 02:21 PM, Lee Jones wrote: > > On Tue, 25 Apr 2017, Marek Vasut wrote: > > > >> On 04/25/2017 11:32 AM, Linus Walleij wrote: > >>> On Mon, Apr 24, 2017 at 5:21 PM, Marek Vasut > >>> wrote: &

Re: [PATCH V2 3/4] gpio: Add ROHM BD9571MWV-M PMIC GPIO driver

2017-04-25 Thread Lee Jones
> this went through one tree. Because your mailer is broken, I know have no idea which thread this mail belongs to. Please fix your mailer to reply 'threaded'. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 2/4] mfd: Add ROHM BD9571MWV-M MFD PMIC driver

2017-04-24 Thread Lee Jones
el.org > Cc: Geert Uytterhoeven > Cc: Lee Jones > --- > MAINTAINERS | 11 ++ > drivers/mfd/Kconfig | 13 +++ > drivers/mfd/Makefile | 1 + > drivers/mfd/bd9571mwv.c | 226 > +++

Re: [PATCH] backlight: pwm_bl: Fix GPIO out for unimplemented .get_direction()

2017-03-27 Thread Lee Jones
et the GPIO as active. > > > * Do not force the GPIO to active when it was already output as it > > > * could cause backlight flickering or we would enable the > > > backlight too > > > * early. Leave the decision of the initial backlight state for >