Re: [PATCH v2 1/2] i2c-core: dt: Pick i2c bus number from i2c alias if present

2013-01-14 Thread Olof Johansson
On Mon, Jan 14, 2013 at 10:53:21AM -0800, Doug Anderson wrote: > This allows you to get the equivalent functionality of > i2c_add_numbered_adapter() with all data in the device tree and no > special case code in your driver. This is a common device tree > technique. > > For quick reference, the F

Re: [PATCH v4 5/5] mmc: dw_mmc: Remove DW_MCI_QUIRK_NO_WRITE_PROTECT

2013-01-14 Thread Olof Johansson
On Fri, Jan 11, 2013 at 09:03:54AM -0800, Doug Anderson wrote: > The original quirk was added in the change 'mmc: dw_mmc: add quirk to > indicate missing write protect line'. The original quirk was added at > a controller level even though each slot has its own write protect (so > the quirk should

Re: [PATCH v4 4/5] mmc: dw_mmc: Handle wp-gpios from device tree

2013-01-14 Thread Olof Johansson
On Fri, Jan 11, 2013 at 09:03:53AM -0800, Doug Anderson wrote: > On some SoCs (like exynos5250) you need to use an external GPIO for > write protect. Add support for wp-gpios to the core dw_mmc driver > since it could be useful across multiple SoCs. > > With this change I am able to make use of t

Re: [PATCH v4 2/5] ARM: dts: Add disable-wp for sd card slot on smdk5250

2013-01-14 Thread Olof Johansson
On Fri, Jan 11, 2013 at 09:03:51AM -0800, Doug Anderson wrote: > The next change will remove the code from the dw_mmc-exynos that added > the DW_MCI_QUIRK_NO_WRITE_PROTECT. Keep existing functionality of > having no write protect pin on smdk5250 by adding the disable-wp > property. > > Signed-off

Re: [PATCH v4 3/5] mmc: dw_mmc: exynos: Remove code for wp-gpios

2013-01-14 Thread Olof Johansson
On Fri, Jan 11, 2013 at 09:03:52AM -0800, Doug Anderson wrote: > The exynos code claimed the write protect with devm_gpio_request() but > never did anything with it. That meant that anyone using a write > protect GPIO would effectively be write protected all the time. > > The handling for wp-gpio

Re: [PATCH v3] i2c: exynos5: add High Speed I2C controller driver

2013-01-14 Thread Naveen Krishna Ch
On 28 December 2012 22:06, Naveen Krishna Ch wrote: > On 28 December 2012 16:57, Naveen Krishna Chatradhi > wrote: >> Adds support for High Speed I2C driver found in Exynos5 and later >> SoCs from Samsung. This driver currently supports Auto mode. >> >> Driver only supports Device Tree method of

Re: [PATCH v4 1/5] mmc: dw_mmc: Add "disable-wp" device tree property

2013-01-14 Thread Olof Johansson
On Fri, Jan 11, 2013 at 09:03:50AM -0800, Doug Anderson wrote: > The "disable-wp" property is used to specify that a given SD card slot > doesn't have a concept of write protect. This eliminates the need for > special case code for SD slots that should never be write protected > (like a micro SD s

[PATCH v7] usb: phy: samsung: Add support to set pmu isolation

2013-01-14 Thread Vivek Gautam
Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam Reviewed-by: Sylwester Nawrocki Reviewed-by: Doug Anderson --- Changes from v6: - Returning error code in samsung_usbphy_parse_dt() when 'usbphy-sys' s

Re: [PATCH] usb: phy: samsung: Add support to set pmu isolation

2013-01-14 Thread Vivek Gautam
Hi Doug, On Tue, Jan 15, 2013 at 3:41 AM, Doug Anderson wrote: > Vivek, > > Sorry for being so absent from these reviews. I'll try to look over a > few patches today, but please don't hold up anything on account of my > reviews. I'm definitely a bit of an interested bystander in USB land. > ;

Re: [PATCH] ARM: EXYNOS: Remove wrong I2S0 clock from peril clock

2013-01-14 Thread Tushar Behera
On 09/28/2012 04:09 PM, Sangsu Park wrote: > Remove I2S0 clock from peril since peril doesn't have I2S0 clock for EXYNOS4. > Audio Subsystem block has I2S0 clk. > > Signed-off-by: sangsu > --- > arch/arm/mach-exynos/clock-exynos4.c |5 - > 1 file changed, 5 deletions(-) > > diff --git a

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-14 Thread Doug Anderson
Vivek, On Mon, Jan 14, 2013 at 12:06 AM, Vivek Gautam wrote: >> Is it fine if we don't use macro for SHIFT, earlier code also doesn't use it. >> Can we just do like this .. >> #define HOST_CTRL0_FSEL_MASK (0x7 << 16) >> #define HOST_CTRL0_FSEL_CLKSEL_50M(0x7 <<

Re: Audio support on Mini6410 board

2013-01-14 Thread Sylwester Nawrocki
Hi, Cc: Kukjin Kim, the maintainer of Samsung ARM sub-arch On 01/12/2013 06:07 PM, Alexander Nestorov wrote: Hi, it's finally working! :) Great news! ;) I guess you now have all required features working with latest mainline kernel ? Is there anything still missing ? This is my entire diff

Re: [PATCH] usb: phy: samsung: Add support to set pmu isolation

2013-01-14 Thread Doug Anderson
Vivek, Sorry for being so absent from these reviews. I'll try to look over a few patches today, but please don't hold up anything on account of my reviews. I'm definitely a bit of an interested bystander in USB land. ;) In general things look pretty good here. :) One last comment below... O

Re: Early kernel hang with big DTB appended

2013-01-14 Thread Nicolas Pitre
On Fri, 11 Jan 2013, Sascha Hauer wrote: > On Thu, Jan 03, 2013 at 04:55:00PM +0100, Tomasz Figa wrote: > > Hi, > > > > I'm observing strange behavior when booting 3.8-rc1 and -rc2 with appended > > DTB. The kernel hangs very early when the DTB is bigger than some > > threshold somewhere around

[PATCH v2 1/2] i2c-core: dt: Pick i2c bus number from i2c alias if present

2013-01-14 Thread Doug Anderson
This allows you to get the equivalent functionality of i2c_add_numbered_adapter() with all data in the device tree and no special case code in your driver. This is a common device tree technique. For quick reference, the FDT syntax for using an alias to provide an ID looks like: aliases { i

[PATCH v2 2/2] i2c: pxa: Use i2c-core to get bus number now

2013-01-14 Thread Doug Anderson
The commit: "i2c-core: dt: Pick i2c bus number from i2c alias if present" adds support for automatically picking the bus number based on the alias ID. Remove the now unnecessary code from i2c-pxa that did the same thing. Signed-off-by: Doug Anderson --- Changes in v2: - No longer tweak pdev->id

[PATCH v2 0/2] Add automatic bus number support for i2c busses with device tree

2013-01-14 Thread Doug Anderson
This was suggested by Mark Brown in response to a patch for adding this functionality only for the s3c2410 bus: https://lkml.org/lkml/2012/11/20/681 I have also modified the i2c-pxa driver to use this new functionality. Changes in v2: - No longer tweak pdev->id as per Sylwester Nawrocki. - No l

Re: [REPOST PATCH 2/2] i2c: pxa: Use i2c-core to get bus number now

2013-01-14 Thread Doug Anderson
Sylwester, Thanks for the review... On Fri, Jan 11, 2013 at 2:12 PM, Sylwester Nawrocki wrote: >> - ret = of_alias_get_id(np, "i2c"); >> - if (ret< 0) { >> - dev_err(&pdev->dev, "failed to get alias id, errno %d\n", >> ret); >> - return ret; >> - }

[PATCH] arm: mach-s3c24xx/common.c: fix uninitialized variable warning

2013-01-14 Thread Cong Ding
the use of variable tmp is uninitialized, so we fix it. Signed-off-by: Cong Ding --- arch/arm/mach-s3c24xx/common.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-s3c24xx/common.c b/arch/arm/mach-s3c24xx/common.c index 0c9e9a7..6bcf87f 100644 --- a/arch/arm/

Re: [PATCH v4 5/5] mmc: dw_mmc: Remove DW_MCI_QUIRK_NO_WRITE_PROTECT

2013-01-14 Thread Doug Anderson
Will, On Mon, Jan 14, 2013 at 2:47 AM, Will Newton wrote: > These changes look ok to me. I don't know if patch 4 made it to the > list, I only got a copy via the cc and the only archive I can find of > linux-mmc (gmane) seems to be missing a lot of messages besides this > one. It seems to have m

Re: [PATCH 5/6] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs

2013-01-14 Thread Lorenzo Pieralisi
On Mon, Jan 14, 2013 at 02:48:41PM +, Mark Rutland wrote: > Hello, > > This all looks good. I just have a couple of comments about the cpus node. > > On Sun, Jan 13, 2013 at 01:10:57AM +, Tomasz Figa wrote: > > This patch adds basic device tree definitions for Samsung S3C64xx SoCs. > > >

Re: [PATCH 5/6] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs

2013-01-14 Thread Mark Rutland
Hello, This all looks good. I just have a couple of comments about the cpus node. On Sun, Jan 13, 2013 at 01:10:57AM +, Tomasz Figa wrote: > This patch adds basic device tree definitions for Samsung S3C64xx SoCs. > > Since all the SoCs in the series are very similar, the files are created >

[PATCH v3 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-01-14 Thread Vivek Gautam
Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam --- drivers/usb/phy/Kconfig |8 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/samsung-usb3.c | 349 ++ drivers/usb/phy/samsung-usbph

[PATCH v3 1/2] usb: phy: samsung: Common out the generic stuff

2013-01-14 Thread Vivek Gautam
Moving register and structure definitions to header file, and keeping the generic functions to be used across multiple PHYs in common file "samsung-usbphy.c". Also renaming the usb 2.0 phy driver to "samsung-usb2.c" Signed-off-by: Vivek Gautam --- drivers/usb/phy/Makefile |2 +- driv

[PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-01-14 Thread Vivek Gautam
Changes from v2: - Renaming 'samsung-usbphy.c' driver to 'samsung-usb2.c' indicating usb 2.0 phy controller's driver for Samsung's SoCs. - Moving the register definitions and strcuture definitions to common header file 'samsung-usbphy.h' to be used across usb 2.0 and usb 3.0 phy. - Keep

[PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-14 Thread Vivek Gautam
This patch adds host phy support to samsung-usbphy driver and further adds support for samsung's exynos5250 usb-phy. Signed-off-by: Praveen Paneri Signed-off-by: Vivek Gautam --- Changes from v6: - Changing macro names from 'HOST_CTRL0_FSEL_CLKSEL_XX' to 'FSEL_CLKSEL_XX' since it's being us

Re: [PATCH v4 5/5] mmc: dw_mmc: Remove DW_MCI_QUIRK_NO_WRITE_PROTECT

2013-01-14 Thread Will Newton
On Fri, Jan 11, 2013 at 5:03 PM, Doug Anderson wrote: > The original quirk was added in the change 'mmc: dw_mmc: add quirk to > indicate missing write protect line'. The original quirk was added at > a controller level even though each slot has its own write protect (so > the quirk should be at t

Re: [PATCH 1/6] ARM: common: vic: Parse interrupt and resume masks from device tree

2013-01-14 Thread Tomasz Figa
Hi Rob, 2013/1/14 Rob Herring : > On 01/12/2013 07:10 PM, Tomasz Figa wrote: >> This patch extends vic_of_init to parse valid interrupt sources >> and resume sources masks from device tree. >> >> If mask values are not specified in device tree, all sources >> are assumed to be valid, as before thi

$(make uImage) is stupid [Was: Re: Early kernel hang with big DTB appended]

2013-01-14 Thread Uwe Kleine-König
Hello, unrelated to the original problem ... On Fri, Jan 04, 2013 at 11:18:56AM +0100, Tomasz Figa wrote: > We are using uImages built with same parameters as those used in simple > 'make uImage', just with a DTB appended to zImage before running mkimage > on it. note that the parameters used f

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-14 Thread Vivek Gautam
Hi Doug, On Mon, Jan 14, 2013 at 11:15 AM, Vivek Gautam wrote: > Hi Doug, > > > On Sat, Jan 12, 2013 at 6:20 AM, Doug Anderson wrote: >> Vivek, >> >> On Fri, Jan 11, 2013 at 4:40 AM, Vivek Gautam >> wrote: > +#define HOST_CTRL0_REFCLKSEL_MASK (0x3) > +#define HOST_CTRL0_R