Re: [PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype

2015-06-08 Thread Jon Hunter
Hi Boris, On 05/06/15 12:39, Boris Brezillon wrote: > Hi Jon, > > On Fri, 5 Jun 2015 09:46:09 +0100 > Jon Hunter wrote: > >> >> On 05/06/15 00:02, Paul Walmsley wrote: >>> Hi folks >>> >>> just a brief comment on this one: >>>

Re: [PATCH v2 1/2] clk: change clk_ops' ->round_rate() prototype

2015-06-05 Thread Jon Hunter
On 05/06/15 00:02, Paul Walmsley wrote: > Hi folks > > just a brief comment on this one: > > On Thu, 30 Apr 2015, Boris Brezillon wrote: > >> Clock rates are stored in an unsigned long field, but ->round_rate() >> (which returns a rounded rate from a requested one) returns a long >> value (erro

Re: [PATCH 2/4] DMA: PL330: Register the DMA controller with the generic DMA helpers

2013-01-28 Thread Jon Hunter
On 01/28/2013 12:01 PM, Arnd Bergmann wrote: > On Monday 28 January 2013, Jon Hunter wrote: >> On 01/28/2013 08:51 AM, Arnd Bergmann wrote: >>> On Friday 18 January 2013, Padmavathi Venna wrote: >>>> + pfi = devm_kzalloc(&adev->dev, sizeof(*pfi

Re: [PATCH 2/4] DMA: PL330: Register the DMA controller with the generic DMA helpers

2013-01-28 Thread Jon Hunter
On 01/28/2013 08:51 AM, Arnd Bergmann wrote: > On Friday 18 January 2013, Padmavathi Venna wrote: >> + pfi = devm_kzalloc(&adev->dev, sizeof(*pfi), GFP_KERNEL); >> + if (!pfi) { >> + dev_err(&adev->dev, "unable to allocate mem\n"); >> + return -ENOMEM; >> +