Re: [rtc-linux] Re: [PATCH 1/2] drivers/rtc/rtc-s3c.c: Integrate Exynos3250 into S3C6410

2015-03-31 Thread Krzysztof Kozlowski
2015-03-31 10:20 GMT+02:00 Alexandre Belloni : > Hi, > > On 31/03/2015 at 08:49:39 +0200, Javier Martinez Canillas wrote : >> Hello Alexandre, >> >> On Tue, Mar 31, 2015 at 2:27 AM, Alexandre Belloni >> wrote: >> > nitpick: I would prefer rtc: rtc-s3c instead of drivers/rtc/rtc-s3c.c >> > >> >> Ye

Re: [PATCH 1/2] drivers/rtc/rtc-s3c.c: Integrate Exynos3250 into S3C6410

2015-03-31 Thread Alexandre Belloni
Hi, On 31/03/2015 at 08:49:39 +0200, Javier Martinez Canillas wrote : > Hello Alexandre, > > On Tue, Mar 31, 2015 at 2:27 AM, Alexandre Belloni > wrote: > > nitpick: I would prefer rtc: rtc-s3c instead of drivers/rtc/rtc-s3c.c > > > > Yes but Krzysztof is following the convention used in driver

Re: [PATCH 1/2] drivers/rtc/rtc-s3c.c: Integrate Exynos3250 into S3C6410

2015-03-30 Thread Javier Martinez Canillas
Hello Alexandre, On Tue, Mar 31, 2015 at 2:27 AM, Alexandre Belloni wrote: > nitpick: I would prefer rtc: rtc-s3c instead of drivers/rtc/rtc-s3c.c > Yes but Krzysztof is following the convention used in drivers/rtc/ which I think is the correct thing to do even when it's different from what is u

Re: [PATCH 1/2] drivers/rtc/rtc-s3c.c: Integrate Exynos3250 into S3C6410

2015-03-30 Thread Alexandre Belloni
nitpick: I would prefer rtc: rtc-s3c instead of drivers/rtc/rtc-s3c.c On 30/03/2015 at 17:19:32 +0200, Krzysztof Kozlowski wrote : > There are now no differences between RTC on Exynos3250 and S3C6410. > Merge everything into one so duplicated code could be removed. > > Signed-off-by: Krzysztof Ko

Re: [PATCH 1/2] drivers/rtc/rtc-s3c.c: Integrate Exynos3250 into S3C6410

2015-03-30 Thread Chanwoo Choi
On 03/31/2015 12:19 AM, Krzysztof Kozlowski wrote: > There are now no differences between RTC on Exynos3250 and S3C6410. > Merge everything into one so duplicated code could be removed. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/rtc/rtc-s3c.c | 14 +- > 1 file changed, 1

[PATCH 1/2] drivers/rtc/rtc-s3c.c: Integrate Exynos3250 into S3C6410

2015-03-30 Thread Krzysztof Kozlowski
There are now no differences between RTC on Exynos3250 and S3C6410. Merge everything into one so duplicated code could be removed. Signed-off-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s3c.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c