On Wed, Oct 10, 2018 at 09:58:25PM -0400, Martin K. Petersen wrote:
> > This is because the IPTT index must be a unique value per HBA. However,
> > if we switched to SCSI MQ, the block layer tag becomes unique per queue,
> > and not per HBA.
>
> That doesn't sound right.
blk-mq tags are always pe
Hello MNC & Co,
On Wed, 2018-10-10 at 11:58 -0500, Mike Christie wrote:
> On 10/09/2018 10:23 PM, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger
> >
> > With the addition of commit 00d909a107 in v4.19-rc, it incorrectly assumes
> > no
> > signals will be pending for task_struct execu
Hey Peter & Co,
On Wed, 2018-10-10 at 10:43 +0200, Peter Zijlstra wrote:
> On Wed, Oct 10, 2018 at 03:23:10AM +, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger
> >
> > With the addition of commit 00d909a107 in v4.19-rc, it incorrectly assumes
> > no
> > signals will be pending fo
Avri,
> Here is a proposal to use a bsg endpoint to manage ufs devices.
>
> We will do that by adding a bsg device node to the ufs driver, and use
> it to send UPIU transactions to the ufs device. It will serve as a
> ufs device management infrastructure, for device configuration,
> provisionin
Colin,
> There are extraneous parantheses that are causing clang to produce a
> warning so remove these.
>
> Clean up 3 clang warnings:
> equality comparison with extraneous parentheses [-Wparentheses-equality]
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engine
Bart,
> If you have a look at the URL in my previous e-mail you will see that
> patch 3/3 didn't make it to marc.info either.
Also missing in patchwork (although I received my personal copy).
Hannes, please resend.
--
Martin K. Petersen Oracle Linux Engineering
Hi Gustavo,
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
I'm not entirely convinced that all these identified fall through cases
are intentional. From a quick glance, some of them look like bugs...
> diff --git a/drivers/scsi/
Lance,
> lockdep_assert_held() is better suited to checking locking
> requirements, since it won't get confused when someone else holds the
> lock. This is also a step towards possibly removing spin_is_locked().
Applied to 4.20/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux En
Nathan,
>> The exact same code also exists in drivers/scsi/mpt3sas/. I had a similar
>> patch for both drivers, but saw that yours now got merged for fusion.
>>
>> If you don't mind, could you fix mpt3sas_base.c the same way?
>>
>> Arnd
>
> Hi Arnd,
>
> I did sent a patch for this a littl
Suganath,
> Please consider this patch as Acked-by: Suganath Prabu
>
Next time, please make sure to put
Acked-by: Suganath Prabu
on a line by itself. Otherwise patchwork won't pick up the tag.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Souptick,
> Replaced dma_pool_alloc + memset with dma_pool_zalloc.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Matthew,
> The uapi header file listed in the cxlflash stanza has a typo.
>
> Removed the trailing 's' from the filename.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
John,
> However it does block us in future from enabling SCSI MQ in the driver.
We're going to remove the legacy I/O path so I'm not particularly keen
on merging something that's going in the opposite direction.
> This is because the IPTT index must be a unique value per HBA. However,
> if we
Joe,
> Several defects exist in the logging uses
>
> o Missing KERN_
> o Unnecessary KERN_ uses with panic
> o Mismatched MPT3SAS_FMT and %s: with name and __func__
>
> Correct these defects and perhaps add some clarity to the logging.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen
On Wed, 10 Oct 2018, Christoph Hellwig wrote:
> esp->dev is a void pointer that points either to a struct device, or a
> struct platform_device. As we can easily get from the device to the
> platform_device if needed change it to always point to a struct device
> and properly type the pointer to
Hi Damien,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on block/for-next]
[also build test ERROR on v4.19-rc7 next-20181010]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci
--
Hello dear! I sincerely hope i do not bother you with my message.I know
this might look strange because we don't know each other but i believe
anything is possible if we try. I have actually lost confidence on
dating sites and due to the nature of my work its not easy to find
someone so
On 10/09/2018 10:23 PM, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger
>
> With the addition of commit 00d909a107 in v4.19-rc, it incorrectly assumes no
> signals will be pending for task_struct executing the normal session shutdown
> and I/O quiesce code-path.
>
> For example, iscsi-ta
On Wed, 2018-10-10 at 10:52 +0900, Damien Le Moal wrote:
> #define BLKREPORTZONE_IOWR(0x12, 130, struct blk_zone_report)
> #define BLKRESETZONE _IOW(0x12, 131, struct blk_zone_range)
> +#define BLKGETZONESZ _IOW(0x12, 132, unsigned int)
>From Documentation/ioctl/botching-up-ioctls.txt, a
Hi Christoph,
I love your patch! Yet something to improve:
[auto build test ERROR on block/for-next]
[also build test ERROR on v4.19-rc7]
[cannot apply to next-20181010]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https
On Wed, Oct 10 2018 at 10:15am -0400,
Mike Snitzer wrote:
> On Tue, Oct 09 2018 at 9:52pm -0400,
> Damien Le Moal wrote:
>
> > From: Christoph Hellwig
> >
> > Dispatching a report zones command through the request queue is a major
> > pain due to the command reply payload rewriting necessary
esp->dev is a void pointer that points either to a struct device, or a
struct platform_device. As we can easily get from the device to the
platform_device if needed change it to always point to a struct device
and properly type the pointer to avoid errors.
Signed-off-by: Christoph Hellwig
---
d
esp_sbus_map_command_block is called straight from the probe routine
without any locks held, so we can safely use GFP_KERNEL here.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/sun_esp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/sun_esp.c b/drivers/scsi
Remove usage of the legacy PCI DMA API. To make this easier we also
store a struct device instead of pci_dev in the dev field of struct
esp.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/am53c974.c | 32 +++-
1 file changed, 15 insertions(+), 17 deletions(-)
dif
Except for the mac_esp driver, which uses PIO or pseudo DMA, all drivers
share the same dma mapping calls. Move the dma mapping into the core
code using the scsi_dma_map / scsi_dma_unmap helpers, with a special
identify mapping variant triggered off a new ESP_FLAG_NO_DMA_MAP flag
for mac_esp.
Sig
Mostly to avoid methods calls for dma mapping, but also to tidy up
a few bits found while doing that.
On Tue, Oct 09 2018 at 9:52pm -0400,
Damien Le Moal wrote:
> From: Christoph Hellwig
>
> Dispatching a report zones command through the request queue is a major
> pain due to the command reply payload rewriting necessary. Given that
> blkdev_report_zones() is executing everything synchronously
On Wed, 2018-10-10 at 16:55 +0200, Michal Soltys wrote:
> Hi,
>
> I have a server with old server with lsi2308 ("it" mode) and sas2x36
> expander in front. I've been testing how it handles ssd drives (among
> those if/how it copes with unmap). And it looks like
> stomped on a bug (it's 100% reprod
Hi,
I have a server with old server with lsi2308 ("it" mode) and sas2x36 expander
in front. I've been testing how it handles ssd drives (among those if/how it
copes with unmap). And it looks like
stomped on a bug (it's 100% reproducible in 4.14.74 and 4.18.12).
The hardware in question:
mpt2sa
Hi Christoph,
I love your patch! Yet something to improve:
[auto build test ERROR on block/for-next]
[also build test ERROR on v4.19-rc7]
[cannot apply to next-20181010]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https
On Tue, Oct 09 2018 at 9:52pm -0400,
Damien Le Moal wrote:
> From: Christoph Hellwig
>
> Dispatching a report zones command through the request queue is a major
> pain due to the command reply payload rewriting necessary. Given that
> blkdev_report_zones() is executing everything synchronously
Hi Damien,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on block/for-next]
[also build test ERROR on v4.19-rc7 next-20181010]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci
On 10/9/18 10:49 PM, Hannes Reinecke wrote:
On 10/10/18 4:03 AM, Bart Van Assche wrote:
On 10/9/18 8:26 AM, Hannes Reinecke wrote:
as we're trying to get rid of the remaining request_fn drivers here's
a patchset to move the DAC960 driver to the SCSI stack.
As per request from hch I've split up
Hi Doug,
Really thank you for your review.
On 2018-10-10 05:56, Doug Anderson wrote:
Hi,
On Sun, Oct 7, 2018 at 9:34 PM Can Guo wrote:
From: Venkat Gopalakrishnan
The UFS Tx lane1 clock could be muxed, hence keep it optional by
ignoring
it if it is not provided in device tree.
Thanks
> +static inline unsigned long *__alloc_zone_bitmap(int node,
> + unsigned int nr_zones)
> +{
> + return kcalloc_node(BITS_TO_LONGS(nr_zones), sizeof(unsigned long),
> + GFP_NOIO | __GFP_ZERO, node);
kcalloc already implies G
On Wed, Oct 10, 2018 at 10:52:37AM +0900, Damien Le Moal wrote:
> Expose through sysfs the nr_zones field of a zoned block device request
> queue. This represents the total number of zones of the device
> calculated using the known disk capacity and zone size.
>
> Exposing this value helps in debu
Looks good,
Reviewed-by: Christoph Hellwig
On Wed, Oct 10, 2018 at 10:52:34AM +0900, Damien Le Moal wrote:
> Get a zoned block device zone size in number of 512 B sectors.
> The zone size is always 0 for regular block devices.
Looks good,
Reviewed-by: Christoph Hellwig
On Wed, Oct 10, 2018 at 10:52:35AM +0900, Damien Le Moal wrote:
> Get a zoned block device total number of zones. The device can be a
> partition of the whole device. The number of zones is always 0 for
> regular block devices.
Looks good,
Reviewed-by: Christoph Hellwig
> + unsigned int nr_zones;
> int ret;
>
> if (!argp)
> @@ -355,8 +356,9 @@ int blkdev_report_zones_ioctl(struct block_device *bdev,
> fmode_t mode,
> if (!rep.nr_zones)
> return -EINVAL;
>
> - if (rep.nr_zones > INT_MAX / sizeof(struct blk_zone))
> -
On Wed, Oct 10, 2018 at 10:52:32AM +0900, Damien Le Moal wrote:
> Introduce the blkdev_nr_zones() helper function to get the total
> number of zones of a zoned block device. This number is always 0 for a
> regular block device (q->limits.zoned == BLK_ZONED_NONE case).
>
> Replace hard-coded number
Looks good,
Reviewed-by: Christoph Hellwig
Looks good,
Reviewed-by: Christoph Hellwig
On Wed, Oct 10, 2018 at 10:52:29AM +0900, Damien Le Moal wrote:
> Move the urswrz check out of sd_zbc_read_zones() and into
> sd_zbc_read_zoned_characteristics() where that value is obtained (read
> from the disk zoned characteristics VPD page). Since this function now
> does more than simply readi
> +static void myrb_monitor(struct work_struct *work);
> +static inline void DAC960_P_To_PD_TranslateDeviceState(void *DeviceState);
Can you please use normal kernel function names and a normal prefix?
Also there seems to be no good reason to need a forward declaration for
this function.
> +stat
On Wed, Oct 10, 2018 at 03:23:10AM +, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger
>
> With the addition of commit 00d909a107 in v4.19-rc, it incorrectly assumes no
> signals will be pending for task_struct executing the normal session shutdown
> and I/O quiesce code-path.
>
> For
On Wed, Oct 10, 2018 at 03:23:09AM +, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger
>
> Short of reverting commit 00d909a107 for v4.19, target-core needs a
> wait_event_t marco can be executed using TASK_UNINTERRUPTIBLE to
> function correctly with existing fabric drivers that expec
47 matches
Mail list logo
