Looks fine (modulo the potentional Kconfig tweak mentioned for the
previous patch):
Reviewed-by: Christoph Hellwig
> +/* FIFO_COUNT: The host adapter has an 8K cache (host adapters based on the
> + * 18C30 chip have a 2k cache). When this many 512 byte blocks are filled by
> + * the SCSI device, an interrupt will be raised. Therefore, this could be as
> + * low as 0, or as high as 16. Note, however, that val
On Tue, Apr 23, 2019 at 06:32:40PM +0800, Ming Lei wrote:
> big, the whole pre-allocation for sg list can consume huge memory.
> For example of lpfc, nr_hw_queues can be 70, each queue's depth
> can be 3781, so the pre-allocation for data sg list can be 70*3781*2k
> =517MB for single HBA.
We shoul
On 4/24/19 3:45 AM, Ming Lei wrote:
On Wed, Apr 24, 2019 at 09:12:42AM +0800, Ming Lei wrote:
On Tue, Apr 23, 2019 at 04:07:49PM +0200, Hannes Reinecke wrote:
On 4/23/19 3:30 PM, Ming Lei wrote:
Hi Hannes,
Thanks for your response.
On Tue, Apr 23, 2019 at 01:19:33PM +0200, Hannes Reinecke wr
If the user writes 0 to enforce_discovery_auth to disable CHAP during
discovery we will set the AuthMethod arguments to CHAP,None even if
there are no CHAP settings. The initiator can then only login if it has
its AuthMethod set to only None. If it is set to CHAP,None, login will
fail, because the
On Wed, Apr 24, 2019 at 09:12:42AM +0800, Ming Lei wrote:
> On Tue, Apr 23, 2019 at 04:07:49PM +0200, Hannes Reinecke wrote:
> > On 4/23/19 3:30 PM, Ming Lei wrote:
> > > Hi Hannes,
> > >
> > > Thanks for your response.
> > >
> > > On Tue, Apr 23, 2019 at 01:19:33PM +0200, Hannes Reinecke wrote:
On 22/4/19 11:27 pm, Mauro Carvalho Chehab wrote:
Convert docs to ReST and add them to the arch-specific
book.
The conversion here was trivial, as almost every file there
was already using an elegant format close to ReST standard.
The changes were mostly to mark literal blocks and add a few
mis
On Tue, Apr 23, 2019 at 04:07:49PM +0200, Hannes Reinecke wrote:
> On 4/23/19 3:30 PM, Ming Lei wrote:
> > Hi Hannes,
> >
> > Thanks for your response.
> >
> > On Tue, Apr 23, 2019 at 01:19:33PM +0200, Hannes Reinecke wrote:
> > > On 4/22/19 5:30 AM, Ming Lei wrote:
> [ .. ]
> > > >
> > > > Hi H
On Tue, Apr 23, 2019 at 08:33:47AM -0700, Bart Van Assche wrote:
> On Tue, 2019-04-23 at 18:32 +0800, Ming Lei wrote:
> > +/*
> > + * Size of integrity meta data size is usually small, 1 inline sg
> ^^
> Please change this into "metadata". Mentioning "size" twice
Hi Martin,
These patches fix small issue where device stays in blocked
state due to driver not marking port offline and moving
debug message to correct verbose level.
Please apply to 5.2/scsi-queue branch for inclusion at your
earliest convenience.
Thanks,
Himanshu
Himanshu Madhani (1):
q
ELS IOCB done message should be moved to verbose logging
to prevent confusion about the error case v/s sucessful
submission case.
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_isr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_isr.c
From: Quinn Tran
This patch fixes issue reported by some of the customers,
who discovered that after cable pull scenario the devices
disappear and path seems to remain in blocked state. Once
the device reappears, driver does not seem to update path
to online. This issue appears because of the def
https://bugzilla.kernel.org/show_bug.cgi?id=199435
--- Comment #32 from Don (don.br...@microsemi.com) ---
Created attachment 282479
--> https://bugzilla.kernel.org/attachment.cgi?id=282479&action=edit
Patch to correct resets
hpsa: correct device resets
- Correct a race condition that o
On Tue, 2019-04-23 at 18:32 +0800, Ming Lei wrote:
> #define SCSI_INLINE_PROT_SG_CNT 1
>
> +#define SCSI_INLINE_SG_CNT 2
So this patch inserts one kmalloc() and one kfree() call in the hot path
for every SCSI request with more than two elements in its scatterlist? Isn't
"2" too low? Or in o
On Tue, 2019-04-23 at 18:32 +0800, Ming Lei wrote:
> +/*
> + * Size of integrity meta data size is usually small, 1 inline sg
^^
Please change this into "metadata". Mentioning "size" twice is not
useful.
> + * should cover normal cases.
> + */
> +#define SCSI_IN
From: YueHaibing
Fixes gcc '-Wunused-but-set-variable' warnings:
drivers/scsi/qedf/qedf_els.c: In function 'qedf_process_els_compl':
drivers/scsi/qedf/qedf_els.c:149:20: warning: variable 'sc_cmd' set but not
used [-Wunused-but-set-variable]
drivers/scsi/qedf/qedf_els.c:148:28: warning: variabl
On 4/23/19 3:30 PM, Ming Lei wrote:
Hi Hannes,
Thanks for your response.
On Tue, Apr 23, 2019 at 01:19:33PM +0200, Hannes Reinecke wrote:
On 4/22/19 5:30 AM, Ming Lei wrote:
[ .. ]
Hi Hannes,
Could you please let us know if you have better idea for this issue?
Otherwise, I think we need to
Hi Hannes,
Thanks for your response.
On Tue, Apr 23, 2019 at 01:19:33PM +0200, Hannes Reinecke wrote:
> On 4/22/19 5:30 AM, Ming Lei wrote:
> > On Wed, Apr 17, 2019 at 08:59:43PM +0800, Ming Lei wrote:
> > > On Wed, Apr 17, 2019 at 02:08:59PM +0200, Hannes Reinecke wrote:
> > > > On 4/17/19 5:44
On 4/22/19 5:30 AM, Ming Lei wrote:
On Wed, Apr 17, 2019 at 08:59:43PM +0800, Ming Lei wrote:
On Wed, Apr 17, 2019 at 02:08:59PM +0200, Hannes Reinecke wrote:
On 4/17/19 5:44 AM, Ming Lei wrote:
In normal queue cleanup path, hctx is released after request queue
is freed, see blk_mq_release().
Now scsi_mq_setup_tags() pre-allocates a big buffer for protection
sg list, and the buffer size is scsi_mq_sgl_size().
This way isn't correct, scsi_mq_sgl_size() is used to pre-allocate
sg list for IO data. And the protection data buffer is much less,
for example, one 512byte sector needs 8byte pr
Hi,
Since supporting to blk-mq, big pre-allocation for sg list is
introduced, this way is very unfriendly wrt. memory consumption.
There were Red Hat internal reports that some scsi_debug based tests
can't be run because of too big pre-allocation.
Also lpfc users commplained that 1GB+ ram is pre
Now scsi_mq_setup_tags() pre-allocates a big buffer for IO sg list,
and the buffer size is scsi_mq_sgl_size() which depends on smaller
value between shost->sg_tablesize and SG_CHUNK_SIZE.
Modern HBA's DMA capabilty is often capable of deadling with very
big segment number, so scsi_mq_sgl_size() is
22 matches
Mail list logo
