[PATCH v2 54/58] qla2xxx: Inline the qla2x00_fcport_event_handler() function

2019-08-08 Thread Bart Van Assche
Instead of calling qla2x00_fcport_event_handler() and letting the switch statement inside that function decide which other function to call, call the latter function directly. Remove the event member from the event_arg structure because it is no longer needed. Remove the qla_handle_els_plogi_done()

[PATCH v2 55/58] qla2xxx: Introduce qla2x00_els_dcmd2_free()

2019-08-08 Thread Bart Van Assche
This patch reduces code duplication. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_def.h | 2 +- drivers/scsi/qla2xxx/qla_gbl.h | 2 ++ drivers/scsi/qla2xxx/qla_gs.c | 12 +- drivers/scsi/qla2xxx/qla_iocb.c | 40 ++---

[PATCH v2 58/58] qla2xxx: Fix a NULL pointer dereference

2019-08-08 Thread Bart Van Assche
BUG: KASAN: null-ptr-deref in qla24xx_handle_plogi_done_event+0x134/0x9f0 [qla2xxx] Read of size 4 at addr 00a0 by task swapper/2/0 CPU: 2 PID: 0 Comm: swapper/2 Not tainted 5.2.0-dbg+ #1 Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 Call Trace: dump_stack+0x8a/0xd6 __kasan_re

[PATCH v2 56/58] qla2xxx: Remove two superfluous if-tests

2019-08-08 Thread Bart Van Assche
This patch fixes the following Coverity complaint: Null-checking sp->u.iocb_cmd.u.ctarg.rsp suggests that it may be null, but it has already been dereferenced on all paths leading to the check. See also commit e374f9f59281 ("scsi: qla2xxx: Migrate switch registration commands away from mailbox i

[PATCH v2 57/58] qla2xxx: Simplify qla24xx_async_abort_cmd()

2019-08-08 Thread Bart Van Assche
Make the code easier to read by converting 'goto' statements into 'return' statements. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_init.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/dri

[PATCH v2 53/58] qla2xxx: Report invalid mailbox status codes

2019-08-08 Thread Bart Van Assche
It is easy to mix up the QLA_* and the MBS_* status codes. Complain loudly if that happens. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_def.h | 5 + drivers/scsi/qla2xxx/qla_init.c | 9 + 2 files changed, 14 insertions(+) diff --git a/drivers/s

[PATCH v2 32/58] qla2xxx: Declare fourth qla2x00_set_model_info() argument const

2019-08-08 Thread Bart Van Assche
Make it clear to humans and also to the compiler that the string passed as fourth argument is not modified. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_gbl.h | 4 ++-- drivers/scsi/qla2xxx/qla_init.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)

[PATCH v2 51/58] qla2xxx: Let the compiler check the type of the SCSI command context pointer

2019-08-08 Thread Bart Van Assche
Split srb_cmd.ctx into two pointers such that the compiler can check the type of that pointer. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_def.h | 4 ++-- drivers/scsi/qla2xxx/qla_iocb.c | 20 +--- drivers/scsi/qla2xxx/qla_nx.c | 2 +- d

[PATCH v2 48/58] qla2xxx: Introduce qla2xxx_get_next_handle()

2019-08-08 Thread Bart Van Assche
This patch reduces code duplication. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_gbl.h | 1 + drivers/scsi/qla2xxx/qla_iocb.c | 128 +--- drivers/scsi/qla2xxx/qla_mr.c | 13 +--- drivers/scsi/qla2xxx/qla_nvme.c | 14 +--- 4

[PATCH v2 22/58] qla2xxx: Use strlcpy() instead of strncpy()

2019-08-08 Thread Bart Van Assche
This patch fixes several gcc complaints about string truncation. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_mr.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/

[PATCH v2 30/58] qla2xxx: Suppress multiple Coverity complaint about out-of-bounds accesses

2019-08-08 Thread Bart Van Assche
This patch does not change any functionality. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_gs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c index 5ec3c2b96f3f..33e0c

[PATCH v2 38/58] qla2xxx: Change the return type of qla24xx_read_flash_data()

2019-08-08 Thread Bart Van Assche
This change makes it easier to detect qla24xx_read_flash_data() failures and also to handle such failures. This change does not modify the behavior of the driver since all callers ignore the qla24xx_read_flash_data() return value. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/

[PATCH v2 47/58] qla2xxx: Modify NVMe include directives

2019-08-08 Thread Bart Van Assche
Since struct sg_table is used in nvme-fc-driver.h, include from that header file. Since no definitions or declarations from are used in the qla_nvme.h header file, do not include from that header file. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_nvme.h |

[PATCH v2 44/58] qla2xxx: Introduce the function qla2xxx_init_sp()

2019-08-08 Thread Bart Van Assche
This patch does not change any functionality but makes the next patch easier to read. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_inline.h | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/qla2xxx

[PATCH v2 28/58] qla2xxx: Remove unreachable code from qla83xx_idc_lock()

2019-08-08 Thread Bart Van Assche
This was detected by Coverity. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_os.c | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 37e24987c852..2ba06a84c501 100644 --- a/

[PATCH v2 37/58] qla2xxx: Introduce the be_id_t and le_id_t data types for FC src/dst IDs

2019-08-08 Thread Bart Van Assche
Introduce the be_id_t and le_id_t data types for Fibre Channel source and destination ID formats supported by the firmware instead of using an uint8_t[3] array. Introduce functions for converting from and to the port_id_t data types. This patch does not change the behavior of the qla2xxx driver but

[PATCH v2 31/58] qla2xxx: Always check the qla2x00_wait_for_hba_online() return value

2019-08-08 Thread Bart Van Assche
This patch fixes several Coverity complaints about not always checking the qla2x00_wait_for_hba_online() return value. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_attr.c | 3 ++- drivers/scsi/qla2xxx/qla_target.c | 7 +-- 2 files changed, 7 insertions(

[PATCH v2 34/58] qla2xxx: Check the PCI info string output buffer size

2019-08-08 Thread Bart Van Assche
Pass the output buffer size to the code that generates a PCI info string and check the output buffer size while generating a PCI info string. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_attr.c | 3 +- drivers/scsi/qla2xxx/qla_def.h | 2 +- drivers/scsi/ql

[PATCH v2 26/58] qla2xxx: Simplify a debug statement

2019-08-08 Thread Bart Van Assche
Read the FC port state once instead of twice. This patch fixes the following Coverity complaint: Unchecked return value (CHECKED_RETURN) check_return: Calling atomic_read without checking return value (as is done elsewhere 80 out of 92 times). Cc: Himanshu Madhani Signed-off-by: Bart Van Assche

[PATCH v2 27/58] qla2xxx: Fix qla24xx_process_bidir_cmd()

2019-08-08 Thread Bart Van Assche
Set the r??_data_len variables before using these instead of after. This patch fixes the following Coverity complaint: const: At condition req_data_len != rsp_data_len, the value of req_data_len must be equal to 0. const: At condition req_data_len != rsp_data_len, the value of rsp_data_len must b

[PATCH v2 50/58] qla2xxx: Complain if sp->done() is not called from the completion path

2019-08-08 Thread Bart Van Assche
Not calling sp->done() from the command completion path is a severe bug. Hence complain loudly if that happens. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_init.c | 4 drivers/scsi/qla2xxx/qla_isr.c | 4 drivers/scsi/qla2xxx/qla_mr.c | 4 3

[PATCH v2 29/58] qla2xxx: Suppress a Coveritiy complaint about integer overflow

2019-08-08 Thread Bart Van Assche
This patch fixes the following Coverity complaint: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) overflow_before_widen: Potentially overflowing expression dma_eng_num * 65536U with type unsigned int (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a context that

[PATCH v2 49/58] qla2xxx: Make sure that aborted commands are freed

2019-08-08 Thread Bart Van Assche
The LIO core requires that the target driver callback functions .queue_data_in() and .queue_status() call target_put_sess_cmd() or transport_generic_free_cmd(). These calls may happen synchronously or asynchronously. Make sure that one of these LIO functions is called in case a command has been abo

[PATCH v2 39/58] qla2xxx: Check secondary image if reading the primary image fails

2019-08-08 Thread Bart Van Assche
This patch fixes several Coverity complaints about reading data that has not been initialized. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_init.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/dr

[PATCH v2 52/58] qla2xxx: Remove superfluous sts_entry_* casts

2019-08-08 Thread Bart Van Assche
The C language supports implicit casting of void pointers to non-void pointers. Remove explicit sts_entry_* casts that are not necessary. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_isr.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-)

[PATCH v2 40/58] qla2xxx: Make it explicit that ELS pass-through IOCBs use little endian

2019-08-08 Thread Bart Van Assche
According to the firmware documentation the firmware expects all ELS pass-through IOCB parameters in little endian format. Make this explicit. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_fw.h | 8 drivers/scsi/qla2xxx/qla_iocb.c | 7 --- 2 fil

[PATCH v2 45/58] qla2xxx: Fix a race condition between aborting and completing a SCSI command

2019-08-08 Thread Bart Van Assche
Instead of allocating a struct srb dynamically from inside .queuecommand(), set qla2xxx_driver_template.cmd_size such that struct scsi_cmnd and struct srb are contiguous. Do not call QLA_QPAIR_MARK_BUSY() / QLA_QPAIR_MARK_NOT_BUSY() for SRBs associated with SCSI commands. That is safe because scsi_

[PATCH v2 13/58] qla2xxx: Verify locking assumptions at runtime

2019-08-08 Thread Bart Van Assche
Make sure that locking assumptions are verified at runtime if kernel debugging is enabled. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_target.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2

[PATCH v2 36/58] qla2xxx: Complain if a soft reset fails

2019-08-08 Thread Bart Van Assche
Failure of a soft reset is a severe failure. Hence report such failures. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_tmpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c

[PATCH v2 20/58] qla2xxx: Report the firmware status code if a mailbox command fails

2019-08-08 Thread Bart Van Assche
It is helpful when debugging this driver to have the firmware status code available if a mailbox command fails. Hence report that firmware status code. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_mbx.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(

[PATCH v2 46/58] qla2xxx: Make qlt_handle_abts_completion() more robust

2019-08-08 Thread Bart Van Assche
Avoid that this function crashes if mcmd == NULL. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index d25c3fa436

[PATCH v2 08/58] qla2xxx: Declare the fourth ql_dump_buffer() argument const

2019-08-08 Thread Bart Van Assche
This patch makes it clear to humans and also to the compiler that ql_dump_buffer() does not modify the memory the @buf argument points at. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_dbg.c | 3 ++- drivers/scsi/qla2xxx/qla_gbl.h | 2 +- 2 files changed, 3 in

[PATCH v2 41/58] qla2xxx: Set the responder mode if appropriate for ELS pass-through IOCBs

2019-08-08 Thread Bart Van Assche
According to the firmware documentation responder mode must be set for ELS pass-through IOCBs if a response is expected. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_iocb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla

[PATCH v2 09/58] qla2xxx: Change the return type of qla2x00_update_ms_fdmi_iocb() into void

2019-08-08 Thread Bart Van Assche
The value returned by this function is not used. Hence change the return type of this function into 'void' and remove the return statement. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_gs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH v2 19/58] qla2xxx: Fix session lookup in qlt_abort_work()

2019-08-08 Thread Bart Van Assche
Pass the correct session ID to find_sess_by_s_id() instead of passing an uninitialized variable. Cc: Himanshu Madhani Fixes: 2d70c103fd2a ("[SCSI] qla2xxx: Add LLD target-mode infrastructure for >= 24xx series") # v3.5. Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_target.c | 4 +

[PATCH v2 25/58] qla2xxx: Remove dead code

2019-08-08 Thread Bart Van Assche
Since sess == NULL before 'goto out_term2' is executed, the code under 'if (sess)' cannot be reached. Hence remove that code. This was detected by Coverity. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_target.c | 3 --- 1 file changed, 3 deletions(-) diff --

[PATCH v2 18/58] qla2xxx: Simplify qla24xx_abort_sp_done()

2019-08-08 Thread Bart Van Assche
Instead of explicitly checking whether a timeout has occurred, ignore the del_timer() return value. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_init.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_i

[PATCH v2 07/58] qla2xxx: Remove a superfluous forward declaration

2019-08-08 Thread Bart Van Assche
Since qlt_make_local_sess() is defined before it is called, remove the forward declaration of that function. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_target.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/driver

[PATCH v2 43/58] qla2xxx: Enable type checking for the SRB free and done callback functions

2019-08-08 Thread Bart Van Assche
Since all pointers passed to the srb_t.done() and srb_t.free() functions have type srb_t, change the type of the first argument of these functions from void * into struct srb *. This allows the compiler to verify the argument types for these functions. This patch does not change any functionality.

[PATCH v2 24/58] qla2xxx: Complain if parsing the version string fails

2019-08-08 Thread Bart Van Assche
This patch fixes a Coverity complaint about not checking the sscanf() return value. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_tmpl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla

[PATCH v2 16/58] qla2xxx: Remove a superfluous pointer check

2019-08-08 Thread Bart Van Assche
Checking a pointer after it has been dereferenced is not useful. This was detected by Coverity. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/s

[PATCH v2 23/58] qla2xxx: Complain if a mailbox command times out

2019-08-08 Thread Bart Van Assche
This patch fixes the following Coverity complaint: Unchecked return value (CHECKED_RETURN) check_return: Calling wait_for_completion_timeout without checking return value (as is done elsewhere 14 out of 17 times). Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla

[PATCH v2 42/58] qla2xxx: Rework key encoding in qlt_find_host_by_d_id()

2019-08-08 Thread Bart Van Assche
Use the same approach for encoding the destination ID as the approach used by qlt_update_vp_map(). Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_target.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.

[PATCH v2 33/58] qla2xxx: Complain if waiting for pending commands times out

2019-08-08 Thread Bart Van Assche
Such a timeout is a severe issue. Hence complain if waiting for pending commands times out. This patch fixes a small bug: it modifies qla82xx_chip_reset_cleanup() such that the "Done waiting" message is reported if qla82xx_chip_reset_cleanup() succeeded instead of if that function failed. Cc: Hima

[PATCH v2 35/58] qla2xxx: Use memcpy() and strlcpy() instead of strcpy() and strncpy()

2019-08-08 Thread Bart Van Assche
This patch makes the string manipulation code easier to verify. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_init.c | 18 ++ drivers/scsi/qla2xxx/qla_mr.c | 6 -- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/

[PATCH v2 15/58] qla2xxx: Simplify qlt_lport_dump()

2019-08-08 Thread Bart Van Assche
Simplify the implementation of this function by using the %phC format specifier instead of using explicit for-loops. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_target.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/

[PATCH v2 21/58] qla2xxx: Do not corrupt vha->plogi_ack_list

2019-08-08 Thread Bart Van Assche
Delete the PLOGIN ACK data structure from the vha->plogi_ack_list before freeing that data structure to avoid that that list gets corrupted. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_os.c | 8 ++-- drivers/scsi/qla2xxx/qla_target.c | 4 +++- 2 file

[PATCH v2 11/58] qla2xxx: Declare qla_tgt_cmd.cdb const

2019-08-08 Thread Bart Van Assche
Make it clear that the CDB is not modified after processing of a SCSI command has started. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_target.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/s

[PATCH v2 14/58] qla2xxx: Reduce the number of casts in GID list code

2019-08-08 Thread Bart Van Assche
This patch makes the code that parses the GID list easier to read without changing the behavior of the code. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_dfs.c| 9 +++-- drivers/scsi/qla2xxx/qla_init.c | 18 -- drivers/scsi/qla2xxx/

[PATCH v2 12/58] qla2xxx: Change data_dsd into an array

2019-08-08 Thread Bart Van Assche
This patch does not change any functionality but fixes a Coverity complaint about using a scalar as an array. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_def.h| 4 ++-- drivers/scsi/qla2xxx/qla_iocb.c | 4 ++-- drivers/scsi/qla2xxx/qla_target.c | 4 ++-

[PATCH v2 17/58] qla2xxx: Remove two superfluous tests

2019-08-08 Thread Bart Van Assche
Since qlt_remove_target() only calls qlt_release() if vha->vha_tgt.qla_tgt != NULL, checking that pointer inside qlt_release() is not necessary. This patch fixes the following Coverity complaint: CID 188348 (#1 of 1): Dereference after null check (FORWARD_NULL) var_deref_model: Passing null pointe

[PATCH v2 10/58] qla2xxx: Reduce the scope of three local variables in qla2xxx_queuecommand()

2019-08-08 Thread Bart Van Assche
This patch makes it clear that the tag, hwq and qpair variables are only used in the mq path. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_os.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/

[PATCH v2 02/58] qla2xxx: Really fix qla2xxx_eh_abort()

2019-08-08 Thread Bart Van Assche
I'm not sure how this happened but the patch that was intended to fix abort handling was incomplete. This patch fixes that patch as follows: - If aborting the SCSI command failed, wait until the SCSI command completes. - Return SUCCESS instead of FAILED if an abort attempt races with SCSI comma

[PATCH v2 03/58] qla2xxx: Improve Linux kernel coding style conformance

2019-08-08 Thread Bart Van Assche
Insert a space where required, surround complex expressions in macros with parentheses, use the UL suffix instead of the (unsigned long) cast, do not use line continuations when not necessary and do not explicitly initialize static variables to zero. Cc: Himanshu Madhani Signed-off-by: Bart Van A

[PATCH v2 01/58] qla2xxx: Make qla2x00_abort_srb() again decrease the sp reference count

2019-08-08 Thread Bart Van Assche
Since qla2x00_abort_srb() starts with increasing the reference count of @sp, decrease that same reference count before returning. Cc: Himanshu Madhani Fixes: 219d27d7147e ("scsi: qla2xxx: Fix race conditions in the code for aborting SCSI commands") # v5.2. Signed-off-by: Bart Van Assche --- dr

[PATCH v2 00/58] qla2xxx patches for kernel v5.4

2019-08-08 Thread Bart Van Assche
Hi Martin, The patches in this series improve the robustness of the QLogic Fibre Channel initiator and target drivers. These patches are a result of manual code inspection, analysis of Coverity reports and stress testing of these two drivers. Please consider these patches for kernel version v5.4.

[PATCH v2 04/58] qla2xxx: Use tabs instead of spaces for indentation

2019-08-08 Thread Bart Van Assche
This patch only modifies whitespace. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_gs.c | 78 +-- 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c inde

[PATCH v2 05/58] qla2xxx: Include the header file from qla_dsd.h

2019-08-08 Thread Bart Van Assche
Since the put_unaligned_*() macros are used in this header file, include the header file that defines these macros. Cc: Himanshu Madhani Fixes: 15b7a68c1d03 ("scsi: qla2xxx: Introduce the dsd32 and dsd64 data structures") # v5.2-rc1. Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_

[PATCH v2 06/58] qla2xxx: Remove an include directive from qla_mr.c

2019-08-08 Thread Bart Van Assche
There is no bsg code in the qla_mr.c source file. Hence do not include the header file from qla_mr.c. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche --- drivers/scsi/qla2xxx/qla_mr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/ql

Re: [PATCH 1/2] scsi: core: fix missing .cleanup_rq for SCSI hosts without request batching

2019-08-08 Thread kbuild test robot
Hi Steffen, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc3 next-20190808] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Steffen

Re: [PATCH] scsi: target/tcm_loop: update upper limit of LUN

2019-08-08 Thread Mike Christie
On 08/08/2019 03:42 AM, Naohiro Aota wrote: > On Tue, Aug 06, 2019 at 12:42:20PM -0500, Mike Christie wrote: >> On 08/05/2019 09:45 PM, Naohiro Aota wrote: >>> On Mon, Aug 05, 2019 at 11:33:26AM -0500, Mike Christie wrote: On 08/05/2019 01:23 AM, Naohiro Aota wrote: > targetcli-fb (or its

RE: [PATCH] megaraid_sas: change sdev queue depth max vs optimal

2019-08-08 Thread Chandrakanth Patil
Martin, The firmware provided queue depth provides optimum performance in most of the cases/workloads. And this patch provides the option to the user to go with max queue_depth or with optimum queue_depth. -Chandrakanth -Original Message- From: Martin K. Petersen [mailto:martin.peter...@

Re: [PATCH 00/59] qla2xxx patches for kernel v5.4

2019-08-08 Thread Himanshu Madhani
Hi Bart, > On Aug 1, 2019, at 12:55 PM, Bart Van Assche wrote: > > Hi Martin, > > The patches in this series improve the robustness of the QLogic Fibre Channel > initiator and target drivers. These patches are a result of manual code > inspection, analysis of Coverity reports and stress testi

Re: [PATCH] scsi: target/tcm_loop: update upper limit of LUN

2019-08-08 Thread Naohiro Aota
On Tue, Aug 06, 2019 at 12:42:20PM -0500, Mike Christie wrote: On 08/05/2019 09:45 PM, Naohiro Aota wrote: On Mon, Aug 05, 2019 at 11:33:26AM -0500, Mike Christie wrote: On 08/05/2019 01:23 AM, Naohiro Aota wrote: targetcli-fb (or its library: rtslib-fb) allows us to create LUN up to 65535. On