[PATCH v2 03/27] hpsa: remove unused hpsa_tag_discard_error_bits

This function is no longer used. Reviewed-by: Tomas Henzl Reviewed-by: Hannes Reinecke Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 4085401..5a996273 100644

[PATCH v2 06/27] hpsa: fix null device issues

Reviewed-by: Tomas Henzl Reviewed-by: Manoj Kumar Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index b64913f..4468166 100644 --- a/drivers/scsi/hpsa.c

[PATCH v2 04/27] hpsa: change devtype to unsigned

This member is used in calls to scsi_device_type. It should be unsigned since the kernel checks for upper bounds and it should never be negative. Suggested-by: Tomas Henzl Suggested-by: Hannes Reinecke Suggested-by: Matthew R. Ochs Signed-off-by: Don Brace --- drivers/scsi/hpsa.h |2

[PATCH v2 01/27] hpsa: remove unused parameter hostno

This parameter was once used before scan_start was defined but now it is no longer used. Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index

[PATCH v2 00/27] hpsa updates

rt-class to check return code from hpsa_add_sas_host --- Don Brace (15): hpsa: remove unused parameter hostno hpsa: stop zeroing reset_cmds_out and ioaccel_cmds_out during rescan hpsa: remove unused hpsa_tag_discard_error_bits hpsa: change devtype to unsigned hpsa:

Re: [PATCH 1 22/25] hpsa: enhance device messages

On 10/30/2015 09:32 AM, Tomas Henzl wrote: RAID_UNKNOWN is used in few other places - raid_level_show for example, raid_level_show handles physical devices by using "N/A", otherwise it displays the RAID level for logical devices. Other functions avoid the use of raid_type when the drive is n

Re: [PATCH 1 24/25] hpsa: add in sas transport class

On 10/30/2015 03:07 PM, Matthew R. Ochs wrote: On Oct 28, 2015, at 5:06 PM, Don Brace wrote: From: Kevin Barnett Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 535

Re: [PATCH 1 21/25] hpsa: disable report lun data caching

On 10/30/2015 09:25 AM, Tomas Henzl wrote: On 28.10.2015 23:06, Don Brace wrote: From: Scott Teel When external target arrays are present, disable the firmware's normal behavior of returning a cached copy of the report lun data, and force it to collect new data each time we request a r

Re: [PATCH 1 15/25] hpsa: enhance hpsa_get_device_id

On 10/30/2015 03:08 AM, Hannes Reinecke wrote: On 10/28/2015 11:06 PM, Don Brace wrote: use an index into vpd data for SAS/SATA drives Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 23

Re: [PATCH 1 08/25] hpsa: fix hpsa_adjust_hpsa_scsi_table

On 10/30/2015 02:57 AM, Hannes Reinecke wrote: On 10/28/2015 11:05 PM, Don Brace wrote: Fix a NULL pointer issue in the driver when devices are removed during a reset. Signed-off-by: Don Brace --- drivers/block/cciss.h |1 + drivers/scsi/hpsa.c | 16 drivers

Re: [PATCH 1 06/25] hpsa: abandon rescans on memory alloaction failures.

On 10/30/2015 02:53 AM, Hannes Reinecke wrote: On 10/28/2015 11:05 PM, Don Brace wrote: Abandon and reschedule rescan process only if device inquiries fail due to mem alloc failures, which are likely to occur for all devices. Otherwise, skip device if inquiry fails for other reasons, and

Re: [PATCH 1 03/25] hpsa: check for null arguments to dev_printk

On 10/30/2015 02:47 AM, Hannes Reinecke wrote: On 10/28/2015 11:04 PM, Don Brace wrote: Check for NULLs. Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 ++ drivers/scsi/hpsa.h |2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b

Re: [PATCH 1 20/25] hpsa: add discovery polling for PT RAID devices.

On 10/29/2015 03:59 PM, Matthew R. Ochs wrote: On Oct 29, 2015, at 3:51 PM, Don Brace wrote: On 10/29/2015 03:20 PM, Matthew R. Ochs wrote: On Oct 28, 2015, at 5:06 PM, Don Brace wrote: From: Scott Teel There are problems with getting configuration change notification in pass-through

Re: [PATCH 1 17/25] hpsa: move scsi_add_device and scsi_remove_device calls to new function

On 10/29/2015 12:21 PM, Matthew R. Ochs wrote: On Oct 28, 2015, at 5:06 PM, Don Brace wrote: From: Kevin Barnett preparation for adding the sas transport class Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c

Re: [PATCH 1 13/25] hpsa: simplify update scsi devices

On 10/29/2015 11:43 AM, Matthew R. Ochs wrote: On Oct 28, 2015, at 5:05 PM, Don Brace wrote: From: Kevin Barnett remove repeated calculation that checks for physical or logical devices. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don

Re: [PATCH 1 09/25] hpsa: fix physical target reset

On 10/29/2015 09:30 AM, Tomas Henzl wrote: On 28.10.2015 23:05, Don Brace wrote: From: Scott Teel Set reset type in device_reset_handler to do either logical unit reset for logical devices, or physical target reset, for physical devices. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley

Re: [PATCH 1 02/25] hpsa: remove unused hpsa_tag_discard_error_bits

On 10/29/2015 09:37 AM, Manoj Kumar wrote: Don: See comment below. - Manoj Kumar On 10/28/2015 5:04 PM, Don Brace wrote: This function is no longer used. diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c +#define HPSA_PERF_ERROR_BITS ((1 << DIRECT_LOOKUP_SHIF

[PATCH 1 23/25] hpsa: fix multiple issues in path_info_show

d time any longer. Using scnprintf ensures that output_len always represents the number of bytes actually written to the buffer, so we'll report the proper amount to the upper layer. Signed-off-by: Rasmus Villemoes Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 38 +

[PATCH 1 25/25] hpsa: bump the driver version

Reviewed-by: Justin Lindley Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Reviewed-by: Gerry Morong Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index ca38a00..1b43157

[PATCH 1 24/25] hpsa: add in sas transport class

From: Kevin Barnett Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 535 +-- drivers/scsi/hpsa.h | 27 ++ drivers/scsi/hpsa_cmd.h | 14 + 3 files

[PATCH 1 18/25] External array LUNs must use target and lun numbers assigned by the

he number of luns from "Report LUNs" in excess of those reported by 'ID controller' are therefore the PTRAID LUNS. We can now remove function is_ext_target, and the 'white list' array of supported model names. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Review

[PATCH 1 19/25] hpsa: eliminate fake lun0 enclosures

, then the target scan would stop, and move to the next target. Lun0 enclosure device was added to prevent sparsely-numbered LUNs from being missed. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hps

[PATCH 1 21/25] hpsa: disable report lun data caching

ignal from the external array to the smart array when lun configuration changes, and thus when driver requests report luns, it may be stale data. Use diag options to turn off RPL data caching. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don

[PATCH 1 20/25] hpsa: add discovery polling for PT RAID devices.

rom rescan_controller_worker (every 30 seconds). If the data from report_luns is different than last time (binary compare), execute a full rescan via update_scsi_devices. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |

[PATCH 1 22/25] hpsa: enhance device messages

Reviewed-by: Justin Lindley Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 45 - 1 file changed, 40 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index

[PATCH 1 17/25] hpsa: move scsi_add_device and scsi_remove_device calls to new function

From: Kevin Barnett preparation for adding the sas transport class Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 65 +++ 1 file changed, 39 insertions

[PATCH 1 16/25] hpsa: refactor hpsa_figure_bus_target_lun

From: Kevin Barnett setup for sas transport. Need to set the bus and target accordingly. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 25 - drivers/scsi/hpsa.h |5 + 2

[PATCH 1 07/25] hpsa: correct transfer length for 6 byte read/write commands

handle block counts of 0. Cleanup block and block count calculations. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 19 ++- 1 file changed, 6 insertions(+), 13

[PATCH 1 15/25] hpsa: enhance hpsa_get_device_id

use an index into vpd data for SAS/SATA drives Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b

[PATCH 1 13/25] hpsa: simplify update scsi devices

From: Kevin Barnett remove repeated calculation that checks for physical or logical devices. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 23 ++- drivers/scsi/hpsa.h |1 + 2 files

[PATCH 1 11/25] hpsa: correct ioaccel2 sg chain len

Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 3973fb3..ffc0551 100644 --- a/drivers

[PATCH 1 08/25] hpsa: fix hpsa_adjust_hpsa_scsi_table

Fix a NULL pointer issue in the driver when devices are removed during a reset. Signed-off-by: Don Brace --- drivers/block/cciss.h |1 + drivers/scsi/hpsa.c | 16 drivers/scsi/hpsa.h |1 + 3 files changed, 18 insertions(+) diff --git a/drivers/block/cciss.h b

[PATCH 1 14/25] hpsa: add function is_logical_device

From: Kevin Barnett simplify checking for logical/physical devices Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a

[PATCH 1 10/25] hpsa: correct check for non-disk devices

. Change the code to use the structure elements directly since this MACRO is only used in one location. Reported-by: Dan Carpenter Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 28

[PATCH 1 12/25] hpsa: simplify check for device exposure

From: Kevin Barnett remove macros and cleanup device exposure checking Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 25 +++-- drivers/scsi/hpsa.h |6 +- 2 files changed, 12

[PATCH 1 09/25] hpsa: fix physical target reset

From: Scott Teel Set reset type in device_reset_handler to do either logical unit reset for logical devices, or physical target reset, for physical devices. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c

[PATCH 1 03/25] hpsa: check for null arguments to dev_printk

Check for NULLs. Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 ++ drivers/scsi/hpsa.h |2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 864fb03..6b6e9bb 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi

[PATCH 1 06/25] hpsa: abandon rescans on memory alloaction failures.

Lindley Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index a3f671c..ecc6ada 100644 --- a/drivers/scsi

[PATCH 1 00/25] hpsa updates

anged driver initiated rescan messages - changed atomic_t to int from ctlr_info.reset_in_progress - added hpsa-stop-zeroing-reset-cmds-out-during-rescan - added hpsa-remove-unused-function - added hpsa-fix-multiple-issues-in-path_info_show --- Don Brace (13): hpsa: stop zeroing reset_cmd

[PATCH 1 02/25] hpsa: remove unused hpsa_tag_discard_error_bits

This function is no longer used. Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index e60c652..864fb03 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c

[PATCH 1 05/25] hpsa: allow driver requested rescans

Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 17 +++-- drivers/scsi/hpsa.h |1 + 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c

[PATCH 1 01/25] hpsa: stop zeroing reset_cmds_out and ioaccel_cmds_out during rescan

pulling the rug out from under the reset handler likewise for ioaccel_cmds_out Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 40669f8..e60c652 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers

[PATCH 1 04/25] hpsa: fix null device issues

Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 6b6e9bb..3fe8a18 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -1136,7 +1136,7

Re: [PATCH] scsi: hpsa: fix multiple issues in path_info_show

On 10/27/2015 05:16 PM, Rasmus Villemoes wrote: I'm not familiar with this code, but path_info_show() (added in 8270b86243658 "hpsa: add sysfs entry path_info to show box and bay information") seems to be broken in multiple ways. First, there's 817 return snprintf(buf, output_len+1, "%s%s%s%

Re: [PATCH 05/21] hpsa: fix hpsa_adjust_hpsa_scsi_table

On 10/26/2015 09:55 AM, Tomas Henzl wrote: On 24.10.2015 21:52, Don Brace wrote: Fix a NULL pointer issue in the driver when devices are removed during a reset. Signed-off-by: Don Brace --- drivers/block/cciss.h |1 + drivers/scsi/hpsa.c | 16 drivers/scsi

Re: [PATCH 03/21] hpsa: abandon rescans on memory alloaction failures.

On 10/26/2015 09:24 AM, Tomas Henzl wrote: On 24.10.2015 21:52, Don Brace wrote: Abandon and reschedule rescan process only if device inquiries fail due to mem alloc failures, which are likely to occur for all devices. Otherwise, skip device if inquiry fails for other reasons, and continue

Re: [PATCH 01/21] hpsa: correct calls to dev_printk

On 10/26/2015 07:52 AM, Tomas Henzl wrote: On 24.10.2015 21:52, Don Brace wrote: was seeing issues passing level into hpsa_show_dev_msg and then using the level as an arguement to dev_printk. For now, switch to dev_warn. Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 41

Re: [PATCH 19/21] hpsa: enhance device messages

On 10/24/2015 03:19 PM, kbuild test robot wrote: Hi Don, [auto build test ERROR on scsi/for-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Don-Brace/hpsa-updates/20151025-040012 config: x

[PATCH 21/21] hpsa: bump the driver version

Reviewed-by: Justin Lindley Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 04799a8..5f74eaa 100644 --- a/drivers/scsi

[PATCH 20/21] hpsa: add in sas transport class

From: Kevin Barnett Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 537 +-- drivers/scsi/hpsa.h | 27 ++ drivers/scsi/hpsa_cmd.h | 14 + 3 files

[PATCH 15/21] External array LUNs must use target and lun numbers assigned by the

he number of luns from "Report LUNs" in excess of those reported by 'ID controller' are therefore the PTRAID LUNS. We can now remove function is_ext_target, and the 'white list' array of supported model names. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Review

[PATCH 18/21] hpsa: disable report lun data caching

ignal from the external array to the smart array when lun configuration changes, and thus when driver requests report luns, it may be stale data. Use diag options to turn off RPL data caching. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don

[PATCH 19/21] hpsa: enhance device messages

Reviewed-by: Justin Lindley Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 46 +- 1 file changed, 41 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index

[PATCH 17/21] hpsa: add discovery polling for PT RAID devices.

rom rescan_controller_worker (every 30 seconds). If the data from report_luns is different than last time (binary compare), execute a full rescan via update_scsi_devices. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |

[PATCH 13/21] hpsa: refactor hpsa_figure_bus_target_lun

From: Kevin Barnett setup for sas transport. Need to set the bus and target accordingly. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 25 - drivers/scsi/hpsa.h |5 + 2

[PATCH 11/21] hpsa: add function is_logical_device

From: Kevin Barnett simplify checking for logical/physical devices Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a

[PATCH 16/21] hpsa: eliminate fake lun0 enclosures

, then the target scan would stop, and move to the next target. Lun0 enclosure device was added to prevent sparsely-numbered LUNs from being missed. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hps

[PATCH 14/21] hpsa: move scsi_add_device and scsi_remove_device calls to new function

From: Kevin Barnett preparation for adding the sas transport class Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 62 ++- 1 file changed, 36 insertions

[PATCH 10/21] hpsa: simplify update scsi devices

From: Kevin Barnett remove repeated calculation that checks for physical or logical devices. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 23 ++- drivers/scsi/hpsa.h |1 + 2 files

[PATCH 08/21] hpsa: correct ioaccel2 sg chain len

Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index d42063d..ff34c8e 100644 --- a/drivers

[PATCH 07/21] hpsa: correct check for non-disk devices

. Change the code to use the structure elements directly since this MACRO is only used in one location. Reported-by: Dan Carpenter Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 28

[PATCH 12/21] hpsa: enhance hpsa_get_device_id

use an index into vpd data for SAS/SATA drives Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b

[PATCH 09/21] hpsa: simplify check for device exposure

From: Kevin Barnett remove macros and cleanup device exposure checking Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 25 +++-- drivers/scsi/hpsa.h |6 +- 2 files changed, 12

[PATCH 05/21] hpsa: fix hpsa_adjust_hpsa_scsi_table

Fix a NULL pointer issue in the driver when devices are removed during a reset. Signed-off-by: Don Brace --- drivers/block/cciss.h |1 + drivers/scsi/hpsa.c | 16 drivers/scsi/hpsa.h |1 + 3 files changed, 18 insertions(+) diff --git a/drivers/block/cciss.h b

[PATCH 01/21] hpsa: correct calls to dev_printk

was seeing issues passing level into hpsa_show_dev_msg and then using the level as an arguement to dev_printk. For now, switch to dev_warn. Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 41 - 1 file changed, 24 insertions(+), 17 deletions(-) diff

[PATCH 06/21] hpsa: fix physical target reset

From: Scott Teel Set reset type in device_reset_handler to do either logical unit reset for logical devices, or physical target reset, for physical devices. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c

[PATCH 04/21] hpsa: correct transfer length for 6 byte read/write commands

handle block counts of 0. Cleanup block and block count calculations. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a

[PATCH 02/21] hpsa: allow driver requested rescans

Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 16 ++-- drivers/scsi/hpsa.h |1 + 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c

[PATCH 03/21] hpsa: abandon rescans on memory alloaction failures.

Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 5dfb6cf..e1ee06d 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi

[PATCH 00/21] hpsa updates

t out scsi_add_device scsi_remove_device calls - add in SAS transport class for HBA devices - add in physical target resets - eliminate fake lun0 enclosures - add polling for PT RAID devices - disable report lun data caching - bumped driver version to match in-box driver --- Don Brace (10):

RE: [PATCH] hpsa: add in sas transport

> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Wednesday, September 30, 2015 2:50 AM > To: Don Brace; linux-scsi@vger.kernel.org > Subject: Re: [PATCH] hpsa: add in sas transport > > On 09/30/2015 12:21 AM, Don Brace wrote: &g

Re: hpsa failure with 4.3.0-rc1

I reported this a little while ago: http://marc.info/?l=linux-kernel&m=144284810906949&w=2 It did clear up between rc1 and rc3. Not sure what changes were applied in-between. On 09/30/2015 02:40 AM, Hannes Reinecke wrote: Hi all, trying to boot 4.3.0-rc1 on a system with hpsa results in a sw

[PATCH] hpsa: add in sas transport

From: Kevin Barnett customers want lsscsi -t to show sas addresses when enumerating sas devices. The sas addresses are used mainly to light drive LEDs for location. Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 704 ++- drivers/scsi/hpsa.h

[PATCH] hpsa update

This patch is based on Linus's tree I could use some help with this patch. We are adding in the sas transport layer for our HBA devices. I am having issues removing the sas transport entries during driver unload. The entries are removed in what appears to be the proper order but I am getting a b

RE: [PATCH] hpsa: move lockup_detected attribute to host attr

> -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Monday, September 07, 2015 11:15 AM > To: linux-scsi@vger.kernel.org > Cc: Don Brace; Justin Lindley; elli...@hp.com; Kevin Barnett; Scott Teel; > h...@infradead.org > Subject: [PATCH] hpsa:

Re: [BUG] hpsa: Controller lockup detected: 0x00150028

On 08/24/2015 05:02 AM, Wouter Depuydt wrote: Wouter Depuydt gmail.com> writes: -Original Message- From: Peter Zijlstra [mailto:peterz infradead.org] Sent: Friday, May 22, 2015 11:40 AM To: Tomas Henzl Cc: Oelke, Mark; don.brace pmcs.com; ISS StorageDev; storagedev pmcs.com; linux

RE: [PATCH 2/3] hpsa: Remove unneccessary variable from raid_level_show

> Cc: Greg KH (g...@kroah.com) > Subject: [PATCH 2/3] hpsa: Remove unneccessary variable from raid_level_show > > > Remove unneccessary variable from raid_level_show > > Signed-off-by: Shane Seymour Signed-off-by: Don brace -- To unsubscribe from this list: send the line &q

RE: [PATCH 3/3] hpsa: Convert DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WR|WO

ageDev > Cc: linux-...@vger.kernel.org; Greg KH (g...@kroah.com) > Subject: [PATCH 3/3] hpsa: Convert DEVICE_ATTR macro usage to > DEVICE_ATTR_RO|WR|WO > > > Convert DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WR|WO > Changes forced some function names to change. > > Signed-off

[PATCH 11/11] hpsa: fix rmmod issues

: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index a3077e9..0f8acfb 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c

[PATCH 10/11] hpsa: fix issues with multilun devices

2 target 0. Before the change the changer device is not seen. Suggested-by: shane.seymour Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b

[PATCH 08/11] Change how controllers in mixed mode are handled.

From: Kevin Barnett Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 97 ++- drivers/scsi/hpsa.h |2 - 2 files changed, 11 insertions(+), 88 deletions(-) diff --git a/drivers/scsi

[PATCH 09/11] hpsa: add in new offline mode

From: Scott Benesh prevent adding volumes that are not available. Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 15 +++ drivers/scsi/hpsa_cmd.h |1 + 2 files changed, 12 insertions

[PATCH 05/11] hpsa: add sysfs entry path_info to show box and bay information

From: Joe Handzik host no, bus, target, lun, scsi_device_type for hba mode add: box and bay information report if the path is active/inactive Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 122

[PATCH 07/11] hpsa: add in new controllers

Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index f34978d..20c29e5 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c

[PATCH 06/11] hpsa: cleanup update scsi devices

showing that tables have been updated unnecessarily. Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index f64a2c7

[PATCH 01/11] hpsa: Correct double unlock of mutex

Reported-by: Dan Carpenter Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 1dafeb4..1d5f4fd 100644 --- a/drivers

[PATCH 03/11] hpsa: correct static checker warnings on driver init cleanup

Reported-by: Dan Carpenter Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index e9b2073..6b083af 100644 --- a/drivers/scsi

[PATCH 00/11] hpsa updates

r ids. - Correct rmmod issue - Add in new path_info to show box and bay info - Driver supports mixed mode, RAID and HBA - New offline mode - Bug fix for multi lun devices from Shane Seymour --- Don Brace (7): hpsa: Correct double unlock of mutex hpsa: correct decode sense data

[PATCH 02/11] hpsa: correct decode sense data

Reported-by: Dan Carpenter Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 1d5f4fd..e9b2073 100644 --- a/drivers/scsi

[PATCH 04/11] hpsa: add PMC to copyright

need to add PMC to copyright notice and update the Hewlett-Packard copyright notification. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Reviewed-by: Justin Lindley Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |9 +++-- drivers/scsi/hpsa.h |9 +++-- drivers

hpsa static checker issues

Dan, You had noted three concerns covering: mutex_unlock, decode sense data, and a goto label issue, that were detected during your static checker run. I have patches that address these issues. I am thinking that I need to post these three patches linux-scsi. Is that correct? Thanks, Don

RE: [patch] hpsa: fix an sprintf() overflow in the reset handler

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Thursday, June 04, 2015 9:48 AM > To: Don Brace > Cc: James E.J. Bottomley; iss_storage...@hp.com; dl Team ESD Storage Dev > Support; linux-scsi@vger.kernel.org; kernel-janit...@vger.ke

RE: [patch] hpsa: fix an sprintf() overflow in the reset handler

> -Original Message- > From: walter harms [mailto:wha...@bfs.de] > Sent: Thursday, June 04, 2015 10:23 AM > To: Dan Carpenter > Cc: Don Brace; James E.J. Bottomley; iss_storage...@hp.com; dl Team ESD > Storage Dev Support; linux-scsi@vger.kernel.org; kernel- > jan

RE: [PATCH] hpsa: dont meddle with hw which isn't ours (cciss)

> -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Thursday, April 02, 2015 8:26 AM > To: linux-scsi@vger.kernel.org > Cc: Don Brace; Scott Teel; Justin Lindley; Kevin Barnett > Subject: [PATCH] hpsa: dont meddle with hw which isn't our

RE: [PATCH 2/2] cciss: correct the non-resettable board list

-Original Message- > From: Don Brace > Sent: Tuesday, May 19, 2015 1:56 PM > To: 'Tomas Henzl'; linux-scsi@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; ax...@kernel.dk > Subject: RE: [PATCH 2/2] cciss: correct the non-resettable board list > > > -

[PATCH v5 41/42] hpsa: add in new controller id

add in support for latest PMC controller Reviewed-by: Scott Teel Reviewed-by: Tomas Henzl Reviewed-by: Hannes Reinecke Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 9de7173..1aebcfe

[PATCH v5 36/42] hpsa: add interrupt number to /proc/interrupts interrupt name

PCI bus went from 32 to 64 bits wide. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Reviewed-by: Hannes Reinecke Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 20 ++-- drivers/scsi/hpsa.h |1 + 2 files

[PATCH v5 40/42] hpsa: cleanup reset

both types of waits. Also, don't complete commands which are terminated due to a reset operation. fix for controller lockup during reset Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Reviewed-by: Hannes Reinecke Signed-off-by: Webb Scales Signed-off-by:

[PATCH v5 39/42] hpsa: propagate the error code in hpsa_kdump_soft_reset

From: Robert Elliott If hpsa_wait_for_board_state fails, hpsa_kdump_soft_reset should propagate its return value (e.g., -ENODEV) rather than just returning -1. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Reviewed-by: Hannes Reinecke Signed-off-by: Robert Elliott Signed-off-by: Don

[PATCH v5 38/42] hpsa: use scsi host_no as hpsa controller number

Reviewed-by: Hannes Reinecke Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 134 --- 1 file changed, 74 insertions(+), 60 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 674d55a..7b82c67

<    1   2   3   4   5   6   7   8   9   10   >